Cover Letter Detail
Show a cover letter.
GET /api/covers/12657/?format=api
{ "id": 12657, "url": "https://patchwork.libcamera.org/api/covers/12657/?format=api", "web_url": "https://patchwork.libcamera.org/cover/12657/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210618220430.31457-1-david.plowman@raspberrypi.com>", "date": "2021-06-18T22:04:27", "name": "[libcamera-devel,v3,0/3] Support monochrome raw sensors", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/12657/mbox/", "series": [ { "id": 2155, "url": "https://patchwork.libcamera.org/api/series/2155/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2155", "date": "2021-06-18T22:04:28", "name": "Support monochrome raw sensors", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2155/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/12657/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0DAAC3218\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jun 2021 22:04:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 005FE68947;\n\tSat, 19 Jun 2021 00:04:36 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B16E46050C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 19 Jun 2021 00:04:33 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n\tf16-20020a05600c1550b02901b00c1be4abso9551167wmg.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 15:04:33 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tz6sm6966322wrl.15.2021.06.18.15.04.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Jun 2021 15:04:32 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"gEh7Edi5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=hjGmaF2knE0w6Yr1G0VwmIfp/gCusKiVrS4Fn8WW0PA=;\n\tb=gEh7Edi5Rdu+gyWylhZL4uJ+6o8esB5K8y8FBPOOvSNOrbryuAGcsjiq2rwb1HuMQe\n\tQRPtHLmjiKBrBJiPBK1iEmaZMfHZR6KcZCRuA+MXhd5kQSsemN4+ZSZhABH2/M5BZ35F\n\tUFyiGwyjV1h5rKrSrCujaSGmJKMTruCtkQscZc07ZSudgJyPQucQHUxRVgXeoF+cyZJz\n\thstB1nyysq4AOTXZoC7fAVZHps9WmBSuxNYV6L6h6HPWszyPkEsZW2vb12sCnLl6sKqo\n\tBGvQPUuq8GvdFzb5y2VzStwMsAYh2aC5sFNQUwlz2jIjLGio7+ssfLNnBkhIA+GerTwV\n\t4vAg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=hjGmaF2knE0w6Yr1G0VwmIfp/gCusKiVrS4Fn8WW0PA=;\n\tb=mdfL3ea3Q4l0NgZKFrubi4ZuCVHzTt8vr89mb4UJejRYGFL2qZM3W2r5zXV2twFUpN\n\tRDJjDWq1BtYPvbwHf0i2tI6FxrKEWaRU0CMXjE0PzkSZC+DD8GxqEINSXaODdaXl823H\n\tnITIvOzaXiTm9R98R9aM8j/Ug8jiRcLlgyU3PfpmkxU9G/qQEVcpiCoPXqLgSLj56N83\n\tHDashir+qQqGBp5KCwp8fqfZZvyrp0FsBS6vidqYZ0zFWhjofqc2IMDa77BRvcIdxOwl\n\tB8tYNOB58r+Wie4ZcSWrtt8y+rXeBGpyv/dOhKI9wynD/XaOvZuujA06vjLXeQGS7h8v\n\t5/Pg==", "X-Gm-Message-State": "AOAM531X2W3v4gffMuWYe0EEl4lYdMULJgPltpnk7XNRnUmNeD6RH++F\n\tNd9/BuxJhd5/W1X+xSeeIBm1BuJaVjjOXvQG", "X-Google-Smtp-Source": "ABdhPJwj11ZEI1dVfCj24Q7qqQtkk8T/jelpsMtqSr72TLth4Nffb6i7aMeVL/Ts2KwEFO6m0kyNrA==", "X-Received": "by 2002:a05:600c:2284:: with SMTP id\n\t4mr13800971wmf.148.1624053872408; \n\tFri, 18 Jun 2021 15:04:32 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Jun 2021 23:04:27 +0100", "Message-Id": "<20210618220430.31457-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 0/3] Support monochrome raw sensors", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi again\n\nHere's a v3 set which addresses Kieran's comments, so thanks for\nthose! Otherwise everything is functionally the same as before.\n\nTo answer Kieran's other questions:\n\n* Yes, a monochrome raw sensor is very different to a monochrome\n non-raw sensor! No black levels, vignetting to worry about on those,\n among other things.\n\n* On the question of warning about missing AWB results only for\n monochrome sensors. Yes, that's a reasonable thought, though at the\n moment I don't think the IPA side of the world even knows if a\n sensor is monochrome. We'd have to pass that somehow, maybe in the\n IPACameraSesnsorInfo? That's perhaps a slightly longer discussion,\n I'm not entirely sure I want to open that right now...\n\n* We need to be very nice to Dave, but then the plan would be to start\n upstreaming new drivers, as we've been doing previously. There are a\n couple more I'd like to get going too. Some of them would need a\n \"Y12P\" format, which seems to be missing from the kernel, currently.\n\n* The tuning I've given for the OV9281 is for an Innomaker module, or\n maybe not, I'm not sure what it is. But it actually makes\n surprisingly little difference as there is no colour shading, AWB or\n colour matrices to worry about.\n\nThanks\nDavid\n\n\nDavid Plowman (3):\n libcamera: Add support for monochrome sensors\n libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results\n libcamera: ipa: raspberrypi: Add support for ov9281 sensor\n\n include/libcamera/internal/bayer_format.h | 3 +-\n src/ipa/raspberrypi/cam_helper_mov9281.cpp | 65 +++++++++++++++\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 +-\n src/ipa/raspberrypi/data/meson.build | 1 +\n src/ipa/raspberrypi/data/mov9281.json | 92 +++++++++++++++++++++\n src/ipa/raspberrypi/meson.build | 1 +\n src/libcamera/bayer_format.cpp | 14 +++-\n src/libcamera/camera_sensor.cpp | 3 +\n src/libcamera/property_ids.yaml | 4 +\n 10 files changed, 183 insertions(+), 6 deletions(-)\n create mode 100644 src/ipa/raspberrypi/cam_helper_mov9281.cpp\n create mode 100644 src/ipa/raspberrypi/data/mov9281.json" }