Cover Letter Detail
Show a cover letter.
GET /api/covers/12161/?format=api
{ "id": 12161, "url": "https://patchwork.libcamera.org/api/covers/12161/?format=api", "web_url": "https://patchwork.libcamera.org/cover/12161/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210503092705.15562-1-jacopo@jmondi.org>", "date": "2021-05-03T09:26:58", "name": "[libcamera-devel,v2,0/7] ipu3: imgu: Improve ImgU calculation procedure", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/12161/mbox/", "series": [ { "id": 1993, "url": "https://patchwork.libcamera.org/api/series/1993/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1993", "date": "2021-05-03T09:26:58", "name": "ipu3: imgu: Improve ImgU calculation procedure", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1993/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/12161/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CB68BDE78\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 May 2021 09:26:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13C5A6891C;\n\tMon, 3 May 2021 11:26:26 +0200 (CEST)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ED01602C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 May 2021 11:26:24 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 57B4BE0003\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 May 2021 09:26:24 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 May 2021 11:26:58 +0200", "Message-Id": "<20210503092705.15562-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 0/7] ipu3: imgu: Improve ImgU\n\tcalculation procedure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To the ImgU pipeline calculation.\n\nTo recap: the current ImgU calculation procedure doesn't work if we select\na sensor resolution smaller than the full frame size, and result in a\nstall in the ImgU producing frames, or in an error in finding any configuration\nat all.\n\nThis set of improvements fixes some of the issues we had.\nIn example, on Soraka\n$ cam -swidth=1280,height=720 -swidth=640,height=480 -c1 -C\nnow works with a 2112x1188 frame input.\n\nAs the ImgU is not been validated with 320x240 resolutions, some use cases\nlike main=1920x1080,vf=320x240 remain broken and commit\n7208e70211a6 (\"libcamera: ipu3: Always use sensor full frame size\")\ncannot be yet reverted.\n\nThe series remains of awful quality, I just collected tags and applied a few\ncomments here and there and re-tested with CTS.\n\nI've dropped the controversial \"libcamera: ipu3: imgu: Change IF_CROP_MAX to 40\"\nas the issue is not clarified.\n\nI've opened a new issue on the Python script to replicate one of the comments\nreceived by Laurent on v1 https://github.com/intel/intel-ipu3-pipecfg/issues/2\nand referenced it in code.\n\nOverall, the final result is not worse than how the ImgU configuration procedure\nlooked like before, it might fixes some bugs, but nobody is really happy with\nthe result :(\n\nNo regressions detected when running CTS.\n\nJacopo Mondi (7):\n libcamera: ipu3: imgu: Update BDS calculation process\n libcamera: ipu3: imgu: Filter BDS by height\n libcamera: ipu3: imgu: Fix BDS height calculation\n libcamera: ipu3: imgu: Fix IF height selection\n libcamera: ipu3: imgu: Fix BSD height size comparison\n libcamera: ipu3: imgu: Add pipe calculation debug\n libcamera: ipu3: imgu: Bump script version\n\n src/libcamera/pipeline/ipu3/imgu.cpp | 111 +++++++++++++++++++++------\n 1 file changed, 89 insertions(+), 22 deletions(-)\n\n--\n2.31.1" }