Cover Letter Detail
Show a cover letter.
GET /api/covers/12156/?format=api
{ "id": 12156, "url": "https://patchwork.libcamera.org/api/covers/12156/?format=api", "web_url": "https://patchwork.libcamera.org/cover/12156/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210430173803.198220-1-jacopo@jmondi.org>", "date": "2021-04-30T17:38:00", "name": "[libcamera-devel,v6,0/3] Introduce CameraSensorProperties database", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/12156/mbox/", "series": [ { "id": 1991, "url": "https://patchwork.libcamera.org/api/series/1991/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1991", "date": "2021-04-30T17:38:00", "name": "Introduce CameraSensorProperties database", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1991/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/12156/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD9C7BDE4F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Apr 2021 17:37:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBF4E68911;\n\tFri, 30 Apr 2021 19:37:27 +0200 (CEST)", "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 203F4688A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Apr 2021 19:37:26 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 8ED4A200006;\n\tFri, 30 Apr 2021 17:37:25 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Apr 2021 19:38:00 +0200", "Message-Id": "<20210430173803.198220-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 0/3] Introduce CameraSensorProperties\n\tdatabase", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n reworked [1/3] to address Laurent's comments\n\n- Drop SensorDatabase class and move the static get() method to\n CameraSensorProperties\n- Remove the macro and initialize the CameraSensorProperties map in-place\n- Drop tags as the patch has changed\n\nI had to declare CameraSensorProperties as struct as otherwise initializing the\nmap with an initializer list gives me:\n\n../src/libcamera/camera_sensor_properties.cpp:58:2: error: could not convert\n‘{{\"imx219\", <expression error>}, {\"ov5670\", <expression error>}, {\"ov13858\",\n<expression error>}}’ from ‘<brace-enclosed initializer list>’ to ‘const\nstd::map<std::__cxx11::basic_string<char>, const\nlibcamera::CameraSensorProperties>’\n\nThis could probably be closed by adding a constructor to the\nCameraSensorProperties class. I fear that this won't scale well, as for any new\nparameter added to the class we'll need to add an element to the constructor\nand this could get ugly quite quickly. Hence, declare CameraSensorProperties as\na struct and allow named member initilization.\n\nThanks\n j\n\n\nJacopo Mondi (3):\n libcamera: Introduce camera sensor properties\n libcamera: camera_sensor: Register static properties\n android: camera_device: Report sensor physical size\n\n include/libcamera/internal/camera_sensor.h | 1 +\n .../internal/camera_sensor_properties.h | 24 +++++++\n include/libcamera/internal/meson.build | 1 +\n src/android/camera_device.cpp | 30 ++++----\n src/libcamera/camera_sensor.cpp | 16 ++++-\n src/libcamera/camera_sensor_properties.cpp | 71 +++++++++++++++++++\n src/libcamera/meson.build | 1 +\n 7 files changed, 129 insertions(+), 15 deletions(-)\n create mode 100644 include/libcamera/internal/camera_sensor_properties.h\n create mode 100644 src/libcamera/camera_sensor_properties.cpp\n\n--\n2.31.1" }