Cover Letter Detail
Show a cover letter.
GET /api/covers/11843/?format=api
{ "id": 11843, "url": "https://patchwork.libcamera.org/api/covers/11843/?format=api", "web_url": "https://patchwork.libcamera.org/cover/11843/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210406104050.23814-1-david.plowman@raspberrypi.com>", "date": "2021-04-06T10:40:48", "name": "[libcamera-devel,v2,0/2] Fix CameraSensor::sensorInfo by updating VBLANK ControlInfo", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/11843/mbox/", "series": [ { "id": 1895, "url": "https://patchwork.libcamera.org/api/series/1895/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1895", "date": "2021-04-06T10:40:48", "name": "Fix CameraSensor::sensorInfo by updating VBLANK ControlInfo", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1895/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/11843/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F504BD695\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Apr 2021 10:41:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75E016879E;\n\tTue, 6 Apr 2021 12:41:01 +0200 (CEST)", "from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0904760518\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Apr 2021 12:40:58 +0200 (CEST)", "by mail-ej1-x630.google.com with SMTP id w3so21129762ejc.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Apr 2021 03:40:58 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tdf8sm4068486edb.4.2021.04.06.03.40.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Apr 2021 03:40:57 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"JxD4SiDD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=rSOJgaNUw3NF/cZf8r+FqCQTK/JHz4v6Ca7da4ob6Vs=;\n\tb=JxD4SiDDbQw1FT5Sw9AGB34xghXw2oz5G1jKHJNYP1vSPnf7YxckCldKAeQeWj8IJq\n\tDjE1hRlQXxyGeEWC+eRg6RbgKSzhAHCM7N7jGZih+CAj7vQYDuyVzawLr+HCVhHcKbwy\n\t6l1rlSjDtlSIp9AX/p6vWtywCTmL92OdCZZSHGDbFxysCnJRi5gbEmwf0SkwGFNLRy3w\n\tdBMUCzPKDZH7UlSsbADLgK1fCMz5N0UvjvAMg2wjDpPDWczXgEqMMrFSOo9Tjb131IAh\n\tNZsNkZ/mvy4WWIuFDFlB9mloaI9Bn/Dk87a0x6GvkibvQgipdgfQVYPCYcNR/IHutyMR\n\t96bQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=rSOJgaNUw3NF/cZf8r+FqCQTK/JHz4v6Ca7da4ob6Vs=;\n\tb=XVjctD1EaIDSs7DyogjtGhzuZx8/SyzkmvnifkEh4kcur8uwEZERRiQ8M5TfEnYKq2\n\taD0qCbLbaLKfXbhF9dUxCJ/w73/Xj5TLmifCnRVdIS4NpZ629GaRTxztOPVgpG6KNs7H\n\tSBUa7fdU1QvRt2oAPRBABM3b8RllPnh401x3M+58a/97s4++vhCRdxI6AWYST6j2JGKr\n\tVBTIO3pAi1WgRGFtZQlvxg3HgoppuTQvnFYhUEPF/E6+mPGt1tiPYEoGuWh2mk+xbK6p\n\tu8mSrXJ90UR0TfkgG8vVBy811rQsr2eyJU3djIr3yROnYPoUYHEeYtODV/zqd3Wrxzif\n\thJqQ==", "X-Gm-Message-State": "AOAM5323ZuwZt7Thb3a1YzB0uRNb+vqwB7nlNke8Y6AKcyEYOwCoXoqv\n\tLGWAsOufCKX7kyef2DiQlsZGkfa67WZU2Q==", "X-Google-Smtp-Source": "ABdhPJzB+95802T2i37sebTjVb2iTQowvcgvFytS5EQrwMQVgTJ/qLdMRxpNu2nieutUndEIiWp0hQ==", "X-Received": "by 2002:a17:906:2349:: with SMTP id\n\tm9mr20135644eja.98.1617705658211; \n\tTue, 06 Apr 2021 03:40:58 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 6 Apr 2021 11:40:48 +0100", "Message-Id": "<20210406104050.23814-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 0/2] Fix CameraSensor::sensorInfo by\n\tupdating VBLANK ControlInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nHere's a second version of the CameraSensor::sensorInfo() fix, taking\naccount of some of Jacopo's suggestions. The principal differences\nare:\n\n1. I renamed the new method to \"updateControlInfos\". It seems to me a\nmore accurate description of what the method is doing!\n(\"refreshControls\" was rather vague.)\n\n2. CameraSensor::setFormat calls updateControlInfos directly, so it's\nonly pipeline handlers like the RPi one (which don't use\nCameraSensor::setFormat) that must do so for themselves.\n\n3. This (trivial) RPi pipeline handler update is in a separate commit,\nto keep it separate from the \"core\" changes.\n\n4. I didn't go with the \"lazy\" implementation, which would have a flag\nin the CameraSensor that gets set, and checked before the controls are\nused. But we could change our minds on that at any point, it's merely\nan implementation detail of the CameraSensor class now.\n\nI did try to add a ControlInfo::update (and V4L2ControlInfo::update)\nmethod but, after being hounded by switch statements and casts, I\nfound it ended up all but identical to the assignment operator - so I\nremoved it again. But I'm still open to offers there...!\n\nThanks\n\nDavid\n\nDavid Plowman (2):\n libcamera: camera_sensor: Fix frame lengths calculated by sensorInfo()\n libcamera: pipeline: raspberrypi: Update ControlInfos after sensor\n format change\n\n include/libcamera/internal/camera_sensor.h | 2 ++\n include/libcamera/internal/v4l2_device.h | 2 ++\n src/libcamera/camera_sensor.cpp | 31 ++++++++++++++++++-\n .../pipeline/raspberrypi/raspberrypi.cpp | 6 ++++\n src/libcamera/v4l2_device.cpp | 26 ++++++++++++++++\n 5 files changed, 66 insertions(+), 1 deletion(-)" }