Cover Letter Detail
Show a cover letter.
GET /api/covers/11691/?format=api
{ "id": 11691, "url": "https://patchwork.libcamera.org/api/covers/11691/?format=api", "web_url": "https://patchwork.libcamera.org/cover/11691/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210324114415.19866-1-david.plowman@raspberrypi.com>", "date": "2021-03-24T11:44:13", "name": "[libcamera-devel,0/2] Raspberry Pi: handle sensors more flexibly", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/11691/mbox/", "series": [ { "id": 1827, "url": "https://patchwork.libcamera.org/api/series/1827/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1827", "date": "2021-03-24T11:44:13", "name": "Raspberry Pi: handle sensors more flexibly", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1827/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/11691/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3902C32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 11:44:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35FF768D69;\n\tWed, 24 Mar 2021 12:44:21 +0100 (CET)", "from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n\t[IPv6:2a00:1450:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41019602E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 12:44:19 +0100 (CET)", "by mail-ej1-x62e.google.com with SMTP id ce10so32322061ejb.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 04:44:19 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tc17sm1054781edw.32.2021.03.24.04.44.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Mar 2021 04:44:18 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"V+moEZR1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=awcwv7zsUa3zN0b0ABLzu8wgT9s3NziYbE3rxcc4AaE=;\n\tb=V+moEZR1IpnGK0n+g18Z54fDeHjWXChcOjMj6c8/g5trMju8ejQqFxYxQ7Ki/HnKkl\n\tGWj9/JdJL4ZnFGNfNaSIn+1hTI6rRfMWHTK+CK6zJci3jMF+jUVEkXLdvmKwvu3D8B+0\n\tMLuYT2tB3EeVH8CKH8pr9aj3QzZiR+ZjYQ/q2hMZeO95aoSriEIo8nEPQfdQTMya4ZAb\n\tKyRW/vE8EVVNdZpYrmXJgswp7UGh0cSwa/4IijJy46On1RW3QVTSi285w7R41kS1pIxN\n\tZO2/ulpMuRuvLhyce8N4hHQ3zhk2QijFrw8nTpxENBFXXfz8Y9XidZ5sNiAhPAv6dBHN\n\tMfLg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=awcwv7zsUa3zN0b0ABLzu8wgT9s3NziYbE3rxcc4AaE=;\n\tb=bzRzCoe7a1yBQbjdneeMG+paSb7pNg/IQA7vwLu7/2rEtEPP/VReMcEmTFmVbnLiwM\n\tz5JIvvntU7qQlnT10nVuhX61p2fFHHWreJ2NhHtxKTs6mioc/1VRXZXSf+budD3VKCyz\n\tJTYEp6Lr3dQbVI9K9TOeuXwZejlQNvaDvXukpZMmWuYtzNTgUXwUqEEB2NLvSkk6lyMG\n\tm+e/jLpr7D29y3xFkHkpSCs+tk894kMwMiBArjUAitdYDmTkNFAaVFzQ51WBZEOl6lDN\n\t2KhHX4Tha4bKy4QCWCJUsT2NmqDx0BRVtXwoe4qX1d16Mt4m8hcckzya6r6sKyUQao1t\n\t5Vsg==", "X-Gm-Message-State": "AOAM5311sVrqeEkxzPeiDyKlPsz0nlR4+91+svnXAJe0HTkwUux+TjYV\n\tR0+hKpQItyRbyyqLuKpLYRVe+52916ufYQ==", "X-Google-Smtp-Source": "ABdhPJzHfK6DJXZED63dRQk/2Z7ZEh80J1CcBjlWc0nr1zr+8Q5CNXG3mtqucd4DEW6MDXSm5aoKCw==", "X-Received": "by 2002:a17:907:7637:: with SMTP id\n\tjy23mr3098980ejc.12.1616586258410; \n\tWed, 24 Mar 2021 04:44:18 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 24 Mar 2021 11:44:13 +0000", "Message-Id": "<20210324114415.19866-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/2] Raspberry Pi: handle sensors more\n\tflexibly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nHere are a couple more patches aimed at allowing us to deal more\nflexibly with \"interesting\" sensors.\n\nThe first patch simply makes the CamHelper's exposure-related methods\nvirtual. This gives greater flexibility on how we deal with sensors\nwhere different modes have different signal levels. Differences\nbetween modes can be accounted for with the gain methods (already\nvirtual), in the exposure (with this change), or via a combination of\nthe two.\n\nNote that another solution to this involves fiddling around with the\nAGC. It would have to know that modes can have different \"base signal\nlevels\", and account for the difference. I'm still in several minds\nabout whether I want to do this, so this change gives us options in\nthe meantime, and doesn't preclude messing with the AGC later if we\nwish.\n\nThe second commit takes the view that if sensors seem to be asking for\nthe red/blue colour gains, then we should tell them. I guess there's a\nrisk that some sensors might seem to want these numbers, but we find\nthat we don't want to tell them. If that happens maybe the CamHelper\nwould have to tell us what to do, but this approach seems reasonable\nto me at this point.\n\nI also apply a fixed 256x multiplier to the colour gains before\npassing them to the control. I don't think V4L2 docs mandate any\nparticular scale here? Maybe there's an argument for another\nCamHelper function \"ColourGainCode\", or something like that.\n\nThoughts and suggestions welcome as always. Thanks!\n\nDavid\n\nDavid Plowman (2):\n ipa: raspberrypi: Make CamHelper exposure methods virtual\n ipa: raspberrypi: Update sensor's RED/BLUE balance controls when\n present\n\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n src/ipa/raspberrypi/raspberrypi.cpp | 17 ++++++++++++++---\n .../pipeline/raspberrypi/raspberrypi.cpp | 9 +++++++++\n 3 files changed, 25 insertions(+), 5 deletions(-)" }