Cover Letter Detail
Show a cover letter.
GET /api/covers/11444/?format=api
{ "id": 11444, "url": "https://patchwork.libcamera.org/api/covers/11444/?format=api", "web_url": "https://patchwork.libcamera.org/cover/11444/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210302122341.83985-1-kieran.bingham@ideasonboard.com>", "date": "2021-03-02T12:23:39", "name": "[libcamera-devel,0/2] libcamera: Request: Catch double completions", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/11444/mbox/", "series": [ { "id": 1739, "url": "https://patchwork.libcamera.org/api/series/1739/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1739", "date": "2021-03-02T12:23:39", "name": "libcamera: Request: Catch double completions", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1739/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/11444/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E39FBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Mar 2021 12:23:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BEBF68AA8;\n\tTue, 2 Mar 2021 13:23:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7782E68A93\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Mar 2021 13:23:45 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5CE945D;\n\tTue, 2 Mar 2021 13:23:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iWPc9Pac\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614687825;\n\tbh=gUHZ3u93eEFqO1nTOQDImDkZOf9NgBBMS3+rhkj83rc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=iWPc9PacUIJs2QUjbL7zvct867Q8UAgFvDF69jdqYPN/ZiA25ml3aFey0xd747IZ8\n\tcwF0uUShIZ7iPeN18CUk5rdk9r0aBO4qRJP81cir2NxczZGoGPwlcVzJgK1vLI6C4n\n\tYctNhlE9z6dFg/LN6GJ9nVQWQrhKwXmJYlmy1uoo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 2 Mar 2021 12:23:39 +0000", "Message-Id": "<20210302122341.83985-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/2] libcamera: Request: Catch double\n\tcompletions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If a Request is completed, when it has already been completed, this is\nthe equivalent to a use-after-free.\n\nWhen completed, the application regains control of the object, and can\nchoose to either free the memory, or call request->reuse().\n\nIn both of those scenarios the Request should not be touch by the\nPipeline Handler until it is re-queued.\n\nThere appear to be some races or bugs around here, so add an assert to\ncatch this early, and fix a comment related to the usage.\n\nKieran Bingham (2):\n libcamera: Request: validate state on complete\n libcamera: pipeline_handler: Update request usage comment\n\n src/libcamera/pipeline_handler.cpp | 4 ++--\n src/libcamera/request.cpp | 2 ++\n 2 files changed, 4 insertions(+), 2 deletions(-)" }