Cover Letter Detail
Show a cover letter.
GET /api/covers/10693/?format=api
{ "id": 10693, "url": "https://patchwork.libcamera.org/api/covers/10693/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10693/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201222135849.38052-1-kieran.bingham@ideasonboard.com>", "date": "2020-12-22T13:58:47", "name": "[libcamera-devel,0/2] libcamera: file: Don't parse directories", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/10693/mbox/", "series": [ { "id": 1540, "url": "https://patchwork.libcamera.org/api/series/1540/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1540", "date": "2020-12-22T13:58:47", "name": "libcamera: file: Don't parse directories", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1540/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10693/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20366C0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Dec 2020 13:58:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FAB8615D2;\n\tTue, 22 Dec 2020 14:58:56 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A293E60528\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Dec 2020 14:58:54 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BCC69E6;\n\tTue, 22 Dec 2020 14:58:54 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iYhmmI3f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608645534;\n\tbh=BWXeQu7WrjA9BzdKzwIACZ/vbb7ApF7nl0N+ZEKHiK8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=iYhmmI3fEZysBs0bwHIW4iSLt7F/CCk3+zuk8nw/bUilsH6DqgRrV4FlIkv1tzTXq\n\thaGdE2j7Zi3GIg+VfjztfIiQnP5vWepPwmrTyc42+6fIQ+vPDuVL5Rfvk5+/G9tOB4\n\tNYjKOceZKFwSjyhnJX6vr+tvtE9N6okqL2j5nyAo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 22 Dec 2020 13:58:47 +0000", "Message-Id": "<20201222135849.38052-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/2] libcamera: file: Don't parse\n\tdirectories", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "During development, and checking that the file I needed existed, I hit a\nfault where the path was inadvertantly pointing to a directory.\n\nThe call to File::exists() then succeeded, and the code attempted to\nparse a directory as if it were a file, with expectedly undesireable\nresults.\n\nAdd a test to ensure that File::exists does not return true when given a\ndirectory and fix the underlying issue.\n\nKieran Bingham (2):\n test: file: Check that directories are not treated as files\n libcamera: file: Check files exist()\n\n src/libcamera/file.cpp | 3 ++-\n test/file.cpp | 5 +++++\n 2 files changed, 7 insertions(+), 1 deletion(-)" }