Cover Letter Detail
Show a cover letter.
GET /api/covers/10597/?format=api
{ "id": 10597, "url": "https://patchwork.libcamera.org/api/covers/10597/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10597/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201207180121.6374-1-david.plowman@raspberrypi.com>", "date": "2020-12-07T18:01:15", "name": "[libcamera-devel,v2,0/6] Raspberry Pi AGC: initial frame drop count", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/10597/mbox/", "series": [ { "id": 1511, "url": "https://patchwork.libcamera.org/api/series/1511/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1511", "date": "2020-12-07T18:01:15", "name": "Raspberry Pi AGC: initial frame drop count", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1511/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10597/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63452BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Dec 2020 18:01:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E943E67E6C;\n\tMon, 7 Dec 2020 19:01:49 +0100 (CET)", "from mail-ed1-x529.google.com (mail-ed1-x529.google.com\n\t[IPv6:2a00:1450:4864:20::529])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 368EE635A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Dec 2020 19:01:48 +0100 (CET)", "by mail-ed1-x529.google.com with SMTP id b2so14713427edm.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 07 Dec 2020 10:01:48 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tbe6sm14657977edb.29.2020.12.07.10.01.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Dec 2020 10:01:35 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"H/b0ZpUK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SrJh41mzZJSU8iGwBwl9bnWoLDVGry3P5lseWpXoVUs=;\n\tb=H/b0ZpUKpme/PG1Au74FVkzayPQCQbIm2QSCXGpDoDUtr6+/AxWgAwmYMrF051cUl8\n\tzcHWh0UAHFaqnJfRyH74jm25S3MJPbnDM2Vdcj6Kdthr1xpjtWgzKXD+5cbMtD/trZ+P\n\tst9ZAKQG0WDynpu33rNSJhyUPjhPA0c0GxUQFuSiwaV//4KVwscNnZKlhurnK1bSAi2o\n\tSmaiPwssXsZFMEbsR6F1nybOSh1iHLa3S2B0BS5OkQPzeVJ7tWjKxCn57+tCib7kWQI1\n\t/PCXEk8V+GrghrWztBVE38bdMn4nzTadfHDud2eII73WjwbJ50T0FXdDoO86wNjHD4Hv\n\t8WUg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SrJh41mzZJSU8iGwBwl9bnWoLDVGry3P5lseWpXoVUs=;\n\tb=lJh875fX2sfG4I+R8suq1Tm4Lmm35Sky1eu+o4qsbYEqu7P6E6T6mHYkceDpFBQpf6\n\tWEyr1ahX5q+hgSwlfsO5hKutZxy5uLU28JbaZitppaqd8rqa4xefpGFvaaKRp1dqk5XU\n\t7mEqp99Vj8inYjV80CDj8Br2abh0snaeJ9zkPUdX/ceRsrT3wBUor1dq4g3hOrAfn2eB\n\tnbzlu4PrkIXncy3DtildbUbjuY74BqykdcPT8w0x1KuuzyCJtVr2MD2hvD4z2wP+wSX2\n\tKjQMMJHCVQVRh+/pVAIJ4JuWRRMPbJg/qKGTcW4i3HsFHxkFUmOxkBH8Mghwd0jh/PkZ\n\tKYuQ==", "X-Gm-Message-State": "AOAM532SwZjEqfvDo4bk+7ignIReSXQZYRA6KXtAy30XeGZTidk4zLFH\n\tz//GfahJTs2QgV6zU+0JST5h1Nch0gtPPIKz", "X-Google-Smtp-Source": "ABdhPJxmibhupHxnTOmhwz3lHMck/9xJ021n4H0S5nbJPWft6bi4evcJLBKq5ca9NdVWlpwMbzqoqA==", "X-Received": "by 2002:a05:6402:46:: with SMTP id\n\tf6mr6842533edu.163.1607364107270; \n\tMon, 07 Dec 2020 10:01:47 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 7 Dec 2020 18:01:15 +0000", "Message-Id": "<20201207180121.6374-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 0/6] Raspberry Pi AGC: initial frame\n\tdrop count", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nThanks for the reviews, comments and suggestions. Here's a version 2\nthat takes account of the feedback. There are now 6 commits:\n\n1. This actually squashes together the previous first two patches, but\nis otherwise unchanged.\n\n2. The new method for Agc is called GetConvergenceFrames, but this is\notherwise unchanged.\n\n3. The same as the previous patch, but for Awb rather than Agc.\n\n(There's actually an issue here - the AWB really only takes one frame\nto converge, except the calculation runs in another thread so you\ncan't be certain. So for that reason I've left the value at 3. I don't\nreally feel inclined to complicate everything on account of\nthis... but it is something to keep in mind.)\n\n4. A helper function for the Pwl (piecewise linear function) class\nthat I found useful in the following patch.\n\n5. Here we extend the AWB to estimate a colour temperature given fixed\ncolour gains. We pass this out in the metadata where the ALSC picks it\nup in its SwitchMode. I only do this the very first time everything\nstarts - I'm not convinced about doing it on other occasions, though\nwe could review that based on the usage it gets.\n\n(Note: looking through awb.cpp I am reminded it needs a bit of a tidy\nlike we have done elsewhere, such as in ALSC and AGC. I left myself a\nlittle reminder at the top to get back to this once we've got our apps\nout of the door!)\n\n6. This patch is essentially the final two patches of the v1 set. I\nsquashed them together because I think the ov5647 change makes more\nsense incorporated. Beyond that the only real difference is that I\nquery both the AGC and AWB for their convergence numbers, and handle\nthem in the way proposed in some of the discussions.\n\nYou may notice that I haven't given ALSC a GetConvergenceFrames\nmethod. In fact it just tags along with the AWB, reading the colour\ntemperature that it produced. If AWB is happy, so is ALSC. If AWB\nneeds frames to converge, so does ALSC. It has no \"independance\" in\nthis regard, so it felt tidier to leave it alone.\n\nHope that makes sense!\n\nThanks and best regards\nDavid\n\nDavid Plowman (6):\n src: raspberrypi: Pass the drop frame count in start, not configure\n src: ipa: raspberrypi: agc: Add GetConvergenceFrames method to AGC\n base class\n src: ipa: raspberrypi: agc: Add GetConvergenceFrames method to AWB\n base class\n src: ipa: raspberrypi: Compute inverse of piecewise linear function\n src: ipa: raspberrypi: Estimate the colour temerature if starting with\n fixed colour gains\n src: ipa: raspberrypi: Move initial frame drop decision to AGC/AWB\n\n src/ipa/raspberrypi/cam_helper.cpp | 6 +-\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 10 +++\n .../raspberrypi/controller/agc_algorithm.hpp | 1 +\n .../raspberrypi/controller/awb_algorithm.hpp | 1 +\n src/ipa/raspberrypi/controller/pwl.cpp | 27 ++++++++\n src/ipa/raspberrypi/controller/pwl.hpp | 3 +\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 13 ++++\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 6 +-\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 27 ++++++++\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 3 +\n src/ipa/raspberrypi/raspberrypi.cpp | 61 +++++++++++++------\n .../pipeline/raspberrypi/raspberrypi.cpp | 25 ++++----\n 13 files changed, 149 insertions(+), 36 deletions(-)" }