Cover Letter Detail
Show a cover letter.
GET /api/covers/10547/?format=api
{ "id": 10547, "url": "https://patchwork.libcamera.org/api/covers/10547/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10547/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201202135354.264212-1-jacopo@jmondi.org>", "date": "2020-12-02T13:53:50", "name": "[libcamera-devel,v2,0/4] libcamera: Collect pixel array properties", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/10547/mbox/", "series": [ { "id": 1501, "url": "https://patchwork.libcamera.org/api/series/1501/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1501", "date": "2020-12-02T13:53:50", "name": "libcamera: Collect pixel array properties", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1501/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10547/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AB45BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Dec 2020 13:53:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E2D1635A8;\n\tWed, 2 Dec 2020 14:53:58 +0100 (CET)", "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C152634A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Dec 2020 14:53:57 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D05D320013\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Dec 2020 13:53:56 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Dec 2020 14:53:50 +0100", "Message-Id": "<20201202135354.264212-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 0/4] libcamera: Collect pixel array\n\tproperties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This has been floating around for quite some time never really got\nto the bottom of it as it required to make V4L2, libcamera and android\nproperties get along with each other.\n\nTo summarize my understanding:\n\nV4L2:\n- NATIVE: size of the pixel array matrix (readable and not readable)\n- BOUNDS: readable pixels (valid and non valid); defined in respect to NATIVE\n- CROP_DEFAULT: active pixels; defined in respect to NATIVE\n\nLibcamera:\n- PixelArraySize: Size of the readable area\n- PixelArrayActiveAreas: Active areas, defined in respect to PixelArray\n\nPixelArraySize = { BOUNDS.width, BOUNDS.heigh }\nPixelArrayActiveAreas = {\n\tCROP_DEFAULT.x - BOUNDS.x,\n\tCROP_DEFAULT.y - BOUNDS.y,\n\tCROP_DEFAULT.width,\n\tCROP_DEFAULT.height\n}\n\nWhen it comes to map to Android :\n\nandroid.sensor.info.pixelArraySize = \"Dimensions of the full pixel array,\npossibly including black calibration pixels\"\n\nandroid.sensor.info.activeArraySize = \"The area of the image sensor which\ncorresponds to active pixels after any geometric distortion correction has been\napplied.\" -> defined in respect to pixelArarySize\n\npixelArraySize = libcamera::properties::PixelArraySize\nactiveAreasSize = libcamera::properties::PixelArrayActiveAreas\n\nThe first patch on the series adjusts the CameraSensorInfo analog rectangle\nto match the V4L2 target definitions, and requires the imx219 driver\nto be fixed accordingly:\nRPi downstream: https://github.com/raspberrypi/linux/pull/3983\nLinux mainline (should land in v5.11)\nhttps://patchwork.linuxtv.org/project/linux-media/patch/20200805105721.15445-5-jacopo@jmondi.org/\n\nCurrently the sensor drivers for the Soraka device do not support G_SELECTION so\nno properties are registered in Android for CrOS on Soraka.\n\nThanks\n j\n\nJacopo Mondi (4):\n libcamera: camera_sensor: Adjust CameraSensorInfo::analogCrop\n libcamera: camera_sensor: Break out properties initialization\n libcamera: camera_sensor: Initialize PixelArray properties\n android: camera_device: Initialize pixel array properties\n\n include/libcamera/internal/camera_sensor.h | 1 +\n src/android/camera_device.cpp | 33 +++++--\n src/libcamera/camera_sensor.cpp | 104 ++++++++++++++-------\n 3 files changed, 95 insertions(+), 43 deletions(-)" }