Cover Letter Detail
Show a cover letter.
GET /api/covers/10541/?format=api
{ "id": 10541, "url": "https://patchwork.libcamera.org/api/covers/10541/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10541/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201202115253.14705-1-david.plowman@raspberrypi.com>", "date": "2020-12-02T11:52:48", "name": "[libcamera-devel,0/5] Raspberry Pi AGC: initial frame drop count", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/10541/mbox/", "series": [ { "id": 1500, "url": "https://patchwork.libcamera.org/api/series/1500/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1500", "date": "2020-12-02T11:52:48", "name": "Raspberry Pi AGC: initial frame drop count", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1500/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10541/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E982CBE177\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Dec 2020 11:53:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57783635A6;\n\tWed, 2 Dec 2020 12:53:00 +0100 (CET)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D475634A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Dec 2020 12:52:58 +0100 (CET)", "by mail-wr1-x431.google.com with SMTP id 23so3516099wrc.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 02 Dec 2020 03:52:58 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tn189sm1739215wmf.20.2020.12.02.03.52.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Dec 2020 03:52:57 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"V8fKOzQj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=tEl0E2c2Nf7l7NPS4kjks3h3Zp0cl4Xk9OqQFeTEQ7E=;\n\tb=V8fKOzQjDfErC2N2P1BotPFjcQfrFtuP4wXl8fUp5E5fMlHryKhk6QPv15VWFPCi+z\n\t8THAGPX4Tkt8AWgI+ytSmgu8HjQvQ+Os3tJpt6g5isSqSZScjZs36SUYOtaxZC1gpwUS\n\to4Vp0ZtoIzfkyrwUPDN+03YcR2v21zTTadEw+SsVg2MuTbT+Uma5QuDFMTd57UK7ZU+R\n\tXWAblIeh5sk9iijD/u8Kywnq3CZ5noYskAaDR0vJ1R3HnDyDqEo54C/XS3HEJkE6ewBn\n\tlU/hP0qKDpHmWWHlXUtcmEWxUdDI9edJqL18vxpnzhB4nLk+fyWoZbOJ3wk8OF27V763\n\tDnWg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=tEl0E2c2Nf7l7NPS4kjks3h3Zp0cl4Xk9OqQFeTEQ7E=;\n\tb=cWRnVx2fpFxqnDyNLyWpuqzfU+WqgYMAB79qer6erIkaOvp03aC6G0kqoku6gF82IO\n\tH23rSRzMAoXt1OpJbAHdsujt/Fuwi3KGJfUaShguMyb5h9Ycjp4yXHbC3zvSXTYY8RW5\n\tU9qv/bzcFlIkUepj0Qop0AzDXmQfeK8jj+fE0manir9/2AFZIoYDwnNCeNKC+kJvlQce\n\t1pfrt+eAUUIbSYJdSi/8s+lkQjO4vytEj5XUBKV+CoMCo0V47OwouQva/+IoewY8YG9Y\n\t/MtyWDONLNVlXKAWMVik4GSzJSCtRCeNZNRQmPGb0FBcqENe/pkX+IAiqnROOS6PxtbD\n\t+6oA==", "X-Gm-Message-State": "AOAM530LL/ACW5VWF0WYuN/ihf5zjo2cWU09Sw/qw6+ieLJAhv+4eQR+\n\tV/0YGksy/75GLm0HCJK6/KiOFxEmK22SLADG", "X-Google-Smtp-Source": "ABdhPJxa7SD02rHsQYV4COJM1/bpz7L0hFMAWKDgiYNRfYVgbq75BiznteddZXzMIpANgqezKBVBhw==", "X-Received": "by 2002:adf:f00f:: with SMTP id\n\tj15mr3021238wro.102.1606909977836; \n\tWed, 02 Dec 2020 03:52:57 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Dec 2020 11:52:48 +0000", "Message-Id": "<20201202115253.14705-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/5] Raspberry Pi AGC: initial frame drop\n\tcount", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nThanks for merging my last set of AGC related patches. Here's the\nfinal set of AGC patches that I have prior to the release of our\nlibcamera apps, I'm hoping we can get a bit of a head start with them!\n\nThe patches are all quite bitesize, and are concerned with deciding\nhow many frames our pipeline handler should drop when the camera\nstarts up for the first time (while the AGC converges from cold).\n\nResponsibility has been moved from the CamHelper class, where it was\nentirely inappropriate really, to the AGC itself. One of the patches\nis dependent on Naush's Camera::start patch set so maybe we look\nslightly askance at that one for now! So we have:\n\n1. Add a flag to the pipeline handler so we know if it's the first\ntime we're starting the camera.\n\n2. (This one depends on Naush's patch set) The number of frames to\ndrop is now returned by the IPA to the Camera::start method, not\nCamera::configure.\n\n3. The AGC algorithm acquires a GetDropFrames method which can be\ncalled before the camera starts to discover the number of frames the\nAGC wants us to drop.\n\n4. The code in IPARPi::start is amended to use the new\nAgc::GetDropFrames method.\n\n5. CamHelperOv5647 needs to request that we skip 2 frames at\nstartup. (It is inheriting the default value of zero otherwise, which\nis not correct for this sensor.)\n\nThanks very much!\n\nBest regards\nDavid\n\nDavid Plowman (5):\n src: ipa: raspberrypi: Distinguish the first camera start from others\n src: raspberrypi: Pass the drop frame count in start, not configure\n src: ipa: raspberrypi: agc: Add GetDropFrames method to AGC base class\n src: ipa: raspberrypi: Move initial frame drop decision to AGC\n src: ipa: raspberrypi: Drop the correct number of frames on startup\n for ov5647\n\n src/ipa/raspberrypi/cam_helper.cpp | 6 +--\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 10 ++++\n .../raspberrypi/controller/agc_algorithm.hpp | 1 +\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 11 ++++\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +\n src/ipa/raspberrypi/raspberrypi.cpp | 53 ++++++++++++-------\n .../pipeline/raspberrypi/raspberrypi.cpp | 25 ++++-----\n 7 files changed, 73 insertions(+), 35 deletions(-)" }