Cover Letter Detail
Show a cover letter.
GET /api/covers/10213/?format=api
{ "id": 10213, "url": "https://patchwork.libcamera.org/api/covers/10213/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10213/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201023102159.26274-1-david.plowman@raspberrypi.com>", "date": "2020-10-23T10:21:54", "name": "[libcamera-devel,v5,0/5] Digital zoom", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/10213/mbox/", "series": [ { "id": 1409, "url": "https://patchwork.libcamera.org/api/series/1409/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1409", "date": "2020-10-23T10:21:54", "name": "Digital zoom", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1409/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10213/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBF0BC3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Oct 2020 10:22:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C55561795;\n\tFri, 23 Oct 2020 12:22:05 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE7D861417\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 12:22:03 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id k21so801530wmi.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 03:22:03 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tr128sm2477831wma.20.2020.10.23.03.22.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 23 Oct 2020 03:22:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"WR5tJVY+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=o39mP0rfRnANJkpr9v7fOzyubAuMATIfjfZDwFvKM9Q=;\n\tb=WR5tJVY+hnWhIc1gcI0KeqB5HP2TTxn4z25BLAg4cTZ+MZOHx1bb18NPZOHR8spI6Q\n\tEtDvmGY6VzhStHwKHSV+YSYQAnQIbNPNyX0q8+EdZ+fwwxuzvsGalf1G62s82LUlm5GZ\n\tug9uGXXW6gy5lVyBFzHna7DMgKAUSEevNYLMU70HW9J7X29ykv0MTnzfNWeXMpsCU+SK\n\tr0Z0UGPFBaL2TdUJ0DDfmnT+w71ZuO0p/LjuXA3cUK9/3XrxmCe+5kmhWdJ6kAeqv0X9\n\t0DQqprCGRlRzfGXVByQvFqKGIn5y++fen3AmB7nQDHYceNldzMQCT0FG8gzEWJYj+KRD\n\te1RQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=o39mP0rfRnANJkpr9v7fOzyubAuMATIfjfZDwFvKM9Q=;\n\tb=Xt4MuIVESjRSLSIoUv104UN6/pJs2sWZPJ6qSJeKBdmCB6hVMH5ZgWFHsHBppp724v\n\tP0+cRGU5VBaCUA17AFdaWnTjgaR+EyMittewyV3GHTtufCMBJ8zKTWUwUX8kOA8LvJ0L\n\tc/rKfllhmB4UnuOH+E8lvf9f4Zrfne7+1ybK8hiVGRj47nsUAHmbSWirD9S8TEp3Rd+7\n\tCMJX/1A6/4N2QWkLgNwyY9BVJornmlpYXWgMveNt3EniLL2nPbDmf62L7gzKbrqUSjaG\n\tJ38LJkqFLtz6nYNNxudZ7Uv/F5Sd/9ppMAcMQXcAUcModo02KbE75KczdrNLoQeP1OyA\n\tqt0Q==", "X-Gm-Message-State": "AOAM533e61CRgicRcDysBu/+Zj3FAjA5mNt63PLAkT4w+AN+3w0V++13\n\twoY4FfJUAn0qL8YJv9Iu02Si7IvsPXN1jQ==", "X-Google-Smtp-Source": "ABdhPJzpsnjg6+UKpXgRdx86h1fVdaiJPcgsVhhmPYAT+RSTn+W7UMfwr0BABPj43KsQ9M3+aCR8fg==", "X-Received": "by 2002:a1c:dd05:: with SMTP id u5mr1658740wmg.56.1603448523322; \n\tFri, 23 Oct 2020 03:22:03 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Oct 2020 11:21:54 +0100", "Message-Id": "<20201023102159.26274-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 0/5] Digital zoom", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nThanks for the reviews and comments, latest version of digital zoom\npatches attached. I reordered the first couple because the ScalerCrop\ncontrol seems more fundamental now, so it seemed slightly better\nbefore the ScalerCropMaximum one. Don't think it matters much.\n\nThe main differences are:\n\n1 and 2. These are now the control then the property, as described.\n\n3. Initialisation of the ScalerCropMaximum property is now in the RPi\npipeline handler, and to zero values (isNull is our friend).\n\n4. Geometry helpers - a bit more renaming, as usual. I found I had to\nkeep some of the casts because widths and heights tend to be unsigned\nints (not just ints). There's a Rectangle::topLeft() function and you\nnow translate by a Point (I'll live with my discomfort on that one).\n\nThat Rectangle scaling function is now described as a \"non-uniform\nscaling\", I think that's something familiar to most people. I agree it\nwas confusing before (I'd described it by the way I used it, rather\nthan what it was), but I think a non-unifrom scaling is clearer than a\nhomothety (actually I had some difficulties with that too).\n\n5. RPi implementation. I fill in the ScalerCrop in the metadata\ndirectly now, when the metadata returns from the IPA (which just\nignores it).\n\nI thought I'd get this lot out there first. In the meantime I'll work\non some geometry tests and include them either in the next round or as\na separate patch.\n\nThanks and best regards\nDavid\n\nDavid Plowman (5):\n libcamera: Add ScalerCrop control\n libcamera: Add SensorCropMaximum property\n libcamera: raspberrypi: Initialise the SensorCropMaximum property\n libcamera: Add geometry helper functions\n libcamera: pipeline: raspberrypi: Implementation of digital zoom\n\n include/libcamera/geometry.h | 52 +++\n include/libcamera/ipa/raspberrypi.h | 1 +\n src/ipa/raspberrypi/raspberrypi.cpp | 5 +\n src/libcamera/control_ids.yaml | 13 +\n src/libcamera/geometry.cpp | 307 ++++++++++++++++++\n .../pipeline/raspberrypi/raspberrypi.cpp | 89 ++++-\n src/libcamera/property_ids.yaml | 14 +\n 7 files changed, 465 insertions(+), 16 deletions(-)" }