Cover Letter Detail
Show a cover letter.
GET /api/covers/10106/?format=api
{ "id": 10106, "url": "https://patchwork.libcamera.org/api/covers/10106/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10106/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020014005.12783-1-laurent.pinchart@ideasonboard.com>", "date": "2020-10-20T01:40:00", "name": "[libcamera-devel,v2,0/5] libcamera: Implement d-pointer design pattern", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/10106/mbox/", "series": [ { "id": 1386, "url": "https://patchwork.libcamera.org/api/series/1386/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1386", "date": "2020-10-20T01:40:00", "name": "libcamera: Implement d-pointer design pattern", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1386/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10106/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA466BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 01:40:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57944613B7;\n\tTue, 20 Oct 2020 03:40:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6176D6052F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 03:40:56 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4FF552\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 03:40:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mFPI4AfU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603158056;\n\tbh=smCbNspoOOgfleVtrlTMRcslC4GC+ZMf4FghHnqjtYs=;\n\th=From:To:Subject:Date:From;\n\tb=mFPI4AfUvE2Hpp/ULen/MGAeQ5ZtY2vi0JJKTcIbz5UUrf/Rqz+8WK9tritZh1xcT\n\tXPUDIjM8ADgCyHMPFSW+i5KNVD2dVUniF5EkQsteaqk88W/lA+VEYkB++GX+8aZniC\n\tiYU4TB/bZtobMfGM2GqXijWZXgvTpS5xpIwQegRo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 04:40:00 +0300", "Message-Id": "<20201020014005.12783-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 0/5] libcamera: Implement d-pointer\n\tdesign pattern", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series implements the d-pointer design pattern in a base\nclass, generalizing the custom implementations from the Camera and\nCameraManager classes. This was mostly developed as a base for the\nreprocessing API (the reworked camera configuration API will make use of\nd-pointers), but I believe it makes sense on its own.\n\nThe series is quite straightforward. Patch 1/5 is new compared to v1,\nand adds a formatter to checkstyle.py to ensure consistent naming of\nvariables related to this design pattern. This stems from patch 2/5,\nwhich implements the framework, not hiding variable declarations in the\nLIBCAMERA_D_PTR() and LIBCAMERA_O_PTR() macros anymore, as requested\nduring review of v1. I'm still not sure which option is best, feedback\nwill be appreciated.\n\nPatch 3/5 fixes an issue in the CameraManager class, and patches 4/5 and\n5/5 replace the manual implementations. Please see individual patches\nfor details.\n\nLaurent Pinchart (5):\n utils: checkstyle.py: Add d-pointer formatter\n libcamera: Add a base class to implement the d-pointer design pattern\n libcamera: camera_manager: Make CameraManager::Private::mutex_ mutable\n libcamera: camera_manager: Inherit from Extensible\n libcamera: camera: Inherit from Extensible\n\n include/libcamera/camera.h | 9 +-\n include/libcamera/camera_manager.h | 7 +-\n include/libcamera/extensible.h | 86 ++++++++++++++++++\n include/libcamera/meson.build | 1 +\n src/libcamera/camera.cpp | 123 +++++++++++++++-----------\n src/libcamera/camera_manager.cpp | 57 +++++++-----\n src/libcamera/extensible.cpp | 134 +++++++++++++++++++++++++++++\n src/libcamera/meson.build | 1 +\n utils/checkstyle.py | 32 +++++++\n 9 files changed, 373 insertions(+), 77 deletions(-)\n create mode 100644 include/libcamera/extensible.h\n create mode 100644 src/libcamera/extensible.cpp" }