Patch Detail
Show a patch.
GET /api/1.1/patches/9991/?format=api
{ "id": 9991, "url": "https://patchwork.libcamera.org/api/1.1/patches/9991/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9991/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201007092239.41704-3-tomi.valkeinen@iki.fi>", "date": "2020-10-07T09:22:38", "name": "[libcamera-devel,3/4] cam: fix use of uninitialized field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "296244372f45f0cb230825da430711c2dcae4f97", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/1.1/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9991/mbox/", "series": [ { "id": 1360, "url": "https://patchwork.libcamera.org/api/1.1/series/1360/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1360", "date": "2020-10-07T09:22:36", "name": "[libcamera-devel,1/4] cam: options: fix access to uninit variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1360/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9991/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9991/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45996BEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Oct 2020 09:23:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 131E463CC5;\n\tWed, 7 Oct 2020 11:23:30 +0200 (CEST)", "from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41BB663CDC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Oct 2020 11:23:26 +0200 (CEST)", "by mail-lf1-x131.google.com with SMTP id y11so1477119lfl.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Oct 2020 02:23:26 -0700 (PDT)", "from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tn26sm258341ljg.133.2020.10.07.02.23.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 02:23:23 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"cJF6sRpv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ASlDfRmcZux0WTHlF7DPWJ5JOUsvv/gtOF0gl+qrgJI=;\n\tb=cJF6sRpv7BaZglHd6wSngOi9ppQFlXOh9C0k1il12Im+PjXZXSpac2oP5Eki9AnvBv\n\tLqdz7FcPM1q61xv2HUtZEOmVB1bV6C/3Pd3b0RIKD+tJANtzMRGYoRO9GlKUpttL83g4\n\t46kgHM/XW2bsoBcwJhBlmz4n0iJFoEQsaiWXHa4s/yTiPC7c/R2q1TxhI1c/oIcrzCM0\n\tyATuH8tzR8XzpxbbJz8qT5rDH9tByZ+pM2zWVrvAiPhW2WjPYd7nuu5Hxvi+I0nfY3wD\n\tLsXvrslqmxepkTKUfQ52SVh4o22jI2vRUwLiqyQQGs7oGu/AJ1CIXXtzd2kUvCCXICXr\n\tKJng==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=ASlDfRmcZux0WTHlF7DPWJ5JOUsvv/gtOF0gl+qrgJI=;\n\tb=Xgx3/2hAXTDf8WOVQjg1TW0ABBS2nw/WF99nPyu9sHo9b2unSuB7L57PuvOCXDMtv5\n\tLKTwuufurJHeaxGKu0Mhtn1wYyt+WR71Y+KnsWpXvz5PUw27jjg1r54+OqJv4lRUwg+T\n\tsviNjZLuMfbKbQn3JQ3nG3iEstMWtI+q0pBndJoGZKDOhPpPtKRuG7Rcjumz1oCSPfjd\n\tcvpovN7JKYR/wqfeakaW3kulQfKcJ2sInK3tlHe4EShquulgjI3g7kZjOfcxh4Tm+Pc1\n\tOXbzPuZR6TcDscJuaqI9Gu+Pe8G7hIhlVRkhZLpzCZcse/mCSicIV4lbXo6ZupF1lsBI\n\tndbg==", "X-Gm-Message-State": "AOAM53028tCnKI+blrL+JoolOTyfCjULjeNg49fxM9ahM3GrmgX2fZmg\n\tAwBHQ6Cfj4dZenf89jb9t+F5mbypu4is7g==", "X-Google-Smtp-Source": "ABdhPJxG8UCejirYznb2qNBS6RMx58yyMihVKuJ8pqs5yg2OaWY0xQ0K6wpITNOAriFZKpEmAt7OFg==", "X-Received": "by 2002:a19:8c52:: with SMTP id i18mr641842lfj.115.1602062604484;\n\tWed, 07 Oct 2020 02:23:24 -0700 (PDT)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Oct 2020 12:22:38 +0300", "Message-Id": "<20201007092239.41704-3-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007092239.41704-1-tomi.valkeinen@iki.fi>", "References": "<20201007092239.41704-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/4] cam: fix use of uninitialized field", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialize last_ to 0 to avoid uninitialized use.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n src/cam/capture.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\nindex 5510c00..995614a 100644\n--- a/src/cam/capture.cpp\n+++ b/src/cam/capture.cpp\n@@ -17,7 +17,7 @@ using namespace libcamera;\n \n Capture::Capture(std::shared_ptr<Camera> camera, CameraConfiguration *config,\n \t\t EventLoop *loop)\n-\t: camera_(camera), config_(config), writer_(nullptr), loop_(loop),\n+\t: camera_(camera), config_(config), writer_(nullptr), last_(0), loop_(loop),\n \t captureCount_(0), captureLimit_(0)\n {\n }\n", "prefixes": [ "libcamera-devel", "3/4" ] }