Patch Detail
Show a patch.
GET /api/1.1/patches/9990/?format=api
{ "id": 9990, "url": "https://patchwork.libcamera.org/api/1.1/patches/9990/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9990/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201007092239.41704-4-tomi.valkeinen@iki.fi>", "date": "2020-10-07T09:22:39", "name": "[libcamera-devel,4/4] vimc: fix close(-1)", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53095a4030a911e96eaee9759f6b934b0fa77a8c", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/1.1/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9990/mbox/", "series": [ { "id": 1360, "url": "https://patchwork.libcamera.org/api/1.1/series/1360/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1360", "date": "2020-10-07T09:22:36", "name": "[libcamera-devel,1/4] cam: options: fix access to uninit variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1360/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9990/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9990/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BFDDBEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Oct 2020 09:23:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE56063CE5;\n\tWed, 7 Oct 2020 11:23:26 +0200 (CEST)", "from mail-lj1-x232.google.com (mail-lj1-x232.google.com\n\t[IPv6:2a00:1450:4864:20::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2B9163CDC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Oct 2020 11:23:25 +0200 (CEST)", "by mail-lj1-x232.google.com with SMTP id 133so1270524ljj.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Oct 2020 02:23:25 -0700 (PDT)", "from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tn26sm258341ljg.133.2020.10.07.02.23.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 02:23:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"J3fyom/a\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=6tdlQlbPp1GAElnJIvX3oIIAHk6QbyrOu0AkYBVPwpA=;\n\tb=J3fyom/abb6YotmXW/C1M5IKrQXjZynckhcREoql6UhOmUsBuUCsUDpPrT5iixiR/o\n\t4jIQ+HgpNWCRPty8I84l9otF7Le0KsClx9LLVtSKilICAPSZyBuzuuQqAJmSNbMMVIGn\n\ty5M3dnxOp2IoWDqUb3wr7bM2VXkb5+magibL98XLdEjslq3rNt1ZJVZoLXmp+j7eahb2\n\tR6cMY18AsuzA3+cBvsvduc652qej2ncuaHyLyqP46hJBL0+NMQ5gUGiOkdkU3ecAQnWA\n\tMZ9PrdtrMa2aq0JggfK9l+/LpBzd6atwnN2OsxY19jM2PAoEjFLZLEsQAyPg2Qafz7c+\n\tIVeg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=6tdlQlbPp1GAElnJIvX3oIIAHk6QbyrOu0AkYBVPwpA=;\n\tb=Hb5B/FmGaeVYINAw5s84p9SX1w6a5u7EMbVDlqK66c5Z7YSX+zXE2ONOsaaAVbuQO/\n\tmpPsF0kNfnldoMX8rkNqqAfW3mr+5bVtJeO2gPrdqCaU5WwflGEzXTB9uQPgqitTxGWv\n\twk6VJlLEh6VK2L21YCO/30GXXX0FIEJ+0BoazBP2JO9fgAgrXrFUQ3P2FVN257P0wfaw\n\tT5mjAzFgL6Q0tuveVcxBT7ASTWmOHSv6qBXTF4XoaNxrrj1DT1ew85HRVgWatUaMG8Hm\n\ttL9lZOr8wcyY6Jzj+mmgXVU6GEb1Sek0C5Ld9DPUTUG1Iv0kjwExAhZFwnzq7pvtEzP/\n\t9Orw==", "X-Gm-Message-State": "AOAM532RiyMRUrL9RpqiGfVJdRE5aTo2iJ96n7AyKPBt1JqZV2mLXtjl\n\t+raUMeKbTyMEf9UN1Cs09fifb8zczAHboQ==", "X-Google-Smtp-Source": "ABdhPJwCV4arsLR9cOXdDGI9i2UKV60JwDoGgPqljpgfDyHBpiK3KkOmTf62ZtsiagM+/9tySX935w==", "X-Received": "by 2002:a2e:e1a:: with SMTP id 26mr776249ljo.377.1602062605254; \n\tWed, 07 Oct 2020 02:23:25 -0700 (PDT)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Oct 2020 12:22:39 +0300", "Message-Id": "<20201007092239.41704-4-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007092239.41704-1-tomi.valkeinen@iki.fi>", "References": "<20201007092239.41704-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/4] vimc: fix close(-1)", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "~IPAVimc() checks if fd != 0, but it should check if fd != -1.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n src/ipa/vimc/vimc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex ef25776..372a15f 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -61,7 +61,7 @@ IPAVimc::IPAVimc()\n \n IPAVimc::~IPAVimc()\n {\n-\tif (fd_)\n+\tif (fd_ != -1)\n \t\t::close(fd_);\n }\n \n", "prefixes": [ "libcamera-devel", "4/4" ] }