Patch Detail
Show a patch.
GET /api/1.1/patches/9925/?format=api
{ "id": 9925, "url": "https://patchwork.libcamera.org/api/1.1/patches/9925/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9925/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201002143154.468162-18-paul.elder@ideasonboard.com>", "date": "2020-10-02T14:31:33", "name": "[libcamera-devel,v3,17/38] libcamera: IPAProxy: Remove stop() override", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9048e78e3804a130af1623ccc0fbbfa8c2b84715", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9925/mbox/", "series": [ { "id": 1348, "url": "https://patchwork.libcamera.org/api/1.1/series/1348/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1348", "date": "2020-10-02T14:31:16", "name": "IPA isolation implementation", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1348/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9925/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9925/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88258C3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Oct 2020 14:32:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56A7963BBF;\n\tFri, 2 Oct 2020 16:32:49 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5169863B6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Oct 2020 16:32:48 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DFCD528;\n\tFri, 2 Oct 2020 16:32:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dm4bDJ0/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601649168;\n\tbh=aCVjjgWCMqyAScCKuuTgqVyFMyRyBU9lWtsQqDJc9u0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dm4bDJ0/Acl4c6sKl+u8+fPeUxI8dvhVvmeLz08crRpomNs0yEqKrhpgpo4vN3Q79\n\tKG68pMkprjhV9T0F983LeqBm7/dQJ1sEHpVbbS+7QD/4kRE9cnqGE/pLSEeWD4UNdA\n\tu3X6/mVPCoAhNDIJjlRRrmAKKnkwOVavAXX+OyLU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Oct 2020 23:31:33 +0900", "Message-Id": "<20201002143154.468162-18-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201002143154.468162-1-paul.elder@ideasonboard.com>", "References": "<20201002143154.468162-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 17/38] libcamera: IPAProxy: Remove\n\tstop() override", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since stop() is part of the IPA interface, and the IPA interface is now\ngenerated based on the data definition file per pipeline, this no longer\nneeds to be overrided by the base IPAProxy. Remove it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n---\nNo change in v3\n\nChanges in v2:\n- remove documentation\n---\n include/libcamera/internal/ipa_proxy.h | 2 --\n src/libcamera/ipa_proxy.cpp | 10 ----------\n 2 files changed, 12 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex b429ce5a..aec8f04f 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -27,8 +27,6 @@ public:\n \n \tstd::string configurationFile(const std::string &file) const;\n \n-\tvoid stop() override = 0;\n-\n protected:\n \tstd::string resolvePath(const std::string &file) const;\n \ndiff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex ff4d7fd1..23be24ad 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -145,16 +145,6 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n \treturn std::string();\n }\n \n-/**\n- * \\fn IPAProxy::stop()\n- * \\brief Stop the IPA proxy\n- *\n- * This function stops the IPA and releases all the resources acquired by the\n- * proxy in start(). Calling stop() when the IPA proxy hasn't been started or\n- * has already been stopped is valid, the proxy shall treat this as a no-op and\n- * shall not forward the call to the IPA.\n- */\n-\n /**\n * \\brief Find a valid full path for a proxy worker for a given executable name\n * \\param[in] file File name of proxy worker executable\n", "prefixes": [ "libcamera-devel", "v3", "17/38" ] }