Patch Detail
Show a patch.
GET /api/1.1/patches/9894/?format=api
{ "id": 9894, "url": "https://patchwork.libcamera.org/api/1.1/patches/9894/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9894/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201001154600.2722718-6-niklas.soderlund@ragnatech.se>", "date": "2020-10-01T15:45:59", "name": "[libcamera-devel,v2,5/6] libcamera: Add support for XRGB8888 and XBGR8888", "commit_ref": "4fd6bb33202a83017bc32625561273fd3a888d9b", "pull_url": null, "state": "accepted", "archived": false, "hash": "f4bb239e5b3f3c018305c7f03665db1e80b7a7cc", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9894/mbox/", "series": [ { "id": 1342, "url": "https://patchwork.libcamera.org/api/1.1/series/1342/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1342", "date": "2020-10-01T15:45:54", "name": "libcamera: pipeline: rkisp1: Refresh to match upstream", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1342/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9894/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9894/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95A6BC3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 1 Oct 2020 15:46:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71125622F2;\n\tThu, 1 Oct 2020 17:46:19 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B101E622EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 1 Oct 2020 17:46:16 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 3cba82f6-03fd-11eb-9823-005056917f90;\n\tThu, 01 Oct 2020 17:46:14 +0200 (CEST)" ], "X-Halon-ID": "3cba82f6-03fd-11eb-9823-005056917f90", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 1 Oct 2020 17:45:59 +0200", "Message-Id": "<20201001154600.2722718-6-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>", "References": "<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for XRGB8888 and XBGR8888 formats.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n* Changes since v1\n- Fix type in v4l2_pixelformat.cpp where V4L2_PIX_FMT_XBGR32 was added\n twice instead of adding V4L2_PIX_FMT_XBGR32 and V4L2_PIX_FMT_XRGB32.\n---\n src/libcamera/formats.cpp | 20 ++++++++++++++++++++\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex ebaae9be3d75fe58..cc6e579005b2d4b6 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -175,6 +175,26 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::XRGB8888, {\n+\t\t.name = \"XRGB8888\",\n+\t\t.format = formats::XRGB8888,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XBGR32),\n+\t\t.bitsPerPixel = 32,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::XBGR8888, {\n+\t\t.name = \"XBGR8888\",\n+\t\t.format = formats::XBGR8888,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n+\t\t.bitsPerPixel = 32,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::ABGR8888, {\n \t\t.name = \"ABGR8888\",\n \t\t.format = formats::ABGR8888,\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 30c94bb98f442b08..6b05909f56ae975b 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -48,6 +48,8 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n", "prefixes": [ "libcamera-devel", "v2", "5/6" ] }