Patch Detail
Show a patch.
GET /api/1.1/patches/9857/?format=api
{ "id": 9857, "url": "https://patchwork.libcamera.org/api/1.1/patches/9857/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9857/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200929144648.429397-3-niklas.soderlund@ragnatech.se>", "date": "2020-09-29T14:46:43", "name": "[libcamera-devel,v6,2/7] libcamera: utils: Add method to remove non-ASCII characters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "db2acdced173b2044edaa04a2100cb2f8c60d1a7", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9857/mbox/", "series": [ { "id": 1336, "url": "https://patchwork.libcamera.org/api/1.1/series/1336/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1336", "date": "2020-09-29T14:46:41", "name": "libcamera: Allow for user-friendly names in", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1336/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9857/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9857/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E00FC3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Sep 2020 14:47:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58E76621C9;\n\tTue, 29 Sep 2020 16:47:03 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD73B60365\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Sep 2020 16:47:01 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 9f344298-0262-11eb-9823-005056917f90;\n\tTue, 29 Sep 2020 16:46:59 +0200 (CEST)" ], "X-Halon-ID": "9f344298-0262-11eb-9823-005056917f90", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Sep 2020 16:46:43 +0200", "Message-Id": "<20200929144648.429397-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200929144648.429397-1-niklas.soderlund@ragnatech.se>", "References": "<20200929144648.429397-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 2/7] libcamera: utils: Add method to\n\tremove non-ASCII characters", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add method that removes non-ASCII characters from a string.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Umang Jain <email@uajain.com>\n---\n* Changes since v5\n- Update documentation.\n\n* Changes since v4\n- Update documentation.\n\n* Changes since v3\n- Fix spelling in comment.\n- Rename to toAscii()\n---\n include/libcamera/internal/utils.h | 2 ++\n src/libcamera/utils.cpp | 17 +++++++++++++++++\n 2 files changed, 19 insertions(+)", "diff": "diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\nindex a1b644b0345bdb48..ebb2c4038e196f05 100644\n--- a/include/libcamera/internal/utils.h\n+++ b/include/libcamera/internal/utils.h\n@@ -190,6 +190,8 @@ private:\n \n details::StringSplitter split(const std::string &str, const std::string &delim);\n \n+std::string toAscii(const std::string &str);\n+\n std::string libcameraBuildPath();\n std::string libcameraSourcePath();\n \ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex a5232902191eec85..da85c9c24340ae3b 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -334,6 +334,23 @@ details::StringSplitter split(const std::string &str, const std::string &delim)\n \treturn details::StringSplitter(str, delim);\n }\n \n+/**\n+ * \\brief Remove any non-ASCII characters from a string\n+ * \\param[in] str The string to strip\n+ *\n+ * Remove all non-ASCII characters from a string.\n+ *\n+ * \\return A string equal to \\a str stripped out of all non-ASCII characters\n+ */\n+std::string toAscii(const std::string &str)\n+{\n+\tstd::string ret;\n+\tfor (const char &c : str)\n+\t\tif (!(c & 0x80))\n+\t\t\tret += c;\n+\treturn ret;\n+}\n+\n /**\n * \\brief Check if libcamera is installed or not\n *\n", "prefixes": [ "libcamera-devel", "v6", "2/7" ] }