Patch Detail
Show a patch.
GET /api/1.1/patches/985/?format=api
{ "id": 985, "url": "https://patchwork.libcamera.org/api/1.1/patches/985/?format=api", "web_url": "https://patchwork.libcamera.org/patch/985/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190415165700.22970-5-laurent.pinchart@ideasonboard.com>", "date": "2019-04-15T16:56:53", "name": "[libcamera-devel,04/11] libcamera: geometry: Sort classes alphabetically", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fb367c7c8139ebf2b5628e8ebb39fe26b844f7c6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/985/mbox/", "series": [ { "id": 250, "url": "https://patchwork.libcamera.org/api/1.1/series/250/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=250", "date": "2019-04-15T16:56:49", "name": "Rockchip ISP pipeline handler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/250/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/985/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/985/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9339160DC5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Apr 2019 18:57:15 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2948A333\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Apr 2019 18:57:15 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555347435;\n\tbh=QLmAgOOBJVx6S+WNAS8PF9P2lAPAMIUz9033cnxeVd0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YAjLhx/K3okfXgGxcU1GXp0sNZNPun5Cnx16anoi/NkW62acr62Dy754k6KOCiECi\n\teC/aFdFrYCvSttHeLfYOGNnuW2rVlKK6DsgvgPCQk7PuHUPRYfsKMxbaCWAx8Nqbai\n\tiBV1gMr0c8kKlg1ycwO+JlRMG7SR1I+Z5eBlbt3I=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 15 Apr 2019 19:56:53 +0300", "Message-Id": "<20190415165700.22970-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190415165700.22970-1-laurent.pinchart@ideasonboard.com>", "References": "<20190415165700.22970-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/11] libcamera: geometry: Sort classes\n\talphabetically", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 15 Apr 2019 16:57:17 -0000" }, "content": "Move the Size class before the SizeRange class. No functional change.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/geometry.h | 30 +++++++++----------\n src/libcamera/geometry.cpp | 58 ++++++++++++++++++------------------\n 2 files changed, 44 insertions(+), 44 deletions(-)", "diff": "diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex f41017aa47bf..7704ab5add21 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -21,6 +21,21 @@ struct Rectangle {\n \tconst std::string toString() const;\n };\n \n+struct Size {\n+\tSize()\n+\t\t: Size(0, 0)\n+\t{\n+\t}\n+\n+\tSize(unsigned int w, unsigned int h)\n+\t\t: width(w), height(h)\n+\t{\n+\t}\n+\n+\tunsigned int width;\n+\tunsigned int height;\n+};\n+\n struct SizeRange {\n \tSizeRange()\n \t\t: SizeRange(0, 0, 0, 0)\n@@ -40,21 +55,6 @@ struct SizeRange {\n \tunsigned int maxHeight;\n };\n \n-struct Size {\n-\tSize()\n-\t\t: Size(0, 0)\n-\t{\n-\t}\n-\n-\tSize(unsigned int w, unsigned int h)\n-\t\t: width(w), height(h)\n-\t{\n-\t}\n-\n-\tunsigned int width;\n-\tunsigned int height;\n-};\n-\n } /* namespace libcamera */\n \n #endif /* __LIBCAMERA_GEOMETRY_H__ */\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex d63eceaf827b..1f875bbe5f48 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -62,6 +62,35 @@ const std::string Rectangle::toString() const\n \treturn ss.str();\n }\n \n+/**\n+ * \\struct Size\n+ * \\brief Describe a two-dimensional size\n+ *\n+ * The Size structure defines a two-dimensional size with integer precision.\n+ */\n+\n+/**\n+ * \\fn Size::Size()\n+ * \\brief Construct a Size with width and height set to 0\n+ */\n+\n+/**\n+ * \\fn Size::Size(unsigned int width, unsigned int height)\n+ * \\brief Construct a Size with given \\a width and \\a height\n+ * \\param width The Size width\n+ * \\param height The Size height\n+ */\n+\n+/**\n+ * \\var Size::width\n+ * \\brief The Size width\n+ */\n+\n+/**\n+ * \\var Size::height\n+ * \\brief The Size height\n+ */\n+\n /**\n * \\struct SizeRange\n * \\brief Describe a range of image sizes\n@@ -105,33 +134,4 @@ const std::string Rectangle::toString() const\n * \\brief The maximum image height\n */\n \n-/**\n- * \\struct Size\n- * \\brief Describe a two-dimensional size\n- *\n- * The Size structure defines a two-dimensional size with integer precision.\n- */\n-\n-/**\n- * \\fn Size::Size()\n- * \\brief Construct a Size with width and height set to 0\n- */\n-\n-/**\n- * \\fn Size::Size(unsigned int width, unsigned int height)\n- * \\brief Construct a Size with given \\a width and \\a height\n- * \\param width The Size width\n- * \\param height The Size height\n- */\n-\n-/**\n- * \\var Size::width\n- * \\brief The Size width\n- */\n-\n-/**\n- * \\var Size::height\n- * \\brief The Size height\n- */\n-\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "04/11" ] }