Patch Detail
Show a patch.
GET /api/1.1/patches/9844/?format=api
{ "id": 9844, "url": "https://patchwork.libcamera.org/api/1.1/patches/9844/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9844/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200929011850.13997-1-laurent.pinchart@ideasonboard.com>", "date": "2020-09-29T01:18:50", "name": "[libcamera-devel] libcamera: span: Use default copy assignemnt operator", "commit_ref": "dcf2a8ce1026d13b16d5cba065dec5c9bb78a0a1", "pull_url": null, "state": "accepted", "archived": false, "hash": "e36eac29f2d09d1eb1c8fb629f62a8379b3fdc8c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9844/mbox/", "series": [ { "id": 1332, "url": "https://patchwork.libcamera.org/api/1.1/series/1332/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1332", "date": "2020-09-29T01:18:50", "name": "[libcamera-devel] libcamera: span: Use default copy assignemnt operator", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1332/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9844/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9844/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8526C3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Sep 2020 01:19:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DA34620BC;\n\tTue, 29 Sep 2020 03:19:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F97660365\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Sep 2020 03:19:30 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B2768540\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Sep 2020 03:19:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xm2VWAma\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601342369;\n\tbh=Bki8vlpLhLhZ6Ps/34YQ/qfb6XOSkt9HIpNgMnGST4o=;\n\th=From:To:Subject:Date:From;\n\tb=Xm2VWAma5p0xZYtscnBHABc0VvCSn1LgYNTTvoyJYh26XQNsCQFYD6BQCkkRcScAR\n\t9kh3ijYZ3DaxkGUmLY1p8d37ix04ZU8wOmfj4an2Kzqes6Fa+uABcVMEah3fEzOMR0\n\tP+6j3soUU9I/I3nRDw6D+lhm96dX76LPluMU8rI4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Sep 2020 04:18:50 +0300", "Message-Id": "<20200929011850.13997-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: span: Use default copy\n\tassignemnt operator", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The custom implementation of the copy assignment operator is identical\nto the one the compiler would generate. Replace it by the default.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/span.h | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex 738af6aca871..a53a80b81640 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -188,12 +188,7 @@ public:\n \t}\n \n \tconstexpr Span(const Span &other) noexcept = default;\n-\n-\tconstexpr Span &operator=(const Span &other) noexcept\n-\t{\n-\t\tdata_ = other.data_;\n-\t\treturn *this;\n-\t}\n+\tconstexpr Span &operator=(const Span &other) noexcept = default;\n \n \tconstexpr iterator begin() const { return data(); }\n \tconstexpr const_iterator cbegin() const { return begin(); }\n", "prefixes": [ "libcamera-devel" ] }