Patch Detail
Show a patch.
GET /api/1.1/patches/9794/?format=api
{ "id": 9794, "url": "https://patchwork.libcamera.org/api/1.1/patches/9794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200924145143.117733-4-jacopo@jmondi.org>", "date": "2020-09-24T14:51:43", "name": "[libcamera-devel,3/3] libcamera: ipu3: Adjust comment on ImgU configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8ca7fb4a7855f2e8abf513d70e85899385ed8a53", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9794/mbox/", "series": [ { "id": 1323, "url": "https://patchwork.libcamera.org/api/1.1/series/1323/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1323", "date": "2020-09-24T14:51:40", "name": "libcamera: ipu3: Fix RAW+YUV capture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1323/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BAB4C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Sep 2020 14:47:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D61B66300D;\n\tThu, 24 Sep 2020 16:47:58 +0200 (CEST)", "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 414F560363\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Sep 2020 16:47:57 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id DA967240010;\n\tThu, 24 Sep 2020 14:47:56 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Sep 2020 16:51:43 +0200", "Message-Id": "<20200924145143.117733-4-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200924145143.117733-1-jacopo@jmondi.org>", "References": "<20200924145143.117733-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: ipu3: Adjust comment on\n\tImgU configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Be more precise in commenting why the ImgU shall not be configured\nif only the RAW stream is requested.\n\nAs an example, if the ImgU gets unecessary configured:\ncam -srole=viewfinder -c2 -C -> WORKS\ncam -srole=stillraw -c2 -C -> WORKS\ncam -srole=viewfinder -c2 -C -> Failed to queue buffer 0: Invalid argument\n\nSince commit 1bd2e981a209 (\"libcamera: ipu3: Fix RAW+YUV capture\")\nthe ImgU configuration procedure also correctly implements the\nassumption that at least one of the YUV output is being operated. If\nthat's not the case, as in the RAW-only capture use case, the code\ntries to access a non-existing configuration. One more reason to\nexit early if no YUV stream is requested.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 477f85a45755..2f90ad2e2780 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -459,9 +459,9 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \n \t/*\n-\t * If the ImgU gets configured with proper IF, BDS and GDC sizes, it\n-\t * is then expected that frames are dequeued from its main output\n-\t * otherwise the system stalls.\n+\t * If the ImgU gets configured it is then expected that buffers are\n+\t * queued to its outputs, otherwise the next capture session\n+\t * that uses the ImgU fails at queueing buffers at its input.\n \t *\n \t * If no ImgU configuration has been computed, it means only a RAW\n \t * stream has been requested: return here to skip the ImgU configuration\n", "prefixes": [ "libcamera-devel", "3/3" ] }