Patch Detail
Show a patch.
GET /api/1.1/patches/9762/?format=api
{ "id": 9762, "url": "https://patchwork.libcamera.org/api/1.1/patches/9762/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9762/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200923164412.319079-2-kieran.bingham@ideasonboard.com>", "date": "2020-09-23T16:44:09", "name": "[libcamera-devel,1/4] simple-cam: Use the new BufferMap interface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "edce0c9604246489dc2c1940c7b792e3314acdf3", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/9762/mbox/", "series": [ { "id": 1314, "url": "https://patchwork.libcamera.org/api/1.1/series/1314/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1314", "date": "2020-09-23T16:44:08", "name": "simple-cam: Update to latest API usage", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1314/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9762/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9762/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C901C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Sep 2020 16:44:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4396762FEC;\n\tWed, 23 Sep 2020 18:44:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F7D260576\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Sep 2020 18:44:17 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1A0B9CE;\n\tWed, 23 Sep 2020 18:44:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iXBpOdqj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600879456;\n\tbh=TpUIUoyashbCHjlPkpSkw+WM8CONmgNXCMsFjxEzyPE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iXBpOdqjpnLG33G0I5otK7VGfeXD7dDoEGbhuMjpBeUL1S5N6bt4CFyw9YneBwFPF\n\tQZbn+sGtJmZf+luFKSjqElgzuHTGeilm4qTwS2MBUcIkY0kUr/DCX8Y0rtTtQWekm4\n\t68SHCVYGAFbqtKXBHKsFTSC387Q3EBD0bHhe5GGc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 23 Sep 2020 17:44:09 +0100", "Message-Id": "<20200923164412.319079-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200923164412.319079-1-kieran.bingham@ideasonboard.com>", "References": "<20200923164412.319079-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/4] simple-cam: Use the new BufferMap\n\tinterface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Erkan Diken <erkandiken@gmail.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Request object has been updated to specify a BufferMap type.\n\nUtilise it.\n\nReported-by: Erkan Diken <erkandiken@gmail.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n simple-cam.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 56aed7564dad..e2ac122546ce 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -28,7 +28,7 @@ static void requestComplete(Request *request)\n \tif (request->status() == Request::RequestCancelled)\n \t\treturn;\n \n-\tconst std::map<Stream *, FrameBuffer *> &buffers = request->buffers();\n+\tconst Request::BufferMap &buffers = request->buffers();\n \n \tfor (auto bufferPair : buffers) {\n \t\t// (Unused) Stream *stream = bufferPair.first;\n", "prefixes": [ "libcamera-devel", "1/4" ] }