Patch Detail
Show a patch.
GET /api/1.1/patches/9728/?format=api
{ "id": 9728, "url": "https://patchwork.libcamera.org/api/1.1/patches/9728/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9728/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200922133537.258098-25-paul.elder@ideasonboard.com>", "date": "2020-09-22T13:35:23", "name": "[libcamera-devel,24/38] libcamera: IPAManager: Fetch IPAProxy corresponding to pipeline", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1fd9b3792b7a4a298c413075a32da0bd34e4f93e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9728/mbox/", "series": [ { "id": 1309, "url": "https://patchwork.libcamera.org/api/1.1/series/1309/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1309", "date": "2020-09-22T13:34:59", "name": "IPA isolation implementation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1309/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9728/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9728/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CEA7BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Sep 2020 13:38:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29BCA62FDA;\n\tTue, 22 Sep 2020 15:38:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D5D860576\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Sep 2020 15:38:42 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D2E02D7;\n\tTue, 22 Sep 2020 15:38:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KEMrOag1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600781917;\n\tbh=Py86KuCdyMrKIeHItPAS7QeAgnHgk6xZkBTl8a1e3zI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KEMrOag1n1UkZJFRn44QaFKI8pvRqjH4/EPSC8sM6OZhViM394P1cWA57VSILbgJI\n\tW65t5AQoWypikqJNoaDxRtNJDMtsz8CKJaA8CtrU8laJSsxZ8Gbxn//yNclPWyLm33\n\tDRjFk5CU/YmaJsat1JnsZSw9h7arKInoSEFr7jfE=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 22 Sep 2020 22:35:23 +0900", "Message-Id": "<20200922133537.258098-25-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200922133537.258098-1-paul.elder@ideasonboard.com>", "References": "<20200922133537.258098-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 24/38] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that each pipeline handler has its own IPAProxy implementation, make\nthe IPAManager fetch the IPAProxy based on the pipeline handler name.\nAlso, since the IPAProxy is used regardless of isolation or no\nisolation, remove the isolation check from the proxy selection.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNo change in v2\n---\n src/libcamera/ipa_manager.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 046fd5c6..2d0ea242 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -275,8 +275,8 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,\n \t *\n \t * \\todo Implement a better proxy selection\n \t */\n-\tconst char *proxyName = self_->isSignatureValid(m)\n-\t\t\t ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n+\tstd::string pipeName(pipe->name());\n+\tconst char *proxyName = pipeName.replace(0, 15, \"IPAProxy\").c_str();\n \tIPAProxyFactory *pf = nullptr;\n \n \tfor (IPAProxyFactory *factory : IPAProxyFactory::factories()) {\n", "prefixes": [ "libcamera-devel", "24/38" ] }