Patch Detail
Show a patch.
GET /api/1.1/patches/9721/?format=api
{ "id": 9721, "url": "https://patchwork.libcamera.org/api/1.1/patches/9721/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9721/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200922133537.258098-18-paul.elder@ideasonboard.com>", "date": "2020-09-22T13:35:16", "name": "[libcamera-devel,17/38] libcamera: ipa_context_wrapper: Remove ipa_context_wrapper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d742ca71ae393ab304e588cec9203a0cda6e33b2", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9721/mbox/", "series": [ { "id": 1309, "url": "https://patchwork.libcamera.org/api/1.1/series/1309/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1309", "date": "2020-09-22T13:34:59", "name": "IPA isolation implementation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1309/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9721/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9721/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32BFBBF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Sep 2020 13:37:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F10B562FDA;\n\tTue, 22 Sep 2020 15:37:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D3FC60576\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Sep 2020 15:37:54 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B40E813;\n\tTue, 22 Sep 2020 15:37:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nWVkaOMe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600781873;\n\tbh=i7afhswQp/8sQKABZL3Zg9ekcdlftJCFBqAOA+sicFU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nWVkaOMe0+4zvG5Eb2iQZ4AjRIykAxOr8/9M4FqRVKpp2whGjAUMATzael1XxnRLh\n\tz4Wgl82ZGuBIhlujEuyPet9ha/7lUSo4v4+YWVPAiPDk2Bies45ktFppvXVrqTFJex\n\tMyid3YZ7QSj0nsiV3NAvsqYaPjmJt5JSoMPMEf88=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 22 Sep 2020 22:35:16 +0900", "Message-Id": "<20200922133537.258098-18-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200922133537.258098-1-paul.elder@ideasonboard.com>", "References": "<20200922133537.258098-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 17/38] libcamera: ipa_context_wrapper:\n\tRemove ipa_context_wrapper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since ipa_context has been replaced with custom IPAInterfaces, it is not\nlonger needed. Remove it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v2\n---\n .../libcamera/internal/ipa_context_wrapper.h | 52 ---\n include/libcamera/internal/meson.build | 1 -\n include/libcamera/ipa/ipa_interface.h | 106 -------\n src/libcamera/ipa_context_wrapper.cpp | 297 ------------------\n 4 files changed, 456 deletions(-)\n delete mode 100644 include/libcamera/internal/ipa_context_wrapper.h\n delete mode 100644 src/libcamera/ipa_context_wrapper.cpp", "diff": "diff --git a/include/libcamera/internal/ipa_context_wrapper.h b/include/libcamera/internal/ipa_context_wrapper.h\ndeleted file mode 100644\nindex 8f767e84..00000000\n--- a/include/libcamera/internal/ipa_context_wrapper.h\n+++ /dev/null\n@@ -1,52 +0,0 @@\n-/* SPDX-License-Identifier: LGPL-2.1-or-later */\n-/*\n- * Copyright (C) 2019, Google Inc.\n- *\n- * ipa_context_wrapper.h - Image Processing Algorithm context wrapper\n- */\n-#ifndef __LIBCAMERA_INTERNAL_IPA_CONTEXT_WRAPPER_H__\n-#define __LIBCAMERA_INTERNAL_IPA_CONTEXT_WRAPPER_H__\n-\n-#include <libcamera/ipa/ipa_interface.h>\n-\n-#include \"libcamera/internal/control_serializer.h\"\n-\n-namespace libcamera {\n-\n-class IPAContextWrapper final : public IPAInterface\n-{\n-public:\n-\tIPAContextWrapper(struct ipa_context *context);\n-\t~IPAContextWrapper();\n-\n-\tint init(const IPASettings &settings) override;\n-\tint start() override;\n-\tvoid stop() override;\n-\tvoid configure(const CameraSensorInfo &sensorInfo,\n-\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t const IPAOperationData &ipaConfig,\n-\t\t IPAOperationData *result) override;\n-\n-\tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n-\tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n-\n-\tvirtual void processEvent(const IPAOperationData &data) override;\n-\n-private:\n-\tstatic void queue_frame_action(void *ctx, unsigned int frame,\n-\t\t\t\t struct ipa_operation_data &data);\n-\tstatic const struct ipa_callback_ops callbacks_;\n-\n-\tvoid doQueueFrameAction(unsigned int frame,\n-\t\t\t\tconst IPAOperationData &data);\n-\n-\tstruct ipa_context *ctx_;\n-\tIPAInterface *intf_;\n-\n-\tControlSerializer serializer_;\n-};\n-\n-} /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_INTERNAL_IPA_CONTEXT_WRAPPER_H__ */\ndiff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 15010338..8dd744fd 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -12,7 +12,6 @@ libcamera_internal_headers = files([\n 'event_dispatcher_poll.h',\n 'file.h',\n 'formats.h',\n- 'ipa_context_wrapper.h',\n 'ipa_manager.h',\n 'ipa_module.h',\n 'ipa_proxy.h',\ndiff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 5016ec25..38334ab9 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -10,111 +10,6 @@\n #include <stddef.h>\n #include <stdint.h>\n \n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n-\n-struct ipa_context {\n-\tconst struct ipa_context_ops *ops;\n-};\n-\n-struct ipa_settings {\n-\tconst char *configuration_file;\n-};\n-\n-struct ipa_sensor_info {\n-\tconst char *model;\n-\tuint8_t bits_per_pixel;\n-\tstruct {\n-\t\tuint32_t width;\n-\t\tuint32_t height;\n-\t} active_area;\n-\tstruct {\n-\t\tint32_t left;\n-\t\tint32_t top;\n-\t\tuint32_t width;\n-\t\tuint32_t height;\n-\t} analog_crop;\n-\tstruct {\n-\t\tuint32_t width;\n-\t\tuint32_t height;\n-\t} output_size;\n-\tuint64_t pixel_rate;\n-\tuint32_t line_length;\n-};\n-\n-struct ipa_stream {\n-\tunsigned int id;\n-\tunsigned int pixel_format;\n-\tunsigned int width;\n-\tunsigned int height;\n-};\n-\n-struct ipa_control_info_map {\n-\tunsigned int id;\n-\tconst uint8_t *data;\n-\tsize_t size;\n-};\n-\n-struct ipa_buffer_plane {\n-\tint dmabuf;\n-\tsize_t length;\n-};\n-\n-struct ipa_buffer {\n-\tunsigned int id;\n-\tunsigned int num_planes;\n-\tstruct ipa_buffer_plane planes[3];\n-};\n-\n-struct ipa_control_list {\n-\tconst uint8_t *data;\n-\tunsigned int size;\n-};\n-\n-struct ipa_operation_data {\n-\tunsigned int operation;\n-\tconst uint32_t *data;\n-\tunsigned int num_data;\n-\tconst struct ipa_control_list *lists;\n-\tunsigned int num_lists;\n-};\n-\n-struct ipa_callback_ops {\n-\tvoid (*queue_frame_action)(void *cb_ctx, unsigned int frame,\n-\t\t\t\t struct ipa_operation_data &data);\n-};\n-\n-struct ipa_context_ops {\n-\tvoid (*destroy)(struct ipa_context *ctx);\n-\tvoid *(*get_interface)(struct ipa_context *ctx);\n-\tvoid (*init)(struct ipa_context *ctx,\n-\t\t const struct ipa_settings *settings);\n-\tint (*start)(struct ipa_context *ctx);\n-\tvoid (*stop)(struct ipa_context *ctx);\n-\tvoid (*register_callbacks)(struct ipa_context *ctx,\n-\t\t\t\t const struct ipa_callback_ops *callbacks,\n-\t\t\t\t void *cb_ctx);\n-\tvoid (*configure)(struct ipa_context *ctx,\n-\t\t\t const struct ipa_sensor_info *sensor_info,\n-\t\t\t const struct ipa_stream *streams,\n-\t\t\t unsigned int num_streams,\n-\t\t\t const struct ipa_control_info_map *maps,\n-\t\t\t unsigned int num_maps);\n-\tvoid (*map_buffers)(struct ipa_context *ctx,\n-\t\t\t const struct ipa_buffer *buffers,\n-\t\t\t size_t num_buffers);\n-\tvoid (*unmap_buffers)(struct ipa_context *ctx, const unsigned int *ids,\n-\t\t\t size_t num_buffers);\n-\tvoid (*process_event)(struct ipa_context *ctx,\n-\t\t\t const struct ipa_operation_data *data);\n-};\n-\n-struct ipa_context *ipaCreate();\n-\n-#ifdef __cplusplus\n-}\n-\n #include <map>\n #include <vector>\n \n@@ -170,6 +65,5 @@ public:\n };\n \n } /* namespace libcamera */\n-#endif\n \n #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */\ndiff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp\ndeleted file mode 100644\nindex 231300ce..00000000\n--- a/src/libcamera/ipa_context_wrapper.cpp\n+++ /dev/null\n@@ -1,297 +0,0 @@\n-/* SPDX-License-Identifier: LGPL-2.1-or-later */\n-/*\n- * Copyright (C) 2019, Google Inc.\n- *\n- * ipa_context_wrapper.cpp - Image Processing Algorithm context wrapper\n- */\n-\n-#include \"libcamera/internal/ipa_context_wrapper.h\"\n-\n-#include <vector>\n-\n-#include <libcamera/controls.h>\n-\n-#include \"libcamera/internal/byte_stream_buffer.h\"\n-#include \"libcamera/internal/camera_sensor.h\"\n-#include \"libcamera/internal/utils.h\"\n-\n-/**\n- * \\file ipa_context_wrapper.h\n- * \\brief Image Processing Algorithm context wrapper\n- */\n-\n-namespace libcamera {\n-\n-/**\n- * \\class IPAContextWrapper\n- * \\brief Wrap an ipa_context and expose it as an IPAInterface\n- *\n- * The IPAContextWrapper class wraps an ipa_context, provided by an IPA module, and\n- * exposes an IPAInterface. This mechanism is used for IPAs that are not\n- * isolated in a separate process to allow direct calls from pipeline handler\n- * using the IPAInterface API instead of the lower-level ipa_context API.\n- *\n- * The IPAInterface methods are converted to the ipa_context API by translating\n- * all C++ arguments into plain C structures or byte arrays that contain no\n- * pointer, as required by the ipa_context API.\n- */\n-\n-/**\n- * \\brief Construct an IPAContextWrapper instance that wraps the \\a context\n- * \\param[in] context The IPA module context\n- *\n- * Ownership of the \\a context is passed to the IPAContextWrapper. The context remains\n- * valid for the whole lifetime of the wrapper and is destroyed automatically\n- * with it.\n- */\n-IPAContextWrapper::IPAContextWrapper(struct ipa_context *context)\n-\t: ctx_(context), intf_(nullptr)\n-{\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tbool forceCApi = !!utils::secure_getenv(\"LIBCAMERA_IPA_FORCE_C_API\");\n-\n-\tif (!forceCApi && ctx_ && ctx_->ops->get_interface) {\n-\t\tintf_ = reinterpret_cast<IPAInterface *>(ctx_->ops->get_interface(ctx_));\n-\t\tintf_->queueFrameAction.connect(this, &IPAContextWrapper::doQueueFrameAction);\n-\t\treturn;\n-\t}\n-\n-\tctx_->ops->register_callbacks(ctx_, &IPAContextWrapper::callbacks_,\n-\t\t\t\t this);\n-}\n-\n-IPAContextWrapper::~IPAContextWrapper()\n-{\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tctx_->ops->destroy(ctx_);\n-}\n-\n-int IPAContextWrapper::init(const IPASettings &settings)\n-{\n-\tif (intf_)\n-\t\treturn intf_->init(settings);\n-\n-\tif (!ctx_)\n-\t\treturn 0;\n-\n-\tstruct ipa_settings c_settings;\n-\tc_settings.configuration_file = settings.configurationFile.c_str();\n-\n-\tctx_->ops->init(ctx_, &c_settings);\n-\n-\treturn 0;\n-}\n-\n-int IPAContextWrapper::start()\n-{\n-\tif (intf_)\n-\t\treturn intf_->start();\n-\n-\tif (!ctx_)\n-\t\treturn 0;\n-\n-\treturn ctx_->ops->start(ctx_);\n-}\n-\n-void IPAContextWrapper::stop()\n-{\n-\tif (intf_)\n-\t\treturn intf_->stop();\n-\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tctx_->ops->stop(ctx_);\n-}\n-\n-void IPAContextWrapper::configure(const CameraSensorInfo &sensorInfo,\n-\t\t\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t\t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t\t\t const IPAOperationData &ipaConfig,\n-\t\t\t\t IPAOperationData *result)\n-{\n-\tif (intf_)\n-\t\treturn intf_->configure(sensorInfo, streamConfig,\n-\t\t\t\t\tentityControls, ipaConfig, result);\n-\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tserializer_.reset();\n-\n-\t/* Translate the camera sensor info. */\n-\tstruct ipa_sensor_info sensor_info = {};\n-\tsensor_info.model = sensorInfo.model.c_str();\n-\tsensor_info.bits_per_pixel = sensorInfo.bitsPerPixel;\n-\tsensor_info.active_area.width = sensorInfo.activeAreaSize.width;\n-\tsensor_info.active_area.height = sensorInfo.activeAreaSize.height;\n-\tsensor_info.analog_crop.left = sensorInfo.analogCrop.x;\n-\tsensor_info.analog_crop.top = sensorInfo.analogCrop.y;\n-\tsensor_info.analog_crop.width = sensorInfo.analogCrop.width;\n-\tsensor_info.analog_crop.height = sensorInfo.analogCrop.height;\n-\tsensor_info.output_size.width = sensorInfo.outputSize.width;\n-\tsensor_info.output_size.height = sensorInfo.outputSize.height;\n-\tsensor_info.pixel_rate = sensorInfo.pixelRate;\n-\tsensor_info.line_length = sensorInfo.lineLength;\n-\n-\t/* Translate the IPA stream configurations map. */\n-\tstruct ipa_stream c_streams[streamConfig.size()];\n-\n-\tunsigned int i = 0;\n-\tfor (const auto &stream : streamConfig) {\n-\t\tstruct ipa_stream *c_stream = &c_streams[i];\n-\t\tunsigned int id = stream.first;\n-\t\tconst IPAStream &ipaStream = stream.second;\n-\n-\t\tc_stream->id = id;\n-\t\tc_stream->pixel_format = ipaStream.pixelFormat;\n-\t\tc_stream->width = ipaStream.size.width;\n-\t\tc_stream->height = ipaStream.size.height;\n-\n-\t\t++i;\n-\t}\n-\n-\t/* Translate the IPA entity controls map. */\n-\tstruct ipa_control_info_map c_info_maps[entityControls.size()];\n-\tstd::vector<std::vector<uint8_t>> data(entityControls.size());\n-\n-\ti = 0;\n-\tfor (const auto &info : entityControls) {\n-\t\tstruct ipa_control_info_map &c_info_map = c_info_maps[i];\n-\t\tunsigned int id = info.first;\n-\t\tconst ControlInfoMap &infoMap = info.second;\n-\n-\t\tsize_t infoMapSize = serializer_.binarySize(infoMap);\n-\t\tdata[i].resize(infoMapSize);\n-\t\tByteStreamBuffer byteStream(data[i].data(), data[i].size());\n-\t\tserializer_.serialize(infoMap, byteStream);\n-\n-\t\tc_info_map.id = id;\n-\t\tc_info_map.data = byteStream.base();\n-\t\tc_info_map.size = byteStream.size();\n-\n-\t\t++i;\n-\t}\n-\n-\t/* \\todo Translate the ipaConfig and reponse */\n-\tctx_->ops->configure(ctx_, &sensor_info, c_streams, streamConfig.size(),\n-\t\t\t c_info_maps, entityControls.size());\n-}\n-\n-void IPAContextWrapper::mapBuffers(const std::vector<IPABuffer> &buffers)\n-{\n-\tif (intf_)\n-\t\treturn intf_->mapBuffers(buffers);\n-\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tstruct ipa_buffer c_buffers[buffers.size()];\n-\n-\tfor (unsigned int i = 0; i < buffers.size(); ++i) {\n-\t\tstruct ipa_buffer &c_buffer = c_buffers[i];\n-\t\tconst IPABuffer &buffer = buffers[i];\n-\t\tconst std::vector<FrameBuffer::Plane> &planes = buffer.planes;\n-\n-\t\tc_buffer.id = buffer.id;\n-\t\tc_buffer.num_planes = planes.size();\n-\n-\t\tfor (unsigned int j = 0; j < planes.size(); ++j) {\n-\t\t\tconst FrameBuffer::Plane &plane = planes[j];\n-\t\t\tc_buffer.planes[j].dmabuf = plane.fd.fd();\n-\t\t\tc_buffer.planes[j].length = plane.length;\n-\t\t}\n-\t}\n-\n-\tctx_->ops->map_buffers(ctx_, c_buffers, buffers.size());\n-}\n-\n-void IPAContextWrapper::unmapBuffers(const std::vector<unsigned int> &ids)\n-{\n-\tif (intf_)\n-\t\treturn intf_->unmapBuffers(ids);\n-\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tctx_->ops->unmap_buffers(ctx_, ids.data(), ids.size());\n-}\n-\n-void IPAContextWrapper::processEvent(const IPAOperationData &data)\n-{\n-\tif (intf_)\n-\t\treturn intf_->processEvent(data);\n-\n-\tif (!ctx_)\n-\t\treturn;\n-\n-\tstruct ipa_operation_data c_data;\n-\tc_data.operation = data.operation;\n-\tc_data.data = data.data.data();\n-\tc_data.num_data = data.data.size();\n-\n-\tstruct ipa_control_list control_lists[data.controls.size()];\n-\tc_data.lists = control_lists;\n-\tc_data.num_lists = data.controls.size();\n-\n-\tstd::size_t listsSize = 0;\n-\tfor (const auto &list : data.controls)\n-\t\tlistsSize += serializer_.binarySize(list);\n-\n-\tstd::vector<uint8_t> binaryData(listsSize);\n-\tByteStreamBuffer byteStreamBuffer(binaryData.data(), listsSize);\n-\n-\tunsigned int i = 0;\n-\tfor (const auto &list : data.controls) {\n-\t\tstruct ipa_control_list &c_list = control_lists[i];\n-\t\tc_list.size = serializer_.binarySize(list);\n-\t\tByteStreamBuffer b = byteStreamBuffer.carveOut(c_list.size);\n-\n-\t\tserializer_.serialize(list, b);\n-\n-\t\tc_list.data = b.base();\n-\t}\n-\n-\tctx_->ops->process_event(ctx_, &c_data);\n-}\n-\n-void IPAContextWrapper::doQueueFrameAction(unsigned int frame,\n-\t\t\t\t\t const IPAOperationData &data)\n-{\n-\tIPAInterface::queueFrameAction.emit(frame, data);\n-}\n-\n-void IPAContextWrapper::queue_frame_action(void *ctx, unsigned int frame,\n-\t\t\t\t\t struct ipa_operation_data &data)\n-{\n-\tIPAContextWrapper *_this = static_cast<IPAContextWrapper *>(ctx);\n-\tIPAOperationData opData;\n-\n-\topData.operation = data.operation;\n-\tfor (unsigned int i = 0; i < data.num_data; ++i)\n-\t\topData.data.push_back(data.data[i]);\n-\n-\tfor (unsigned int i = 0; i < data.num_lists; ++i) {\n-\t\tconst struct ipa_control_list &c_list = data.lists[i];\n-\t\tByteStreamBuffer b(c_list.data, c_list.size);\n-\t\topData.controls.push_back(_this->serializer_.deserialize<ControlList>(b));\n-\t}\n-\n-\t_this->doQueueFrameAction(frame, opData);\n-}\n-\n-#ifndef __DOXYGEN__\n-/*\n- * This construct confuses Doxygen and makes it believe that all members of the\n- * operations is a member of IPAContextWrapper. It must thus be hidden.\n- */\n-const struct ipa_callback_ops IPAContextWrapper::callbacks_ = {\n-\t.queue_frame_action = &IPAContextWrapper::queue_frame_action,\n-};\n-#endif\n-\n-} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "17/38" ] }