Patch Detail
Show a patch.
GET /api/1.1/patches/9688/?format=api
{ "id": 9688, "url": "https://patchwork.libcamera.org/api/1.1/patches/9688/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9688/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200922094738.5327-5-jacopo@jmondi.org>", "date": "2020-09-22T09:47:34", "name": "[libcamera-devel,v3,4/8] android: camera_device: Clear allocator at configureStream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cb5dcdd4116f3ed842cc2fef2a8431062ec44b9a", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9688/mbox/", "series": [ { "id": 1306, "url": "https://patchwork.libcamera.org/api/1.1/series/1306/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1306", "date": "2020-09-22T09:47:30", "name": "android: camera_device: Add support for internal buffers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1306/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9688/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9688/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09AC3BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Sep 2020 09:44:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBCCD62FD4;\n\tTue, 22 Sep 2020 11:44:18 +0200 (CEST)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 399E160364\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Sep 2020 11:44:18 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 02AF6E000D;\n\tTue, 22 Sep 2020 09:44:11 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 22 Sep 2020 11:47:34 +0200", "Message-Id": "<20200922094738.5327-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200922094738.5327-1-jacopo@jmondi.org>", "References": "<20200922094738.5327-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 4/8] android: camera_device: Clear\n\tallocator at configureStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "hanlinchen@chromium.org", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The configureStream operation might be called by the Android framework\nin two successive capture session without going through a close().\n\nClear all the allocated buffers before configuring the camera streams.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 98b8159ebd8c..42fb9ea4e113 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1182,12 +1182,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t}\n \n \t/*\n-\t * Clear and remove any existing configuration from previous calls, and\n-\t * ensure the required entries are available without further\n-\t * reallocation.\n+\t * Clear and remove any existing configuration and memory allocated from\n+\t * previous calls, and ensure the required entries are available without\n+\t * further reallocation.\n \t */\n \tstreams_.clear();\n \tstreams_.reserve(stream_list->num_streams);\n+\tallocator_.clear();\n \n \t/* First handle all non-MJPEG streams. */\n \tcamera3_stream_t *jpegStream = nullptr;\n", "prefixes": [ "libcamera-devel", "v3", "4/8" ] }