Patch Detail
Show a patch.
GET /api/1.1/patches/9672/?format=api
{ "id": 9672, "url": "https://patchwork.libcamera.org/api/1.1/patches/9672/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9672/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200920134356.24605-1-laurent.pinchart@ideasonboard.com>", "date": "2020-09-20T13:43:56", "name": "[libcamera-devel] libcamera: Don't unnecessarily include event_notifier.h", "commit_ref": "2fa4ba01ffa2984e85ca77fce1430b6ae86ae84f", "pull_url": null, "state": "accepted", "archived": false, "hash": "03ce5a5a0c5ca0cda102cfa5eb4a7c86cca2748c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9672/mbox/", "series": [ { "id": 1298, "url": "https://patchwork.libcamera.org/api/1.1/series/1298/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1298", "date": "2020-09-20T13:43:56", "name": "[libcamera-devel] libcamera: Don't unnecessarily include event_notifier.h", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1298/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9672/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9672/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 638D2BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 20 Sep 2020 13:44:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED48062FBF;\n\tSun, 20 Sep 2020 15:44:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E85B662E65\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 20 Sep 2020 15:44:33 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D1344FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 20 Sep 2020 15:44:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j4/wjBjD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600609473;\n\tbh=dyfJ/edHvVL6uxlyxyoCejgBBYRBNJDLLxp26dZHq4I=;\n\th=From:To:Subject:Date:From;\n\tb=j4/wjBjDBCtSw8IMqQyWMbgN+pk+JJeci3/wwYtEuESyBmz0mCcleMEZ1njwH24YA\n\tnv55++n9ZPJdj29tfEQ0roeQiPlJCmzfvrMym774kV5VCRxXCgboH+cpbY61uvKkq9\n\tPrHNNA294gRz/RSLoOLyiniFh0/K6nvN0U/OGKNA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 20 Sep 2020 16:43:56 +0300", "Message-Id": "<20200920134356.24605-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: Don't unnecessarily include\n\tevent_notifier.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ipc_unixsocket.h and process.h internal headers don't need to\ninclude event_notifier.h, the former because a forward declaration\nsuffices, and the latter because it doesn't use event notifiers. Remove\nthe unnecessary include, and include signal.h instead which is required\nand was included indirectly through event_notifier.h.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/ipc_unixsocket.h | 4 +++-\n include/libcamera/internal/process.h | 2 +-\n src/libcamera/ipc_unixsocket.cpp | 2 ++\n 3 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipc_unixsocket.h b/include/libcamera/internal/ipc_unixsocket.h\nindex 9dcaaa26956d..e871b65036bd 100644\n--- a/include/libcamera/internal/ipc_unixsocket.h\n+++ b/include/libcamera/internal/ipc_unixsocket.h\n@@ -12,10 +12,12 @@\n #include <sys/types.h>\n #include <vector>\n \n-#include <libcamera/event_notifier.h>\n+#include <libcamera/signal.h>\n \n namespace libcamera {\n \n+class EventNotifier;\n+\n class IPCUnixSocket\n {\n public:\ndiff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\nindex 36595106f3b9..2688557cb8e2 100644\n--- a/include/libcamera/internal/process.h\n+++ b/include/libcamera/internal/process.h\n@@ -10,7 +10,7 @@\n #include <string>\n #include <vector>\n \n-#include <libcamera/event_notifier.h>\n+#include <libcamera/signal.h>\n \n namespace libcamera {\n \ndiff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\nindex 701b2c518217..5c8cce16200e 100644\n--- a/src/libcamera/ipc_unixsocket.cpp\n+++ b/src/libcamera/ipc_unixsocket.cpp\n@@ -12,6 +12,8 @@\n #include <sys/socket.h>\n #include <unistd.h>\n \n+#include <libcamera/event_notifier.h>\n+\n #include \"libcamera/internal/log.h\"\n \n /**\n", "prefixes": [ "libcamera-devel" ] }