Patch Detail
Show a patch.
GET /api/1.1/patches/9650/?format=api
{ "id": 9650, "url": "https://patchwork.libcamera.org/api/1.1/patches/9650/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9650/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200918094233.5273-6-naush@raspberrypi.com>", "date": "2020-09-18T09:42:26", "name": "[libcamera-devel,v8,05/12] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream", "commit_ref": "3e7ee080d6dcc3f674ccdd14e08b7cf25df06ddd", "pull_url": null, "state": "accepted", "archived": false, "hash": "d3a8251a2f5e74688c84cc50425133bda0b6e516", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9650/mbox/", "series": [ { "id": 1295, "url": "https://patchwork.libcamera.org/api/1.1/series/1295/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1295", "date": "2020-09-18T09:42:21", "name": "Zero-copy RAW stream work", "version": 8, "mbox": "https://patchwork.libcamera.org/series/1295/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9650/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9650/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66A02C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Sep 2020 09:44:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3592562FC8;\n\tFri, 18 Sep 2020 11:44:03 +0200 (CEST)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C13EF62FBB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Sep 2020 11:43:59 +0200 (CEST)", "by mail-wr1-x434.google.com with SMTP id z1so4955094wrt.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Sep 2020 02:43:59 -0700 (PDT)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tn2sm4792472wma.29.2020.09.18.02.43.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Sep 2020 02:43:58 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"L8yE7iSU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2HZNXIdwEKmIQyD2h2XM7I6cmzMuhwlSR4pJrDGbzE4=;\n\tb=L8yE7iSUzPJQ5OtAfqY9b47MzNzzWAIZSYn4Jamm6Kof+lsKJeBdeegXM/f9McspB9\n\tOL1o3PNo+NtcIy/9EdkzQHFbpFiWU/grn3ISVNu9FFKrp6z8U+lnsShT50K92YN28XSz\n\tgcGmLXRAfPnQom7UK2fCS7K3PHHv4HOOaWjXZKylXMByLfTulvPfhUQYOlzTPOd2NA/w\n\tlkFsWuS71C4nGoYGlYiimYiY/8RrivCAMux1/Y4I3nzuO9aoiQ0DA/isgeowE4z16NUI\n\tZhy3o76AGZDSQAiXfcwzFhB8j0CphgrieoxhlvLrTHgpeqhXPQXIZssPfDZQr+sjvlSv\n\tul3A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=2HZNXIdwEKmIQyD2h2XM7I6cmzMuhwlSR4pJrDGbzE4=;\n\tb=ML4sTWtU8u7UwWBjbJF1rj6jhNHIsAoOEkR4pXV327bngOeXMsrV2ir9Evi9rVxMCW\n\tr04kJrMsscOWv1bjuyMY7VpvSHKlP4ykw+PDZktXSId4zDH8w1ayJ55btgliyB0deBXk\n\t1pzqxJJ3RkvWhD58PLyoPa8h4epAobmWQToXNCtmCwwZKbfU7W2U8NAjFmq4IC20x77h\n\tIUBwaVcWdlmCLMHB4JfHQTCSK5hv/6UiOA98vHVwaRnZpGxF6vM/vMugbtOBTc0Tntbx\n\tNMy4vpCNP/s4W/VTfOj6Zp+UPvgJpg4DasAH6rSh42msiiUGxTeHEeOvMl90yWc9hWei\n\tSOHQ==", "X-Gm-Message-State": "AOAM530konwvCN8bzyoOvh9bVTU4hFdRPAZz8TE0CRUliyrulizBwrvX\n\tZF/4M0i3clfFcJGwaGXYUXq5Brbp5mAvGQ==", "X-Google-Smtp-Source": "ABdhPJw79wJ3cxnuUoLgVYcaH5GeKUI/waIZGAzLsc7atSg5qHqnnZPyDeHhH0IJEqgD6YFEz2jdOQ==", "X-Received": "by 2002:a5d:660f:: with SMTP id\n\tn15mr39653272wru.103.1600422239137; \n\tFri, 18 Sep 2020 02:43:59 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Sep 2020 10:42:26 +0100", "Message-Id": "<20200918094233.5273-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200918094233.5273-1-naush@raspberrypi.com>", "References": "<20200918094233.5273-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v8 05/12] libcamera: pipeline:\n\traspberrypi: Remove const qualifier from RPiStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ed83a2c6..6b9de029 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -149,7 +149,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1107,12 +1107,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1173,12 +1173,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1259,7 +1259,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n", "prefixes": [ "libcamera-devel", "v8", "05/12" ] }