Patch Detail
Show a patch.
GET /api/1.1/patches/9649/?format=api
{ "id": 9649, "url": "https://patchwork.libcamera.org/api/1.1/patches/9649/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9649/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200918094233.5273-5-naush@raspberrypi.com>", "date": "2020-09-18T09:42:25", "name": "[libcamera-devel,v8,04/12] libcamera: pipeline: raspberrypi: Increase the number of RAW buffers", "commit_ref": "addd343b963adfc36c8773db069c859323f688ec", "pull_url": null, "state": "accepted", "archived": false, "hash": "ee9c461e2dc5e97b912e958e5d93cfb3f5ad0c38", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9649/mbox/", "series": [ { "id": 1295, "url": "https://patchwork.libcamera.org/api/1.1/series/1295/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1295", "date": "2020-09-18T09:42:21", "name": "Zero-copy RAW stream work", "version": 8, "mbox": "https://patchwork.libcamera.org/series/1295/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9649/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9649/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05ED1C3B5D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Sep 2020 09:44:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA4E562FC2;\n\tFri, 18 Sep 2020 11:44:01 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F0DC62FAF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Sep 2020 11:43:58 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id z9so4874666wmk.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Sep 2020 02:43:58 -0700 (PDT)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tn2sm4792472wma.29.2020.09.18.02.43.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Sep 2020 02:43:57 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"U0DSjait\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=nE/emN/9YQ8F/OJCPwpwoa+soM6JSc3SLzfzjKB3NuU=;\n\tb=U0DSjaitaVqcUq8uu9G+GYfyAMP7BY3asPt5PGXll5LBR34UgA0MsS0zoFfchMhqIZ\n\tRoutru0keEdD0g8239b8H34Ah17Rxopwg3xmG6uUgtwMihBYqaykaRvJHBBteTXk1dRN\n\toaRoXyvXWj5jhXR1AsrBhjpuKe6duAii4JialE1Wrz5IBYGMS/eEJoi74EriBGZKgjro\n\tYp82e5zT34QNFuTlZkfLAlXA4wAGKeGOWkYlT+Il5BPXaE+gpvz+UTuXgtHvyFdW8Exl\n\tdxXWN32eM0x/iQhZ4sf0hzlRYZd2k84aBAEouutRV9wXjbVp1hiGpBu3A6dpIFxNyIHv\n\tQ35A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=nE/emN/9YQ8F/OJCPwpwoa+soM6JSc3SLzfzjKB3NuU=;\n\tb=UI66IZVDDERX6cihfXP0sqqXqNagZvlGtjMKvfIfmWsJ5LMNNUAJ96e2+SVp8eSv2L\n\tLJw5XuaAGFgmsL+rOlPA+NVj26EJLawLYVdFVfZUzn0Emb+9houlMCKqlFzFX1j3Vq10\n\tz7pppOzIJkAKBtZVlWsnxntmbpXBXFNH9Tu68FzSj1hLqCmU2LrlVpTZdHsa4xsG5eS8\n\tZ47CkgnocGCo/bqIj7wFmQqt94hHzNCVyMteki/kAdYxTYltlarwK4Vd1DwoOEKKYDzo\n\tH71oinfYCVXLQvtTNSMcy3podUuknyQBLrk8kQaqd0ZonlD1NrsmQg33w/acHnZcb3l3\n\tJsfQ==", "X-Gm-Message-State": "AOAM532sVc8/Jj9krCPzaPa/LfGqeU0TqKQTS5Bh2sxadsFW4lZIwylO\n\tXxPVKtplTfu0auiS49z+gL1KPRTfkfrIzQ==", "X-Google-Smtp-Source": "ABdhPJzWLm9TsmDCMIMArNdCmNs3FVYZUhPKLn7fHRBdgIOA62fZ9O2uGOir19WQIy3zfwNXUpq8Zg==", "X-Received": "by 2002:a1c:2ed0:: with SMTP id\n\tu199mr14222107wmu.125.1600422238133; \n\tFri, 18 Sep 2020 02:43:58 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Sep 2020 10:42:25 +0100", "Message-Id": "<20200918094233.5273-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200918094233.5273-1-naush@raspberrypi.com>", "References": "<20200918094233.5273-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v8 04/12] libcamera: pipeline:\n\traspberrypi: Increase the number of RAW buffers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Increase the number of expected RAW buffers in the stream configuration\nto 2. This will avoid dropping Unicam frames when exporting RAW streams.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f15345ea..ed83a2c6 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -378,7 +378,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n \t\t\tsensorFormat = findBestMode(fmts, size);\n \t\t\tpixelFormat = sensorFormat.fourcc.toPixelFormat();\n \t\t\tASSERT(pixelFormat.isValid());\n-\t\t\tbufferCount = 1;\n+\t\t\tbufferCount = 2;\n \t\t\trawCount++;\n \t\t\tbreak;\n \n", "prefixes": [ "libcamera-devel", "v8", "04/12" ] }