Patch Detail
Show a patch.
GET /api/1.1/patches/9603/?format=api
{ "id": 9603, "url": "https://patchwork.libcamera.org/api/1.1/patches/9603/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9603/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200914142149.63857-12-niklas.soderlund@ragnatech.se>", "date": "2020-09-14T14:21:47", "name": "[libcamera-devel,v2,11/13] libcamera: pipeline: rkisp1: Track buffers for self path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0cb91d2406bbbd019a396b669d6c73fae1415476", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9603/mbox/", "series": [ { "id": 1289, "url": "https://patchwork.libcamera.org/api/1.1/series/1289/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1289", "date": "2020-09-14T14:21:36", "name": "libcamera: pipeline: rkisp1: Extend to support two streams", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1289/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9603/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9603/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91AE8C3B5D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 14 Sep 2020 14:22:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6237662E1C;\n\tMon, 14 Sep 2020 16:22:17 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB7F262DF9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Sep 2020 16:22:14 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid af352800-f695-11ea-a39b-005056917f90;\n\tMon, 14 Sep 2020 16:22:14 +0200 (CEST)" ], "X-Halon-ID": "af352800-f695-11ea-a39b-005056917f90", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 14 Sep 2020 16:21:47 +0200", "Message-Id": "<20200914142149.63857-12-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200914142149.63857-1-niklas.soderlund@ragnatech.se>", "References": "<20200914142149.63857-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 11/13] libcamera: pipeline: rkisp1:\n\tTrack buffers for self path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation of supporting both the main and self path extend\nRkISP1FrameInfo to track buffers from the self path stream.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 01cd461427e3a6dc..bc961f8e78f2c979 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -69,6 +69,7 @@ struct RkISP1FrameInfo {\n \tFrameBuffer *paramBuffer;\n \tFrameBuffer *statBuffer;\n \tFrameBuffer *mainPathBuffer;\n+\tFrameBuffer *selfPathBuffer;\n \n \tbool paramFilled;\n \tbool paramDequeued;\n@@ -272,7 +273,8 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n \n \tFrameBuffer *mainPathBuffer = request->findBuffer(&data->mainPathStream_);\n-\tif (!mainPathBuffer) {\n+\tFrameBuffer *selfPathBuffer = request->findBuffer(&data->selfPathStream_);\n+\tif (!mainPathBuffer && !selfPathBuffer) {\n \t\tLOG(RkISP1, Error)\n \t\t\t<< \"Attempt to queue request with invalid stream\";\n \t\treturn nullptr;\n@@ -287,6 +289,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n \tinfo->request = request;\n \tinfo->paramBuffer = paramBuffer;\n \tinfo->mainPathBuffer = mainPathBuffer;\n+\tinfo->selfPathBuffer = selfPathBuffer;\n \tinfo->statBuffer = statBuffer;\n \tinfo->paramFilled = false;\n \tinfo->paramDequeued = false;\n@@ -345,7 +348,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)\n \n \t\tif (info->paramBuffer == buffer ||\n \t\t info->statBuffer == buffer ||\n-\t\t info->mainPathBuffer == buffer)\n+\t\t info->mainPathBuffer == buffer ||\n+\t\t info->selfPathBuffer == buffer)\n \t\t\treturn info;\n \t}\n \n@@ -417,7 +421,12 @@ protected:\n \n \t\tpipe_->param_->queueBuffer(info->paramBuffer);\n \t\tpipe_->stat_->queueBuffer(info->statBuffer);\n-\t\tpipe_->mainPathVideo_->queueBuffer(info->mainPathBuffer);\n+\n+\t\tif (info->mainPathBuffer)\n+\t\t\tpipe_->mainPathVideo_->queueBuffer(info->mainPathBuffer);\n+\n+\t\tif (info->selfPathBuffer)\n+\t\t\tpipe_->selfPathVideo_->queueBuffer(info->selfPathBuffer);\n \t}\n \n private:\n", "prefixes": [ "libcamera-devel", "v2", "11/13" ] }