Patch Detail
Show a patch.
GET /api/1.1/patches/9581/?format=api
{ "id": 9581, "url": "https://patchwork.libcamera.org/api/1.1/patches/9581/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9581/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200912101129.12625-2-jacopo@jmondi.org>", "date": "2020-09-12T10:11:20", "name": "[libcamera-devel,v4,01/10] android: camera_device: Refuse unsupported formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa330d6aee561b9cc7d47e66ed96c272bd51180b", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9581/mbox/", "series": [ { "id": 1287, "url": "https://patchwork.libcamera.org/api/1.1/series/1287/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1287", "date": "2020-09-12T10:11:19", "name": "android: camera_device: Fix JPEG/RAW sizes", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1287/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9581/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9581/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C094EC3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 12 Sep 2020 10:07:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C76062DAB;\n\tSat, 12 Sep 2020 12:07:55 +0200 (CEST)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1BD562C8C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 12 Sep 2020 12:07:54 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5C1101BF204;\n\tSat, 12 Sep 2020 10:07:53 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 12 Sep 2020 12:11:20 +0200", "Message-Id": "<20200912101129.12625-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200912101129.12625-1-jacopo@jmondi.org>", "References": "<20200912101129.12625-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 01/10] android: camera_device: Refuse\n\tunsupported formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "hanlinchen@chromium.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The current implementation of CameraDevice::initializeStreamConfigurations()\nfails if an image format marked as mandatory is not supported by the\nlibcamera::Camera device, but erroneously accepts non-mandatory\nnon-supported formats in the list of accepted ones.\n\nFix this by ignoring non supported image formats which are not marked as\nmandatory.\n\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 93659e91f980..ebebdac38e28 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -398,10 +398,16 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n-\t\tif (camera3Format.mandatory && !mappedFormat.isValid()) {\n-\t\t\tLOG(HAL, Error) << \"Failed to map Android format \"\n-\t\t\t\t\t<< camera3Format.name << \" (\"\n-\t\t\t\t\t<< utils::hex(androidFormat) << \")\";\n+\n+\t\tif (!mappedFormat.isValid()) {\n+\t\t\t/* If the format is not mandatory, skip it. */\n+\t\t\tif (!camera3Format.mandatory)\n+\t\t\t\tcontinue;\n+\n+\t\t\tLOG(HAL, Error)\n+\t\t\t\t<< \"Failed to map mandatory Android format \"\n+\t\t\t\t<< camera3Format.name << \" (\"\n+\t\t\t\t<< utils::hex(androidFormat) << \"): aborting\";\n \t\t\treturn -EINVAL;\n \t\t}\n \n", "prefixes": [ "libcamera-devel", "v4", "01/10" ] }