Patch Detail
Show a patch.
GET /api/1.1/patches/9554/?format=api
{ "id": 9554, "url": "https://patchwork.libcamera.org/api/1.1/patches/9554/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9554/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200909130559.1122914-4-kieran.bingham@ideasonboard.com>", "date": "2020-09-09T13:05:59", "name": "[libcamera-devel,3/3] libcamera: ipa: Move key generation to utils", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "59c203ed86955bc4d5dfe6e88c6a8d5450457617", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9554/mbox/", "series": [ { "id": 1279, "url": "https://patchwork.libcamera.org/api/1.1/series/1279/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1279", "date": "2020-09-09T13:05:56", "name": "Unify utils locations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1279/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9554/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9554/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FFB2BDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 9 Sep 2020 13:06:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B7CF62D53;\n\tWed, 9 Sep 2020 15:06:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A13462B90\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 9 Sep 2020 15:06:05 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC3EBA15;\n\tWed, 9 Sep 2020 15:06:04 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JXDI+IMV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599656764;\n\tbh=cptv2qY2C+utz9f8wPg1t7W9f4Gv4rFCv9s0RZMXoWE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JXDI+IMVPhZxoYTtvmavO6wNJi3jYkcXhfNO8UDoiv3wt6u2QM9XzgmW+i6gi0/H1\n\tBWOCaU+AamYQXN9ofOh+LWQOh2zfPkV32aHbqRGOLu5ShRSP6/q1c4l63PzLEQsUgv\n\tyI3cWSeczsbunVyfqAe3YbhA5aAPN5nR701ZZVAk=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 9 Sep 2020 14:05:59 +0100", "Message-Id": "<20200909130559.1122914-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>", "References": "<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: ipa: Move key generation\n\tto utils", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the GPLv2 utilities used for generating public and private keys to\nthe utilities subtree.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nThe ipa-sign and installation scripts are more complex to move and can\nbe handled separately if this series is deemed worthwhile.\n---\n src/libcamera/meson.build | 1 -\n src/meson.build | 1 -\n {src/ipa => utils}/gen-ipa-priv-key.sh | 0\n {src/libcamera => utils}/gen-ipa-pub-key.py | 0\n utils/meson.build | 6 ++++++\n 5 files changed, 6 insertions(+), 2 deletions(-)\n rename {src/ipa => utils}/gen-ipa-priv-key.sh (100%)\n rename {src/libcamera => utils}/gen-ipa-pub-key.py (100%)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex d54ee979418b..61bed7f64e7e 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -100,7 +100,6 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],\n libcamera_sources += version_cpp\n \n if ipa_sign_module\n- gen_ipa_pub_key = files('gen-ipa-pub-key.py')\n ipa_pub_key_cpp = custom_target('ipa_pub_key_cpp',\n input : [ ipa_priv_key, 'ipa_pub_key.cpp.in' ],\n output : 'ipa_pub_key.cpp',\ndiff --git a/src/meson.build b/src/meson.build\nindex d69b4c1ea978..2ed4fb640284 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -6,7 +6,6 @@ endif\n \n openssl = find_program('openssl', required : true)\n if openssl.found()\n- ipa_gen_priv_key = files('ipa/gen-ipa-priv-key.sh')\n ipa_priv_key = custom_target('ipa-priv-key',\n output : [ 'ipa-priv-key.pem' ],\n command : [ ipa_gen_priv_key, '@OUTPUT@' ])\ndiff --git a/src/ipa/gen-ipa-priv-key.sh b/utils/gen-ipa-priv-key.sh\nsimilarity index 100%\nrename from src/ipa/gen-ipa-priv-key.sh\nrename to utils/gen-ipa-priv-key.sh\ndiff --git a/src/libcamera/gen-ipa-pub-key.py b/utils/gen-ipa-pub-key.py\nsimilarity index 100%\nrename from src/libcamera/gen-ipa-pub-key.py\nrename to utils/gen-ipa-pub-key.py\ndiff --git a/utils/meson.build b/utils/meson.build\nindex 7689790eb1c1..a069e1ca9f79 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -10,3 +10,9 @@ gen_formats = files('gen-formats.py')\n \n ## Generates libcamera.h\n gen_header = files('gen-header.sh')\n+\n+## Generates ipa-priv-key.pem\n+ipa_gen_priv_key = files('gen-ipa-priv-key.sh')\n+\n+## Generates ipa_pub_key.cpp\n+gen_ipa_pub_key = files('gen-ipa-pub-key.py')\n", "prefixes": [ "libcamera-devel", "3/3" ] }