Patch Detail
Show a patch.
GET /api/1.1/patches/9553/?format=api
{ "id": 9553, "url": "https://patchwork.libcamera.org/api/1.1/patches/9553/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9553/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200909130559.1122914-3-kieran.bingham@ideasonboard.com>", "date": "2020-09-09T13:05:58", "name": "[libcamera-devel,2/3] libcamera: Move Header generation utilities to utils", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c50cf36f1be3fc41e7dc3e430e22522226035051", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9553/mbox/", "series": [ { "id": 1279, "url": "https://patchwork.libcamera.org/api/1.1/series/1279/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1279", "date": "2020-09-09T13:05:56", "name": "Unify utils locations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1279/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9553/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9553/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4290FBDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 9 Sep 2020 13:06:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 323AF62D43;\n\tWed, 9 Sep 2020 15:06:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAF5462B90\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 9 Sep 2020 15:06:04 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BAA19DF;\n\tWed, 9 Sep 2020 15:06:04 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e5MZT47g\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599656764;\n\tbh=zD//Ihx1P8BtLeBv2L6EeYx2tMDTcKpdqKdLslwYK0k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e5MZT47gdFuvdqIsSPv8as4C48BRHo7fKqR2rCbsCJJjHm91T/J+qaG6DnMtdwjOl\n\t4Ba0iavTDtXms5WdQ5McCM9ndaKSVUYdA7D8Rvjxg8uEyDnom0DtMzhM7KMW+07p9j\n\t8r5fo2vbSrSMuwO0sd0Nih34SCxi94gH1Pcog7JI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 9 Sep 2020 14:05:58 +0100", "Message-Id": "<20200909130559.1122914-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>", "References": "<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: Move Header generation\n\tutilities to utils", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the GPL2 utilities which handle generation of controls, formats and\nthe top level libcamera header to the utils subtree.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nMove the GPL2 utility library out of the libcamera source directory\nand into the utils subdirectory.\n---\n include/libcamera/meson.build | 6 ------\n src/libcamera/meson.build | 2 --\n {src/libcamera => utils}/gen-controls.py | 0\n {include/libcamera => utils}/gen-formats.py | 0\n {include/libcamera => utils}/gen-header.sh | 0\n utils/meson.build | 9 +++++++++\n 6 files changed, 9 insertions(+), 8 deletions(-)\n rename {src/libcamera => utils}/gen-controls.py (100%)\n rename {include/libcamera => utils}/gen-formats.py (100%)\n rename {include/libcamera => utils}/gen-header.sh (100%)", "diff": "diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex cdb8e0372e77..692931a5a639 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -34,8 +34,6 @@ install_headers(libcamera_public_headers,\n #\n \n # control_ids.h and property_ids.h\n-gen_controls = files('../../src/libcamera/gen-controls.py')\n-\n control_source_files = [\n 'control_ids',\n 'property_ids',\n@@ -57,8 +55,6 @@ endforeach\n libcamera_public_headers += control_headers\n \n # formats.h\n-gen_formats = files('gen-formats.py')\n-\n formats_h = custom_target('formats_h',\n input : files(\n '../../src/libcamera/formats.yaml',\n@@ -72,8 +68,6 @@ formats_h = custom_target('formats_h',\n libcamera_public_headers += formats_h\n \n # libcamera.h\n-gen_header = files('gen-header.sh')\n-\n libcamera_h = custom_target('gen-header',\n input : 'meson.build',\n output : 'libcamera.h',\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex af2f3d950be6..d54ee979418b 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -77,8 +77,6 @@ if libudev.found()\n ])\n endif\n \n-gen_controls = files('gen-controls.py')\n-\n control_sources = []\n \n foreach source : control_source_files\ndiff --git a/src/libcamera/gen-controls.py b/utils/gen-controls.py\nsimilarity index 100%\nrename from src/libcamera/gen-controls.py\nrename to utils/gen-controls.py\ndiff --git a/include/libcamera/gen-formats.py b/utils/gen-formats.py\nsimilarity index 100%\nrename from include/libcamera/gen-formats.py\nrename to utils/gen-formats.py\ndiff --git a/include/libcamera/gen-header.sh b/utils/gen-header.sh\nsimilarity index 100%\nrename from include/libcamera/gen-header.sh\nrename to utils/gen-header.sh\ndiff --git a/utils/meson.build b/utils/meson.build\nindex c3cd9d69f887..7689790eb1c1 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -1,3 +1,12 @@\n # SPDX-License-Identifier: CC0-1.0\n \n subdir('ipu3')\n+\n+## Generates control_ids.h and property_ids.h\n+gen_controls = files('gen-controls.py')\n+\n+## Generates formats.h\n+gen_formats = files('gen-formats.py')\n+\n+## Generates libcamera.h\n+gen_header = files('gen-header.sh')\n", "prefixes": [ "libcamera-devel", "2/3" ] }