Patch Detail
Show a patch.
GET /api/1.1/patches/9521/?format=api
{ "id": 9521, "url": "https://patchwork.libcamera.org/api/1.1/patches/9521/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9521/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200908074913.109244-6-naush@raspberrypi.com>", "date": "2020-09-08T07:49:05", "name": "[libcamera-devel,v7,05/12] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d3a8251a2f5e74688c84cc50425133bda0b6e516", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9521/mbox/", "series": [ { "id": 1271, "url": "https://patchwork.libcamera.org/api/1.1/series/1271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1271", "date": "2020-09-08T07:49:00", "name": "Zero-copy RAW stream work", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9521/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9521/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC582BDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 8 Sep 2020 07:49:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 988CA62C08;\n\tTue, 8 Sep 2020 09:49:24 +0200 (CEST)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5E0160534\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Sep 2020 09:49:23 +0200 (CEST)", "by mail-wr1-x434.google.com with SMTP id m6so18050422wrn.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 08 Sep 2020 00:49:23 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tq15sm32534502wrr.8.2020.09.08.00.49.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 08 Sep 2020 00:49:22 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"T15ngFA2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2HZNXIdwEKmIQyD2h2XM7I6cmzMuhwlSR4pJrDGbzE4=;\n\tb=T15ngFA24+SyNpSvFhubxpCqtiLU9sT0x2chP0sihXxfhepCxnatAvxG+UydojmFVT\n\t2PfW9qDQtSsRJfuieqjwTy89+NrGFoVXzjFiV5WUNkrf/8nbaFwks5uQw0KeuI4WL37E\n\tCOO+nUTLLOEtDys2hRIJf/k0pXqv32/xlcOzAgHl/hsHwKN9ayCp7ni+DWcbU4az6ofz\n\t9DUFonwOB9BGESeY5dCc7TkCMgQVaumSC4Ali4ex6o4y4Y6PYZIj9PEZ0t3BSd0Nzntt\n\tKg0Lz/ELLSbT7QAIhOvG4IdB3C56BIyK5iex3fdxgBM0G5H1EIwHk6IZBeeSps1mf6Ll\n\tFEUQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=2HZNXIdwEKmIQyD2h2XM7I6cmzMuhwlSR4pJrDGbzE4=;\n\tb=pEKIBh4ifb2lcfoRKpY0vpLL0+wxbvQ5RC8CKcldsU72umyumLFjUHJRQnjMzhvrJj\n\t9RVnz5Vosj8Vfjhb/P5Vjg/pdrsC08SNiP6hqdSLQ0YsMWUhivxUwvbZn0yZszq7zdsv\n\t6JaY+7MV6ZTtEVnuXk9O2bAdCdYlT5Ox78iSghK26JFfp/I9oprl4PYRhCgRaSjC6aqh\n\tiH2o4qKbRugVqGdDp2F5OOaAAmktoLx1OaPQXpmDy7O2oij0aCRTKNG656sGaMbi1bNu\n\toeACQpIumkxOODzuHven3fukGE0MC15+mZ8lLC9roWHsQT7Q4lyqxCDvCfC25HXgAcwW\n\tgcpg==", "X-Gm-Message-State": "AOAM533ZdDVj6dazYsYixERWTaPr4NDZzsaQS3P2eXthX1+6VVoJa4mY\n\tCs0lyDSztew9ImNR4NLjgNy11mULOk3toQ==", "X-Google-Smtp-Source": "ABdhPJw3aBYsR8TJC9O6fT1fKVlyZV4krclR/Fn0yc0Y7UXMtz+hAmi1s5Hp5oZz3t/9KRw2R1VxXQ==", "X-Received": "by 2002:a5d:6852:: with SMTP id\n\to18mr24997882wrw.113.1599551363324; \n\tTue, 08 Sep 2020 00:49:23 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 8 Sep 2020 08:49:05 +0100", "Message-Id": "<20200908074913.109244-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200908074913.109244-1-naush@raspberrypi.com>", "References": "<20200908074913.109244-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 05/12] libcamera: pipeline:\n\traspberrypi: Remove const qualifier from RPiStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ed83a2c6..6b9de029 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -149,7 +149,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1107,12 +1107,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1173,12 +1173,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1259,7 +1259,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n", "prefixes": [ "libcamera-devel", "v7", "05/12" ] }