Patch Detail
Show a patch.
GET /api/1.1/patches/9512/?format=api
{ "id": 9512, "url": "https://patchwork.libcamera.org/api/1.1/patches/9512/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9512/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200907164450.13082-2-david.plowman@raspberrypi.com>", "date": "2020-09-07T16:44:47", "name": "[libcamera-devel,RFC,1/4] libcamera: Add SensorOutputSize property", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "def43bd5a09ad545a213f0891dec4f9c6a171c67", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9512/mbox/", "series": [ { "id": 1270, "url": "https://patchwork.libcamera.org/api/1.1/series/1270/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1270", "date": "2020-09-07T16:44:46", "name": "Digital zoom", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1270/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9512/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9512/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01E98BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Sep 2020 16:44:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEE8362BF9;\n\tMon, 7 Sep 2020 18:44:57 +0200 (CEST)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF2AA60599\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Sep 2020 18:44:56 +0200 (CEST)", "by mail-wr1-x435.google.com with SMTP id e16so16443997wrm.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 07 Sep 2020 09:44:56 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tv3sm27707033wmh.6.2020.09.07.09.44.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Sep 2020 09:44:55 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Nv6Y8ohS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=t8Hq0wZqqzzJWcIK/J0NH0XRrmlQ5FJTq1ubok6iBi8=;\n\tb=Nv6Y8ohS0Otx6TI72kJpd0T6IQu/un9V+i6OagPL6xTYsU84VZucDvmHNt7QFej9Gt\n\tTXT5XDt70V4Zy32B2ZYZqJoLmHcwOAx5Qt6WP56RPaD6g/GGC/nKUqieTITC1q5zHZvB\n\tIfHT6mvU1LbirwcxHQZjYXi9719cRHWg0IqgCxZbBikcplOZ6C9fUNqVlZAjwyI88eH5\n\t7IsDKhpDTHvlQoSN7mRNvk/rXFffAvZE6sEqbE9yNXCcdxK5t9Cx2gxqZxhRZzlWwKcJ\n\tKQHqc7ri26N7ENWGHP/LE3Z9mLme+mTOLy3k7m3R5dvs2T3FICceUmu9eNx4ig3keDZn\n\tWLOQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=t8Hq0wZqqzzJWcIK/J0NH0XRrmlQ5FJTq1ubok6iBi8=;\n\tb=Lz1IngCW25pB+Y4yqMX+ii61Zkasa2YuYaHSrtRhpKPYZJ/K6mxOd/P53RR6g7c0QE\n\tmyAXhW5UiK54Jmodd2tNJIocYDYogv6KJ0ktEh+0uxvAnoDyvndYfB8lxURl9hYL18uO\n\tsvhJT6EceSVoNX6omOTQX51ppZwD5u8os45N0+M2lqfi3/X8UvfvjFNkAc7Wm7MuXIq5\n\tkJgRkMUpyRuUd/+luNoaYWOelWUXLqp7buiLemj5WFUDZKPlMukVkMNvfMHFtfBcFawD\n\tPbArFc9zmKYEnfwjP+gE009r0Lspw5hIVMKtj371/hzsR2QAJZt04qZ01Odr9sebGLAX\n\tz1ng==", "X-Gm-Message-State": "AOAM5338tOyA0twgFHPlPbkan2luD2epxivdFQOtc+oZTpS0StiIr4qo\n\t5ZPp3xQRZa8nYO9PbhgV03hM5ZDopsMN5g==", "X-Google-Smtp-Source": "ABdhPJwl3dl10UYpf0EdZkCeawPpoohd6ozh5b4rm75vh+zjfZ4NtcNBLbWswRQI/GyH8t/uDrzq4Q==", "X-Received": "by 2002:adf:f106:: with SMTP id\n\tr6mr22783471wro.106.1599497096183; \n\tMon, 07 Sep 2020 09:44:56 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 7 Sep 2020 17:44:47 +0100", "Message-Id": "<20200907164450.13082-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200907164450.13082-1-david.plowman@raspberrypi.com>", "References": "<20200907164450.13082-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC PATCH 1/4] libcamera: Add SensorOutputSize\n\tproperty", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The SensorOutputSize camera property changes with the selected camera\nmode, so it must be updated when a new mode is chosen.\n---\n src/libcamera/camera_sensor.cpp | 3 +++\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 ++\n src/libcamera/property_ids.yaml | 6 ++++++\n 3 files changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex d2679a4..b1c218e 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -249,6 +249,9 @@ int CameraSensor::init()\n \t\tpropertyValue = 0;\n \tproperties_.set(properties::Rotation, propertyValue);\n \n+\t/* The SensorOutputSize is known once the camera mode is chosen. */\n+\tproperties_.set(properties::SensorOutputSize, Size(0, 0));\n+\n \t/* Enumerate, sort and cache media bus codes and sizes. */\n \tformats_ = subdev_->formats(pad_);\n \tif (formats_.empty()) {\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ce43af3..7f151cb 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -646,6 +646,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \tLOG(RPI, Info) << \"Sensor: \" << camera->id()\n \t\t << \" - Selected mode: \" << sensorFormat.toString();\n \n+\tdata->properties_.set(properties::SensorOutputSize, sensorFormat.size);\n+\n \t/*\n \t * This format may be reset on start() if the bayer order has changed\n \t * because of flips in the sensor.\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 74ad019..ed1df19 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -640,4 +640,10 @@ controls:\n \\todo Rename this property to ActiveAreas once we will have property\n categories (i.e. Properties::PixelArray::ActiveAreas)\n \n+ - SensorOutputSize:\n+ type: Size\n+ description: |\n+ The size, in pixels, of the image being output by the sensor in this\n+ camera mode.\n+\n ...\n", "prefixes": [ "libcamera-devel", "RFC", "1/4" ] }