Patch Detail
Show a patch.
GET /api/1.1/patches/9509/?format=api
{ "id": 9509, "url": "https://patchwork.libcamera.org/api/1.1/patches/9509/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9509/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200907071604.8355-9-david.plowman@raspberrypi.com>", "date": "2020-09-07T07:16:03", "name": "[libcamera-devel,v8,8/8] libcamera: ipa: raspberrypi: ALSC: Handle user transform", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "925b363fef36d092def50ce22ca02dce4058de08", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9509/mbox/", "series": [ { "id": 1268, "url": "https://patchwork.libcamera.org/api/1.1/series/1268/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1268", "date": "2020-09-07T07:15:55", "name": "2D transforms", "version": 8, "mbox": "https://patchwork.libcamera.org/series/1268/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9509/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9509/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 245A2BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Sep 2020 07:16:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E46E362BDF;\n\tMon, 7 Sep 2020 09:16:17 +0200 (CEST)", "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A64262B76\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Sep 2020 09:16:15 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id x23so3375833wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 07 Sep 2020 00:16:15 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tb2sm25543636wmh.47.2020.09.07.00.16.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Sep 2020 00:16:14 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RTzFUwuj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NxN5BIHNXBiSe01AANUlWSLW1QWfFBaoWgYdFWkMoL4=;\n\tb=RTzFUwujm9BzOaFk5OLgQ6bRc5FSDm1VfUPz94ePjHCz3IHZ7wJUUFmcqsRmdRbeF5\n\tpqi4kJzEEYIleELp7dv36+QwMuNXvxVevb+O+jv5zFNaI7q3Dz8/fyETquICkf7D/2v9\n\t5TSpk8M34wUYy2Z60bNpFIaPzvMj/6pUz7rdGi7klae2/qcw6xlU6Ex05iZD2kr8+EgS\n\tpQEvXZMBATMcs4w6ual20bFebsIS1RGHhWP877pS7Z4mxhvEypBcMHXYQ8rFE5AlAqss\n\tCGfyDvz84hvbFRj3vsFUWLrI6l0IXcxoRBPB700jwE0PDG428GQGxVy4+mXdRCrGaZn9\n\tLD/g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=NxN5BIHNXBiSe01AANUlWSLW1QWfFBaoWgYdFWkMoL4=;\n\tb=MC2GJEfPdWc3YgkqxmNCXxgPEukEAZL0WFuwOIrH5kz1HcAga3K63ripGvmKmH3D6N\n\t1dCIOEuP5SggpRPWDNfu6Q2L+SHX8OdXRnfpvHPN0uDbcgowxzbDEnslizgTGX3c/RCY\n\tuWhw8MhSZSzGMNN8u8D9B3UR7jMmX+zRkv57htl+vGshsbwXEhPQuds/XnW0YUzWWQ+t\n\tuv5/KbGt4fWtLknFmq6AkQouFEF+wJC4PmgXObJeiJl9RF5o9txcdGJ3TMMY/cvAbo84\n\t8nQcerdbshtdawg1xKCdXsp6D7A+Cl6fhvv41p+8VC3JRjxcR5eG4JU+KvbKhaUYhdWG\n\tyLrg==", "X-Gm-Message-State": "AOAM532KyYdrAUVZqoHVzwh21u9r5xbNcBY/QUPUuX0JCo7liuADitYQ\n\t9TqkcaGkIeNNfuf6GjvGckVdaKFqf0ZktQ==", "X-Google-Smtp-Source": "ABdhPJypRFkz/Qr3dzEF7y46KZLDpmoo3yhuMKpwTCka+Sskhnlp3AdpUvbc0rDrMRTD+mNFdIfLAg==", "X-Received": "by 2002:a1c:302:: with SMTP id 2mr18884498wmd.134.1599462975033; \n\tMon, 07 Sep 2020 00:16:15 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 7 Sep 2020 08:16:03 +0100", "Message-Id": "<20200907071604.8355-9-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200907071604.8355-1-david.plowman@raspberrypi.com>", "References": "<20200907071604.8355-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v8 8/8] libcamera: ipa: raspberrypi: ALSC:\n\tHandle user transform", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update ALSC (Auto Lens Shading Correction) to handle correctly the\nuser transform now passed in the camera mode.\n\nThe user transform is applied directly in the sensor so the image\nstatistics already incorporate it, and the adaptive algorithm is\nentirely agnostic towards it, so all we have to do is flip the\ncalibrated tables to match. (These tables will have been calibrated\nwithout the user transform.)\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\nindex 0d0e0b0..f610de2 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n@@ -184,7 +184,10 @@ void Alsc::waitForAysncThread()\n \n static bool compare_modes(CameraMode const &cm0, CameraMode const &cm1)\n {\n-\t// Return true if the modes crop from the sensor significantly differently.\n+\t// Return true if the modes crop from the sensor significantly differently,\n+\t// or if the user transform has changed.\n+\tif (cm0.transform != cm1.transform)\n+\t\treturn true;\n \tint left_diff = abs(cm0.crop_x - cm1.crop_x);\n \tint top_diff = abs(cm0.crop_y - cm1.crop_y);\n \tint right_diff = fabs(cm0.crop_x + cm0.scale_x * cm0.width -\n@@ -428,6 +431,10 @@ void resample_cal_table(double const cal_table_in[XY],\n \t\txf[i] = x - x_lo[i];\n \t\tx_hi[i] = std::min(x_lo[i] + 1, X - 1);\n \t\tx_lo[i] = std::max(x_lo[i], 0);\n+\t\tif (!!(camera_mode.transform & libcamera::Transform::HFlip)) {\n+\t\t\tx_lo[i] = X - 1 - x_lo[i];\n+\t\t\tx_hi[i] = X - 1 - x_hi[i];\n+\t\t}\n \t}\n \t// Now march over the output table generating the new values.\n \tdouble scale_y = camera_mode.sensor_height /\n@@ -440,6 +447,10 @@ void resample_cal_table(double const cal_table_in[XY],\n \t\tdouble yf = y - y_lo;\n \t\tint y_hi = std::min(y_lo + 1, Y - 1);\n \t\ty_lo = std::max(y_lo, 0);\n+\t\tif (!!(camera_mode.transform & libcamera::Transform::VFlip)) {\n+\t\t\ty_lo = Y - 1 - y_lo;\n+\t\t\ty_hi = Y - 1 - y_hi;\n+\t\t}\n \t\tdouble const *row_above = cal_table_in + X * y_lo;\n \t\tdouble const *row_below = cal_table_in + X * y_hi;\n \t\tfor (int i = 0; i < X; i++) {\n", "prefixes": [ "libcamera-devel", "v8", "8/8" ] }