Patch Detail
Show a patch.
GET /api/1.1/patches/9467/?format=api
{ "id": 9467, "url": "https://patchwork.libcamera.org/api/1.1/patches/9467/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9467/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200902152236.69770-7-jacopo@jmondi.org>", "date": "2020-09-02T15:22:30", "name": "[libcamera-devel,v2,06/12] libcamera: camera_configuration: Return config index", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a20eb3890d23fc65d43df5a764c06ef9d35a0866", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/9467/mbox/", "series": [ { "id": 1259, "url": "https://patchwork.libcamera.org/api/1.1/series/1259/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1259", "date": "2020-09-02T15:22:24", "name": "android: camera_device: Fix JPEG/RAW sizes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1259/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9467/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9467/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 850D3BE174\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Sep 2020 15:19:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 631AB62984;\n\tWed, 2 Sep 2020 17:19:06 +0200 (CEST)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 646A9629A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Sep 2020 17:19:05 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 46E3024000F;\n\tWed, 2 Sep 2020 15:19:04 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Sep 2020 17:22:30 +0200", "Message-Id": "<20200902152236.69770-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200902152236.69770-1-jacopo@jmondi.org>", "References": "<20200902152236.69770-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 06/12] libcamera: camera_configuration:\n\tReturn config index", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "tfiga@google.com, hiroh@google.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When adding a new StreamConfiguration to a CameraConfiguration instance\nit might be useful to know how what is the index of the newly added item\nto be able to retrieve it later.\n\nReturn the index of the newly inserted item, which corresponds to the\n0-indexed number of items in the CameraConfiguration::config_ vector,\nfrom CameraConfiguration::addConfiguration().\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/camera.h | 2 +-\n src/libcamera/camera.cpp | 5 ++++-\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 272c12c3c473..53c32afa23a5 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -39,7 +39,7 @@ public:\n \n \tvirtual ~CameraConfiguration();\n \n-\tvoid addConfiguration(const StreamConfiguration &cfg);\n+\tint addConfiguration(const StreamConfiguration &cfg);\n \tvirtual Status validate() = 0;\n \n \tStreamConfiguration &at(unsigned int index);\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 4a9c19c33cfb..9a8923620e24 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -104,10 +104,13 @@ CameraConfiguration::~CameraConfiguration()\n /**\n * \\brief Add a stream configuration to the camera configuration\n * \\param[in] cfg The stream configuration\n+ * \\return The index of the newly added stream configuration\n */\n-void CameraConfiguration::addConfiguration(const StreamConfiguration &cfg)\n+int CameraConfiguration::addConfiguration(const StreamConfiguration &cfg)\n {\n \tconfig_.push_back(cfg);\n+\n+\treturn config_.size() - 1;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v2", "06/12" ] }