Patch Detail
Show a patch.
GET /api/1.1/patches/9444/?format=api
{ "id": 9444, "url": "https://patchwork.libcamera.org/api/1.1/patches/9444/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9444/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200902104410.7569-2-david.plowman@raspberrypi.com>", "date": "2020-09-02T10:44:03", "name": "[libcamera-devel,v6,1/8] libcamera: pipeline: raspberrypi: Revert \"Set sensor default orientation before configure()\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "08438caf827d0447a41a61ceec45ce9ba27cb2e7", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9444/mbox/", "series": [ { "id": 1256, "url": "https://patchwork.libcamera.org/api/1.1/series/1256/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1256", "date": "2020-09-02T10:44:02", "name": "2D transforms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1256/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9444/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9444/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10A5CBF019\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Sep 2020 10:44:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFF3062984;\n\tWed, 2 Sep 2020 12:44:18 +0200 (CEST)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FE10628EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Sep 2020 12:44:17 +0200 (CEST)", "by mail-wr1-x42e.google.com with SMTP id m6so4727658wrn.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 02 Sep 2020 03:44:17 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tm3sm5583062wmb.26.2020.09.02.03.44.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Sep 2020 03:44:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"IgnkqGk1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Wcr7IpixxCkOcntKY+WlarwGA5RJqYNWCxkC24oHDJM=;\n\tb=IgnkqGk1vGFy8GfppWbi3c5knHObxptJfNMjIP6Vqt1IFMMZDv9vPtL+my4sU4r8/D\n\tKNHXZzrIR6Qy89bQYZ6p5kRw0QACuIdqGVvYoKOxBTA6HS7Cz6g0y6dWBg/H0obRL51M\n\tXt27lrI7o8P4xdTGYAEf4Hrur2ZTsnogkPU+RFw2DtEhX5BcXjkapeau42MGjQ2ucLgW\n\tuCa3goKi0qx2Rb0ihsA6lKvHbqMzI7fPrwzWxOwCT8vmG3NZDJAMGkyg9B4YQwM922d4\n\tu8HghiSVZ8OlAuklvI8kH+C78om3v4h9OmXAcAKfu9kh/P2FdsC98vR+dwBMooMlvw9O\n\tdMxw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Wcr7IpixxCkOcntKY+WlarwGA5RJqYNWCxkC24oHDJM=;\n\tb=BaKUV2Z6qvFUC2VkeUbvczs5UbNU60JZjBs0J6gc45XPojQwXUQ5QurluIb7ur2AcG\n\tnuUvAY4oj4kB6Y/fyXxtQjb1VwXZYYUYkJ5Aith3cwiZQ6kPXkGlZs6OLWeVyK0uQV7j\n\tmnCzDU1BNelA7brntG9x0HtdLe2ZP5rcTp0B4tE19lIcgAiQgdD/Sd/WkRDIxtJA4qCn\n\tVuW/r+cGzDhb30OR8nMd2UeZMwtSys0fCGVkGgyNDQgNUDslVLrSHM/Mdu7l4md5aUnc\n\t3nr/0MlhsPZGxCUF2iN6Q6w/GdXNWNkqKowabvcVf9GlvpKbP19fdX9KL6ZbAVLl/2B/\n\tz2Yw==", "X-Gm-Message-State": "AOAM5338oCImUSkIgoGf0y4ho/vwhpPMCOl9l1Bon/UmK4SZj90/goE2\n\taWzCkX+HHnS4k9XpipKGGPnTzicMzIrWTA==", "X-Google-Smtp-Source": "ABdhPJze67LxXGmKoYJwWq3dJQLLm7KqUP9un+DF84NgFyGWcPMsMc7lH2kb2n13Q/DyTj11dSMe2w==", "X-Received": "by 2002:a5d:458e:: with SMTP id p14mr6631679wrq.61.1599043456463;\n\tWed, 02 Sep 2020 03:44:16 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Sep 2020 11:44:03 +0100", "Message-Id": "<20200902104410.7569-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200902104410.7569-1-david.plowman@raspberrypi.com>", "References": "<20200902104410.7569-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 1/8] libcamera: pipeline: raspberrypi:\n\tRevert \"Set sensor default orientation before configure()\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This reverts commit 1e8c91b65695449c5246d17ba7dc439c8058b781.\n\nNow that we shall be implementing application-defined 2D transforms\nit's no longer possible to set the sensor orientation so early on. We\nhave to wait until we have the CameraConfiguration object as that's\nwhere the application puts its choice of transform.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ce43af3..f78b73e 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -962,13 +962,6 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t/* Initialize the camera properties. */\n \tdata->properties_ = data->sensor_->properties();\n \n-\t/* Configure the H/V flip controls based on the sensor rotation. */\n-\tControlList ctrls(data->unicam_[Unicam::Image].dev()->controls());\n-\tint32_t rotation = data->properties_.get(properties::Rotation);\n-\tctrls.set(V4L2_CID_HFLIP, static_cast<int32_t>(!!rotation));\n-\tctrls.set(V4L2_CID_VFLIP, static_cast<int32_t>(!!rotation));\n-\tdata->unicam_[Unicam::Image].dev()->setControls(&ctrls);\n-\n \t/*\n \t * List the available output streams.\n \t * Currently cannot do Unicam streams!\n@@ -1173,6 +1166,13 @@ int RPiCameraData::configureIPA()\n \t\t\t\t\t { V4L2_CID_EXPOSURE, result.data[1] } });\n \t\t\tsensorMetadata_ = result.data[2];\n \t\t}\n+\n+\t\t/* Configure the H/V flip controls based on the sensor rotation. */\n+\t\tControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n+\t\tint32_t rotation = sensor_->properties().get(properties::Rotation);\n+\t\tctrls.set(V4L2_CID_HFLIP, static_cast<int32_t>(!!rotation));\n+\t\tctrls.set(V4L2_CID_VFLIP, static_cast<int32_t>(!!rotation));\n+\t\tunicam_[Unicam::Image].dev()->setControls(&ctrls);\n \t}\n \n \tif (result.operation & RPI_IPA_CONFIG_SENSOR) {\n", "prefixes": [ "libcamera-devel", "v6", "1/8" ] }