Patch Detail
Show a patch.
GET /api/1.1/patches/9416/?format=api
{ "id": 9416, "url": "https://patchwork.libcamera.org/api/1.1/patches/9416/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9416/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200828144110.17303-2-david.plowman@raspberrypi.com>", "date": "2020-08-28T14:41:04", "name": "[libcamera-devel,v4,1/7] libcamera: pipeline: raspberrypi: Revert \"Set sensor default orientation before configure()\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "08438caf827d0447a41a61ceec45ce9ba27cb2e7", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9416/mbox/", "series": [ { "id": 1250, "url": "https://patchwork.libcamera.org/api/1.1/series/1250/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1250", "date": "2020-08-28T14:41:03", "name": "2D transforms", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1250/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9416/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9416/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BCBABF019\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Aug 2020 14:41:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 003DF628F3;\n\tFri, 28 Aug 2020 16:41:18 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EC326037B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Aug 2020 16:41:17 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id t14so1131711wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Aug 2020 07:41:17 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ts12sm2493724wmj.26.2020.08.28.07.41.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 28 Aug 2020 07:41:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"EbbwXOgh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uSc5m7UZr/nBlCCvcn3e9RFGm3q8lICTUphQChO2UKs=;\n\tb=EbbwXOgh7mvpg8TRZU9V00by8tY4q1ISdQRzHZYGJRQMGRqYT9Xx0PHp6oGFDf/Uwo\n\t2mmhe3dCFJx4bNrka4K8PcgRvQzyhPjdiMKJhzNCgcEBPH9NO5Ai/vH2r8+LQzzIZP12\n\t78juB4WiSl+aFWmqdMSHxZAJlulVyRiCE/UICWRMU8cDphRi358oGGb9bIA4sgS7FmNy\n\tIOgaVwpbvxqCcCkkeatV1aJGXuKzCDk3kgcTt/8yto1q4iRm1i27kFCKvzt2u8h4uxip\n\tz8Q8gaYyXr0/Nivt6JjptANxdioDsVeAhy+iWTN2qEgMZT2CoDys0EmdD7jBGNTyYqd9\n\tr6YA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uSc5m7UZr/nBlCCvcn3e9RFGm3q8lICTUphQChO2UKs=;\n\tb=Q7jn6j4cBiWI6GOhAg/dw0hTLq0IoFcPQ8k7hX0hbGxgyDkbTduD8o94ySzZ/fj7Mh\n\tK0EEVNayBDSLRENRgGgeOmfjwCvzgclTGrHaSvvHvPojn9nCMO8+L0Dsce/G2UdOlB7y\n\tWw4aJw7k70HbhTr/qBUAQKzxW6Fv8rBQAZVsUc/qfvUiV8bpplwLqdYhW9V4Q2Axsm1E\n\toXxhfPBHxoFiF5g7Xtd7CyatPOGQLURhaiiPr+xn38F4/o186RXw6DSyS7MDvi9/lcBO\n\tUZLD2IpX4FcAj+MueXwCeXMFuxuiU5iWojAwrZt+JJW7r5OqEIxFPPVqro9hxo6nF0zi\n\tZWFw==", "X-Gm-Message-State": "AOAM5319X5ISdwmDK9NhGlMEm3yQk+wFgen30Jg7ytwcmTyI6XgLIjyG\n\tTKtFKnxzNYkbqC89MnurBxpgH9Ey7fg56A==", "X-Google-Smtp-Source": "ABdhPJzeQJSBppjDipYMzWLIILRrQiR258LfjjI+Mkn/boxG/yPFpLTyEos4UKsSWlrYsFnbhLTAwA==", "X-Received": "by 2002:a1c:b143:: with SMTP id a64mr1871961wmf.43.1598625676740;\n\tFri, 28 Aug 2020 07:41:16 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 28 Aug 2020 15:41:04 +0100", "Message-Id": "<20200828144110.17303-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200828144110.17303-1-david.plowman@raspberrypi.com>", "References": "<20200828144110.17303-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 1/7] libcamera: pipeline: raspberrypi:\n\tRevert \"Set sensor default orientation before configure()\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This reverts commit 1e8c91b65695449c5246d17ba7dc439c8058b781.\n\nNow that we shall be implementing application-defined 2D transforms\nit's no longer possible to set the sensor orientation so early on. We\nhave to wait until we have the CameraConfiguration object as that's\nwhere the application puts its choice of transform.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c1451e7..42c9caa 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -960,13 +960,6 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t/* Initialize the camera properties. */\n \tdata->properties_ = data->sensor_->properties();\n \n-\t/* Configure the H/V flip controls based on the sensor rotation. */\n-\tControlList ctrls(data->unicam_[Unicam::Image].dev()->controls());\n-\tint32_t rotation = data->properties_.get(properties::Rotation);\n-\tctrls.set(V4L2_CID_HFLIP, static_cast<int32_t>(!!rotation));\n-\tctrls.set(V4L2_CID_VFLIP, static_cast<int32_t>(!!rotation));\n-\tdata->unicam_[Unicam::Image].dev()->setControls(&ctrls);\n-\n \t/*\n \t * List the available output streams.\n \t * Currently cannot do Unicam streams!\n@@ -1171,6 +1164,13 @@ int RPiCameraData::configureIPA()\n \t\t\t\t\t { V4L2_CID_EXPOSURE, result.data[1] } });\n \t\t\tsensorMetadata_ = result.data[2];\n \t\t}\n+\n+\t\t/* Configure the H/V flip controls based on the sensor rotation. */\n+\t\tControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n+\t\tint32_t rotation = sensor_->properties().get(properties::Rotation);\n+\t\tctrls.set(V4L2_CID_HFLIP, static_cast<int32_t>(!!rotation));\n+\t\tctrls.set(V4L2_CID_VFLIP, static_cast<int32_t>(!!rotation));\n+\t\tunicam_[Unicam::Image].dev()->setControls(&ctrls);\n \t}\n \n \tif (result.operation & RPI_IPA_CONFIG_SENSOR) {\n", "prefixes": [ "libcamera-devel", "v4", "1/7" ] }