Patch Detail
Show a patch.
GET /api/1.1/patches/9399/?format=api
{ "id": 9399, "url": "https://patchwork.libcamera.org/api/1.1/patches/9399/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9399/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200826110926.67192-16-paul.elder@ideasonboard.com>", "date": "2020-08-26T11:09:24", "name": "[libcamera-devel,RFC,15/17] libcamera: IPAInterface: make ipaCreate return IPAInterface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ec06138c43a470490cf0a84b97b98c5a9c60c3ba", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9399/mbox/", "series": [ { "id": 1243, "url": "https://patchwork.libcamera.org/api/1.1/series/1243/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1243", "date": "2020-08-26T11:09:09", "name": "[libcamera-devel,RFC,01/17] IPA: IPC: raspberrypi: Add data definition and generated header", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1243/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9399/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9399/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9FA2BD87E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Aug 2020 11:10:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A63386290A;\n\tWed, 26 Aug 2020 13:10:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54902628DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Aug 2020 13:10:24 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8745A53C;\n\tWed, 26 Aug 2020 13:10:22 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JBpHAgEN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598440224;\n\tbh=OcghZ9l+sP+9kXxJlJJSLmso5fjqijVhZW9Op5VXJ4c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JBpHAgENY9xXP8/l48ov7njNYebiMkPzdALZhopnQwunCR8vLXTlFmKbVWb4GFS0+\n\tfoeTA+CY4Hvq6y46rs5Y3UifFgAa/ijTIFBpUibQoULgCcZ/ZyVaSwFrwvhymVhleW\n\tR3QWFVi0okG99PPYe+mBfPmZkLBUbBxXlNJr7Qhg=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 26 Aug 2020 20:09:24 +0900", "Message-Id": "<20200826110926.67192-16-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200826110926.67192-1-paul.elder@ideasonboard.com>", "References": "<20200826110926.67192-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC PATCH 15/17] libcamera: IPAInterface: make\n\tipaCreate return IPAInterface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the new IPC infrastructure, we no longer need the C interface as\nprovided by struct ipa_context. Make ipaCreate return IPAinterface.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/ipa/ipa_interface.h | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex cbe325ea..6efe2e99 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -110,8 +110,6 @@ struct ipa_context_ops {\n \t\t\t const struct ipa_operation_data *data);\n };\n \n-struct ipa_context *ipaCreate();\n-\n #ifdef __cplusplus\n }\n \n@@ -154,6 +152,11 @@ public:\n };\n \n } /* namespace libcamera */\n+\n+extern \"C\" {\n+libcamera::IPAInterface *ipaCreate();\n+}\n+\n #endif\n \n #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */\n", "prefixes": [ "libcamera-devel", "RFC", "15/17" ] }