Patch Detail
Show a patch.
GET /api/1.1/patches/9365/?format=api
{ "id": 9365, "url": "https://patchwork.libcamera.org/api/1.1/patches/9365/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9365/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200822160502.11932-1-laurent.pinchart@ideasonboard.com>", "date": "2020-08-22T16:05:02", "name": "[libcamera-devel] libcamera: Remove void specifier for functions that take no arguments", "commit_ref": "f976eb5cb63f0c5e802dbd4faefa82eb927c2f47", "pull_url": null, "state": "accepted", "archived": false, "hash": "48f4bf46ac1169637f3f1b2f21e576db69ca9932", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9365/mbox/", "series": [ { "id": 1234, "url": "https://patchwork.libcamera.org/api/1.1/series/1234/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1234", "date": "2020-08-22T16:05:02", "name": "[libcamera-devel] libcamera: Remove void specifier for functions that take no arguments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1234/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9365/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9365/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 993D6BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 22 Aug 2020 16:05:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 206EE62710;\n\tSat, 22 Aug 2020 18:05:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F7E061EA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Aug 2020 18:05:25 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2E1B29E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Aug 2020 18:05:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oskF9VeC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598112325;\n\tbh=MoHyDFt04e/W1Yqce1hHZPqK2GuJz8uEi+ZrEZWajUo=;\n\th=From:To:Subject:Date:From;\n\tb=oskF9VeCL6ikubHYrFLX6F8M4zl9Y0oicX9QCB+ElyOdtJB0zSyfyNjHKSmKZzYFo\n\tBWtM3+ufcfkRU1F/x+lNfF2OSh9SyGaWx81j+kIuSaULNRo+OOUckXNWSLa4NF5PqT\n\tpDiqa7c3tIIOdgtRwAy9kdFGUOLN7dheFifbnoIU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 22 Aug 2020 19:05:02 +0300", "Message-Id": "<20200822160502.11932-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: Remove void specifier for\n\tfunctions that take no arguments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In C++, unlike in C, a function that takes no argument doesn't need to\nspecify void in the arguments list. Drop the unnecessary specifiers.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/ipa_module.h | 2 +-\n src/android/camera3_hal.cpp | 2 +-\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n src/gstreamer/gstlibcamerapad.cpp | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\nindex 6355671fd861..c2df2476b2ff 100644\n--- a/include/libcamera/internal/ipa_module.h\n+++ b/include/libcamera/internal/ipa_module.h\n@@ -52,7 +52,7 @@ private:\n \tbool loaded_;\n \n \tvoid *dlHandle_;\n-\ttypedef struct ipa_context *(*IPAIntfFactory)(void);\n+\ttypedef struct ipa_context *(*IPAIntfFactory)();\n \tIPAIntfFactory ipaCreate_;\n };\n \ndiff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\nindex 716e36c72b83..decaf59e6915 100644\n--- a/src/android/camera3_hal.cpp\n+++ b/src/android/camera3_hal.cpp\n@@ -22,7 +22,7 @@ static CameraHalManager cameraManager;\n * Android Camera HAL callbacks\n */\n \n-static int hal_get_number_of_cameras(void)\n+static int hal_get_number_of_cameras()\n {\n \treturn cameraManager.numCameras();\n }\ndiff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex 1d5959c076cb..78ded4022bda 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -70,7 +70,7 @@ FrameWrap::~FrameWrap()\n \t}\n }\n \n-GQuark FrameWrap::getQuark(void)\n+GQuark FrameWrap::getQuark()\n {\n \tstatic gsize frame_quark = 0;\n \ndiff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex e184495aed5a..9f3e2be53b66 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -84,7 +84,7 @@ gst_libcamera_pad_init(GstLibcameraPad *self)\n }\n \n static GType\n-gst_libcamera_stream_role_get_type(void)\n+gst_libcamera_stream_role_get_type()\n {\n \tstatic GType type = 0;\n \tstatic const GEnumValue values[] = {\n", "prefixes": [ "libcamera-devel" ] }