Patch Detail
Show a patch.
GET /api/1.1/patches/9341/?format=api
{ "id": 9341, "url": "https://patchwork.libcamera.org/api/1.1/patches/9341/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9341/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200821064023.12722-1-email@uajain.com>", "date": "2020-08-21T06:40:28", "name": "[libcamera-devel] libcamera: object: Fix deleteLater() sample code", "commit_ref": "cfb5eb31f6a5194bcab4d0c3f636ebf69431b18e", "pull_url": null, "state": "accepted", "archived": false, "hash": "9cceec9c24d3be6bfd7097a827837f9a6575c732", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9341/mbox/", "series": [ { "id": 1226, "url": "https://patchwork.libcamera.org/api/1.1/series/1226/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1226", "date": "2020-08-21T06:40:28", "name": "[libcamera-devel] libcamera: object: Fix deleteLater() sample code", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1226/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9341/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9341/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22E0BBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 21 Aug 2020 06:40:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71ABE61F7B;\n\tFri, 21 Aug 2020 08:40:32 +0200 (CEST)", "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D7136037D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Aug 2020 08:40:29 +0200 (CEST)", "by filterdrecv-p3iad2-86945d9569-wzrpx with SMTP id\n\tfilterdrecv-p3iad2-86945d9569-wzrpx-18-5F3F6C5C-C\n\t2020-08-21 06:40:28.418108887 +0000 UTC m=+45444.000540781", "from mail.uajain.com (unknown)\n\tby ismtpd0008p1maa1.sendgrid.net (SG) with ESMTP id\n\tot5Pi1K_RrWWo2wg9HuzaA for <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Aug 2020 06:40:27.671 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"aiJgJemg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=/ql8XLgFqDrItUWI1WJnCgf8pmcuLN/9lUXjIQVt8Zk=;\n\tb=aiJgJemg+2zSygcNE3GsZqOeopWsGOSh2qoR+QsDi6UKLBjdgELWb88FmRTSw8DwuXav\n\tJ5k8TW9xmffj25v/v4hbPEXwa99J1GlWvXzMpw6T09KtOPFuDCNcUhS4skFvTZLszm+jU6\n\t/erRWzHKYDYfpEgJ8BJMrVASTHPCjITBg=", "From": "Umang Jain <email@uajain.com>", "Date": "Fri, 21 Aug 2020 06:40:28 +0000 (UTC)", "Message-Id": "<20200821064023.12722-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcHcG1g99dnq0SJ9KzJgHEPgZALHBgBaIAURUQGiQVqrMFtLKDvT4WhEPPTuOhVQfgRC90NGhd+omijUGpHhVgXdWa/yUi6qKQxnIvWGi9YFuk9abFZcOjMtKZ3x155LXktiyD06D9QylIOCpoFz7SmGO5QakteCT1GFmW7POk3JSzqL7yyOks+GOePB2XX01o0GY+4GNJHgWGaQIZWjjozg==", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [PATCH] libcamera: object: Fix deleteLater()\n\tsample code", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of using \"delete obj\" in the custom deleter of the shared\nobject, we should have been using the \"obj->deleteLater()\" to explain\nhow the deleteLater() API should be used in practice.\n\nFixes: 9558886f7a85 (\"libcamera: object: Add deleteLater() support)\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/libcamera/object.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\nindex 647ccda..cd83c68 100644\n--- a/src/libcamera/object.cpp\n+++ b/src/libcamera/object.cpp\n@@ -125,7 +125,7 @@ Object::~Object()\n * struct Deleter : std::default_delete<MyObject> {\n * void operator()(MyObject *obj)\n * {\n- * delete obj;\n+ * obj->deleteLater();\n * }\n * };\n *\n", "prefixes": [ "libcamera-devel" ] }