Patch Detail
Show a patch.
GET /api/1.1/patches/9334/?format=api
{ "id": 9334, "url": "https://patchwork.libcamera.org/api/1.1/patches/9334/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9334/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200817202629.4277-3-email@uajain.com>", "date": "2020-08-17T20:26:38", "name": "[libcamera-devel,v3,2/5] android: camera_hal_manager: Set camera module callbacks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c391f39e0d7b7932f130c994913327255af94a86", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9334/mbox/", "series": [ { "id": 1224, "url": "https://patchwork.libcamera.org/api/1.1/series/1224/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1224", "date": "2020-08-17T20:26:35", "name": "android: Camera hotplug support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1224/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9334/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9334/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 555B7BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Aug 2020 20:26:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D5B161992;\n\tMon, 17 Aug 2020 22:26:45 +0200 (CEST)", "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1244616B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Aug 2020 22:26:40 +0200 (CEST)", "by filterdrecv-p3las1-5785d94c6b-nwwmr with SMTP id\n\tfilterdrecv-p3las1-5785d94c6b-nwwmr-20-5F3AE7FD-59\n\t2020-08-17 20:26:38.073478137 +0000 UTC m=+359831.740488720", "from mail.uajain.com (unknown)\n\tby ismtpd0004p1maa1.sendgrid.net (SG) with ESMTP\n\tid LtHSEsxLQ92TgN7RevA2LQ Mon, 17 Aug 2020 20:26:37.250 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"LMIYMhzi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=WlyI45ayfL5lw/SJQXCZOK/kp6kF5E1uzpkjn96L88U=;\n\tb=LMIYMhziUC8Rxfqbn/sR4rSHQA8/ldEiqdCnXLW0dokXYpstnn3yCPlDlQ8Omy3T1PUA\n\tv6CaV0Ch2SNCsY+qZPWNJIlM/0chQvDmOh8R6Kv1AlVX8yDdTn6kXiqPTk+Deiu+O0VnkU\n\tmBTmCuBzb75A8haOZBExmLADA/DjRy0vg=", "From": "Umang Jain <email@uajain.com>", "Date": "Mon, 17 Aug 2020 20:26:38 +0000 (UTC)", "Message-Id": "<20200817202629.4277-3-email@uajain.com>", "In-Reply-To": "<20200817202629.4277-1-email@uajain.com>", "References": "<20200817202629.4277-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcQ/i1ji5k4eTSSnQ1oTeZ4t6d2b9GmSo6yY9OJZQOVguTKvxACBn5rSs0UFG7sXgVj0oQCsUpQifx+/Ee/ukgGyAFfPq2xqRvPP4uVzgvxHmTaWoAwN76VrZIV9PcSkSZpjYSMW2wZwRTsWj6xGJCnW1WVvcRMC+0OnsSCaHuVe4XtMk2gIJAd2xwEim/85nDI3LhGorlyWcelSQcizuwUw==", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [PATCH v3 2/5] android: camera_hal_manager: Set\n\tcamera module callbacks", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "camera_module_callbacks are invoked to inform the framework about\nthe events occurring module-wide. Allow to set these callbacks in\ncamera_hal_manager as this will be used to integration camera hotplug\nsupport via camera_module_callbacks::camera_device_status_change in\nsubsequent commit.\n\nSigned-off-by: Umang Jain <email@uajain.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/camera3_hal.cpp | 2 ++\n src/android/camera_hal_manager.cpp | 5 +++++\n src/android/camera_hal_manager.h | 3 +++\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\nindex 716e36c..c2cba29 100644\n--- a/src/android/camera3_hal.cpp\n+++ b/src/android/camera3_hal.cpp\n@@ -34,6 +34,8 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n \n static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n {\n+\tcameraManager.setCallbacks(callbacks);\n+\n \treturn 0;\n }\n \ndiff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 02b6418..3d6d2b4 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -120,3 +120,8 @@ int CameraHalManager::getCameraInfo(unsigned int id, struct camera_info *info)\n \n \treturn 0;\n }\n+\n+void CameraHalManager::setCallbacks(const camera_module_callbacks_t *callbacks)\n+{\n+\tcallbacks_ = callbacks;\n+}\ndiff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 0619037..a582f04 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -10,6 +10,7 @@\n #include <stddef.h>\n #include <vector>\n \n+#include <hardware/camera_common.h>\n #include <hardware/hardware.h>\n #include <system/camera_metadata.h>\n \n@@ -29,10 +30,12 @@ public:\n \n \tunsigned int numCameras() const;\n \tint getCameraInfo(unsigned int id, struct camera_info *info);\n+\tvoid setCallbacks(const camera_module_callbacks_t *callbacks);\n \n private:\n \tlibcamera::CameraManager *cameraManager_;\n \n+\tconst camera_module_callbacks_t *callbacks_;\n \tstd::vector<std::unique_ptr<CameraDevice>> cameras_;\n };\n \n", "prefixes": [ "libcamera-devel", "v3", "2/5" ] }