Patch Detail
Show a patch.
GET /api/1.1/patches/9322/?format=api
{ "id": 9322, "url": "https://patchwork.libcamera.org/api/1.1/patches/9322/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9322/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200813223722.4050835-7-niklas.soderlund@ragnatech.se>", "date": "2020-08-13T22:37:21", "name": "[libcamera-devel,v4,6/7] cam: Print user-friendly camera names", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "17ab211f9d83b30aadc0c2d3a75dafe48ad62b59", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9322/mbox/", "series": [ { "id": 1219, "url": "https://patchwork.libcamera.org/api/1.1/series/1219/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1219", "date": "2020-08-13T22:37:15", "name": "libcamera: Allow for user-friendly names in applications", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1219/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9322/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9322/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 828C6BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Aug 2020 22:37:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A8276160D;\n\tFri, 14 Aug 2020 00:37:43 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A0F861618\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Aug 2020 00:37:39 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 973766f4-ddb5-11ea-a39b-005056917f90;\n\tFri, 14 Aug 2020 00:37:38 +0200 (CEST)" ], "X-Halon-ID": "973766f4-ddb5-11ea-a39b-005056917f90", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 14 Aug 2020 00:37:21 +0200", "Message-Id": "<20200813223722.4050835-7-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200813223722.4050835-1-niklas.soderlund@ragnatech.se>", "References": "<20200813223722.4050835-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 6/7] cam: Print user-friendly camera\n\tnames", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of only printing the camera ID which is not intended for humans\nto read and parse create a more user friendly string when printing\ncamera names. The ID is still printed as it is one option used to select\ncamera using the --camera option.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n* Changes since v1\n- Only print user-friendly names when listing cameras.\n- Update format of user-friendly names printed.\n- Update commit message.\n---\n src/cam/main.cpp | 33 ++++++++++++++++++++++++++++++++-\n 1 file changed, 32 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex cc3facd5a5b22092..57f8c79b21090ece 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -21,6 +21,37 @@\n \n using namespace libcamera;\n \n+std::string cameraName(const Camera *camera)\n+{\n+\tconst ControlList &props = camera->properties();\n+\tstd::string name;\n+\n+\t/* Use camera model as fallback name if available. */\n+\tif (props.contains(properties::Model))\n+\t\tname = props.get(properties::Model);\n+\telse\n+\t\tname = \"Unknown camera\";\n+\n+\t/* If camera location is available use it as highest priority name. */\n+\tif (props.contains(properties::Location)) {\n+\t\tswitch (props.get(properties::Location)) {\n+\t\tcase properties::CameraLocationFront:\n+\t\t\tname = \"Internal front camera\";\n+\t\t\tbreak;\n+\t\tcase properties::CameraLocationBack:\n+\t\t\tname = \"Internal back camera\";\n+\t\t\tbreak;\n+\t\tcase properties::CameraLocationExternal:\n+\t\t\tname = \"External camera\";\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tname += \" (\" + camera->id() + \")\";\n+\n+\treturn name;\n+}\n+\n class CamApp\n {\n public:\n@@ -340,7 +371,7 @@ int CamApp::run()\n \n \t\tunsigned int index = 1;\n \t\tfor (const std::shared_ptr<Camera> &cam : cm_->cameras()) {\n-\t\t\tstd::cout << index << \": \" << cam->id() << std::endl;\n+\t\t\tstd::cout << index << \": \" << cameraName(cam.get()) << std::endl;\n \t\t\tindex++;\n \t\t}\n \t}\n", "prefixes": [ "libcamera-devel", "v4", "6/7" ] }