Patch Detail
Show a patch.
GET /api/1.1/patches/9280/?format=api
{ "id": 9280, "url": "https://patchwork.libcamera.org/api/1.1/patches/9280/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9280/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200810164306.1472692-3-niklas.soderlund@ragnatech.se>", "date": "2020-08-10T16:43:01", "name": "[libcamera-devel,v2,2/7] libcamera: utils: Add method to strip Unicode characters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "54c4a35b90f457d9eb316427f443a5e03e65d0c0", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9280/mbox/", "series": [ { "id": 1212, "url": "https://patchwork.libcamera.org/api/1.1/series/1212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1212", "date": "2020-08-10T16:42:59", "name": "libcamera: Generate unique and stable camera names", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9280/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9280/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15518BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Aug 2020 16:43:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D958C610E6;\n\tMon, 10 Aug 2020 18:43:24 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7854460DCA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Aug 2020 18:43:22 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 99ec37c1-db28-11ea-a39b-005056917f90;\n\tMon, 10 Aug 2020 18:43:21 +0200 (CEST)" ], "X-Halon-ID": "99ec37c1-db28-11ea-a39b-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 10 Aug 2020 18:43:01 +0200", "Message-Id": "<20200810164306.1472692-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200810164306.1472692-1-niklas.soderlund@ragnatech.se>", "References": "<20200810164306.1472692-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/7] libcamera: utils: Add method to\n\tstrip Unicode characters", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add method that strips non-ASCII characters from a string.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/internal/utils.h | 2 ++\n src/libcamera/utils.cpp | 21 +++++++++++++++++++++\n 2 files changed, 23 insertions(+)", "diff": "diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\nindex 45cd6f120c51586b..5bfd2a8782dbd623 100644\n--- a/include/libcamera/internal/utils.h\n+++ b/include/libcamera/internal/utils.h\n@@ -197,6 +197,8 @@ private:\n \n details::StringSplitter split(const std::string &str, const std::string &delim);\n \n+std::string stripUnicode(const std::string &str);\n+\n std::string libcameraBuildPath();\n std::string libcameraSourcePath();\n \ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex 615df46ac142a2a9..041fdc91a0a35277 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -342,6 +342,27 @@ details::StringSplitter split(const std::string &str, const std::string &delim)\n \treturn details::StringSplitter(str, delim);\n }\n \n+/**\n+ * \\brief Strip all Unicode characters from a string\n+ * \\param[in] str The string to strip\n+ *\n+ * Strip all non-ASCII characters form a string. An Unicode character that spans\n+ * multiple bytes (and therefor is not also an ASCII character) may be\n+ * identified by the fact that its most significant bit is always set.\n+ *\n+ * \\todo When switching to C++ 20 use std::remove_if.\n+ *\n+ * \\return An ASCII string\n+ */\n+std::string stripUnicode(const std::string &str)\n+{\n+\tstd::string ret;\n+\tfor (const char &c : str)\n+\t\tif (!(c & 0x80))\n+\t\t\tret += c;\n+\treturn ret;\n+}\n+\n /**\n * \\brief Check if libcamera is installed or not\n *\n", "prefixes": [ "libcamera-devel", "v2", "2/7" ] }