Patch Detail
Show a patch.
GET /api/1.1/patches/9264/?format=api
{ "id": 9264, "url": "https://patchwork.libcamera.org/api/1.1/patches/9264/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9264/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200806163639.12971-2-david.plowman@raspberrypi.com>", "date": "2020-08-06T16:36:35", "name": "[libcamera-devel,v2,1/5] libcamera: Add Transform enum to represet 2d plane transforms.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "19c4d78c4a92fb6abd589c922470502aa8db44f9", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9264/mbox/", "series": [ { "id": 1208, "url": "https://patchwork.libcamera.org/api/1.1/series/1208/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1208", "date": "2020-08-06T16:36:34", "name": "Transform implementation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1208/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9264/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9264/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D164ABD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 6 Aug 2020 16:36:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EF5260552;\n\tThu, 6 Aug 2020 18:36:52 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E77860392\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 6 Aug 2020 18:36:50 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id z18so41057293wrm.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 06 Aug 2020 09:36:50 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\te5sm7405076wrc.37.2020.08.06.09.36.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 06 Aug 2020 09:36:48 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HER4ZhkA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+ls6Qseo3A4UXMXVxoS7O1JGhZWS6PpmWFM/xwwZuck=;\n\tb=HER4ZhkAT119zwLLMeGX368pTs9Hd5WGps66w6WFdr73exQq9oZJrsKGR1Z0RK3c7p\n\tOtQyHvQIkXQtvspi60ADO6k8bqy+vcUBctGu8M3f3/RlOnZQmSCW4bOXlOl5DKGDvdDd\n\t/am3hNTX6SpD/kZEk/qkH4tLhgeDBcLRPFSN9kRaowK/GHxducaZfDzWjbFBu+y8Kn0G\n\tBKDSTlbAty4yQwHYBFjcaZNHVwAflE1aeEly7XnmVEl16GYnM6RfpgcuSjvq8Cvls7Xt\n\tu6bY8CpfPhw+F6gbp2ACqL1enDWzsZupGoqzsY00mJeyNyO1XGDNauLNgqtznQXdK4o6\n\tVa1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+ls6Qseo3A4UXMXVxoS7O1JGhZWS6PpmWFM/xwwZuck=;\n\tb=msu+s7eTytiL4P9XfhoyRfKA7ixAu2n0v08cLWxSjRnQofT2rMfe/xYqpUJGyPIoGG\n\t2SdErbs1xTqfY4clVE8Z8oS0YsimyH5BnA2+zFSb1ToXuSKrr5yqiqoOppMl/Y0SZeAq\n\trtd27ijsKVYIvyFJ3fM2IfzVkEsy3X+/yEIJYCe/U5SiJxxw+8Y3xSGLlVvS9CRrzx+8\n\tBl1HMv+XIdrNX1JOm18B1hJT/xTSd78dQua56799KnKLAzcVBAvUCQchLjVYTfz2SJ1w\n\tIgEFOy0R8WLmpxRFEOs4p+uJx+2K/TED7xZxNOEjiWIy7Yr1ijbzxpavqbDH91WSaRzo\n\tq1dQ==", "X-Gm-Message-State": "AOAM530oDWom2vBn/Qdi0NReL7Ykf5bBOyoPVY/mJ5IiE0pZ75H/7n8K\n\t6iP8fFYilNhJ+BFMlZT+Ot6YLghfg/+SDg==", "X-Google-Smtp-Source": "ABdhPJwoaOnG5bMjS50sAkUhjIw3B7Ol22iAlieQzEBsyKUC3V5Vyg2xQaCiIN8vUvZkRrTq05yvAQ==", "X-Received": "by 2002:adf:82f6:: with SMTP id 109mr8976993wrc.25.1596731809059;\n\tThu, 06 Aug 2020 09:36:49 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 6 Aug 2020 17:36:35 +0100", "Message-Id": "<20200806163639.12971-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200806163639.12971-1-david.plowman@raspberrypi.com>", "References": "<20200806163639.12971-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/5] libcamera: Add Transform enum to\n\trepreset 2d plane transforms.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We implement 2d transforms as an enum class with 8 elements,\nconsisting of the usual 2d plane transformations (flips, rotations\netc.).\n\nThe transform is made up of 3 bits, indicating whether the transform\nincludes: a transpose, a horizontal flip (mirror) and a vertical flip.\n---\n include/libcamera/meson.build | 1 +\n include/libcamera/transform.h | 58 ++++++++++++++++++++++++\n src/libcamera/meson.build | 1 +\n src/libcamera/transform.cpp | 83 +++++++++++++++++++++++++++++++++++\n 4 files changed, 143 insertions(+)\n create mode 100644 include/libcamera/transform.h\n create mode 100644 src/libcamera/transform.cpp", "diff": "diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex cdb8e03..7fae5e5 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -19,6 +19,7 @@ libcamera_public_headers = files([\n 'span.h',\n 'stream.h',\n 'timer.h',\n+ 'transform.h',\n ])\n \n include_dir = join_paths(libcamera_include_dir, 'libcamera')\ndiff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\nnew file mode 100644\nindex 0000000..658beb9\n--- /dev/null\n+++ b/include/libcamera/transform.h\n@@ -0,0 +1,58 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2020, Raspberry Pi (Trading) Limited\n+ *\n+ * transform.h - Implementation of 2d plane transforms\n+ */\n+\n+#ifndef __LIBCAMERA_TRANSFORM_H__\n+#define __LIBCAMERA_TRANSFORM_H__\n+\n+#include <string>\n+\n+namespace libcamera {\n+\n+enum class Transform : int {\n+\tIdentity = 0,\n+\tRot0 = Identity,\n+\tHFlip = 1,\n+\tVFlip = 2,\n+\tHVFlip = HFlip | VFlip,\n+\tRot180 = HVFlip,\n+\tTranspose = 4,\n+\tRot270 = HFlip | Transpose,\n+\tRot90 = VFlip | Transpose,\n+\tRot180Transpose = HFlip | VFlip | Transpose\n+};\n+\n+constexpr Transform operator&(Transform t0, Transform t1)\n+{\n+\treturn static_cast<Transform>(static_cast<int>(t0) & static_cast<int>(t1));\n+}\n+\n+constexpr Transform operator|(Transform t0, Transform t1)\n+{\n+\treturn static_cast<Transform>(static_cast<int>(t0) | static_cast<int>(t1));\n+}\n+\n+constexpr Transform operator^(Transform t0, Transform t1)\n+{\n+\treturn static_cast<Transform>(static_cast<int>(t0) ^ static_cast<int>(t1));\n+}\n+\n+Transform operator*(Transform t0, Transform t1);\n+\n+Transform operator-(Transform t);\n+\n+constexpr bool operator!(Transform t)\n+{\n+\treturn t == Transform::Identity;\n+}\n+\n+Transform transformFromRotation(int angle, bool *success = nullptr);\n+\n+std::string transformToString(Transform t);\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_TRANSFORM_H__ */\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex bada45b..b46247d 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -44,6 +44,7 @@ libcamera_sources = files([\n 'sysfs.cpp',\n 'thread.cpp',\n 'timer.cpp',\n+ 'transform.cpp',\n 'utils.cpp',\n 'v4l2_controls.cpp',\n 'v4l2_device.cpp',\ndiff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp\nnew file mode 100644\nindex 0000000..5f00a5c\n--- /dev/null\n+++ b/src/libcamera/transform.cpp\n@@ -0,0 +1,83 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2020, Raspberry Pi (Trading) Limited\n+ *\n+ * transform.cpp - implementation of 2d plane transforms.\n+ */\n+\n+#include <libcamera/transform.h>\n+\n+/**\n+ * \\file transform.h\n+ * \\brief Enum to represent a 2d plane transforms.\n+ */\n+\n+namespace libcamera {\n+\n+Transform operator*(Transform t0, Transform t1)\n+{\n+\t/*\n+\t * Reorder the operations so that we imagine doing t1's transpose\n+\t * (if any) after t0's flips. The effect is to swap t0's hflips for\n+\t * vflips and vice versa, after which we can just xor all the bits.\n+\t */\n+\tTransform reordered = t0;\n+\tif (!!(t1 & Transform::Transpose))\n+\t\treordered = (t0 & Transform::Transpose) |\n+\t\t\t (!!(t0 & Transform::HFlip) ? Transform::VFlip : Transform::Identity) |\n+\t\t\t (!!(t0 & Transform::VFlip) ? Transform::HFlip : Transform::Identity);\n+\n+\treturn reordered ^ t1;\n+}\n+\n+Transform operator-(Transform t)\n+{\n+\t/* All are self-inverses, except for Rot270 and Rot90. */\n+\tstatic const Transform inverses[] = {\n+\t\tTransform::Identity, Transform::HFlip, Transform::VFlip, Transform::HVFlip,\n+\t\tTransform::Transpose, Transform::Rot90, Transform::Rot270, Transform::Rot180Transpose\n+\t};\n+\n+\treturn inverses[static_cast<int>(t)];\n+}\n+\n+Transform transformFromRotation(int angle, bool *success)\n+{\n+\tangle = angle % 360;\n+\tif (angle < 0)\n+\t\tangle += 360;\n+\n+\tif (success != nullptr)\n+\t\t*success = true;\n+\n+\tif (angle == 0)\n+\t\treturn Transform::Identity;\n+\telse if (angle == 90)\n+\t\treturn Transform::Rot90;\n+\telse if (angle == 180)\n+\t\treturn Transform::Rot180;\n+\telse if (angle == 270)\n+\t\treturn Transform::Rot270;\n+\telse if (success != nullptr)\n+\t\t*success = false;\n+\n+\treturn Transform::Identity;\n+}\n+\n+std::string transformToString(Transform t)\n+{\n+\tstatic const char *strings[] = {\n+\t\t\"identity\",\n+\t\t\"hflip\",\n+\t\t\"vflip\",\n+\t\t\"hvflip\",\n+\t\t\"transpose\",\n+\t\t\"rot270\",\n+\t\t\"rot90\",\n+\t\t\"rot180transpose\"\n+\t};\n+\n+\treturn strings[static_cast<int>(t)];\n+}\n+\n+} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v2", "1/5" ] }