Patch Detail
Show a patch.
GET /api/1.1/patches/9195/?format=api
{ "id": 9195, "url": "https://patchwork.libcamera.org/api/1.1/patches/9195/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9195/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200804214711.177645-3-kieran.bingham@ideasonboard.com>", "date": "2020-08-04T21:47:00", "name": "[libcamera-devel,v3,02/13] libcamera: formats: add numPlanes helper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "83afe7d820585f9883b7e924af61fb56f023bbf2", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9195/mbox/", "series": [ { "id": 1191, "url": "https://patchwork.libcamera.org/api/1.1/series/1191/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1191", "date": "2020-08-04T21:46:58", "name": "android: JPEG support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1191/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9195/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9195/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22113BD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2020 21:47:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66ACB60567;\n\tTue, 4 Aug 2020 23:47:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4940C60548\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2020 23:47:17 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8867056E;\n\tTue, 4 Aug 2020 23:47:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fOrQ3usn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596577636;\n\tbh=xOBkeVTzlN+Qtprad+1Xq3vpczkJ7mQZ5vHIrUpNAHg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fOrQ3usnJ4GNSbdix7AX+NUd19V4uBSly/8s/glnJ1tEJZjdchMOLc5u+JvaRKIR6\n\t5nmhuzQUdhOxVN7jTIsO+9k1KRpbmnRlaD19BqsNU+Ip5OmEi3yoUH33AOS14BsEjZ\n\tCSz3ZBoNt5KwND+NJwFwwocWneyJRiPnDxs61l10=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 4 Aug 2020 22:47:00 +0100", "Message-Id": "<20200804214711.177645-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200804214711.177645-1-kieran.bingham@ideasonboard.com>", "References": "<20200804214711.177645-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 02/13] libcamera: formats: add\n\tnumPlanes helper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Determine the number of planes used by a format by counting the number\nof PixelFormatPlaneInfo entries with a valid entry.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv3:\n - Rename $SUBJECT :D\n\nv2:\n - Rename to numPlanes\n - Simplify fucntion doc.\n---\n include/libcamera/internal/formats.h | 2 ++\n src/libcamera/formats.cpp | 18 ++++++++++++++++++\n 2 files changed, 20 insertions(+)", "diff": "diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex b8e474916378..51a8a6b8b0ae 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -46,6 +46,8 @@ public:\n \tunsigned int frameSize(const Size &size,\n \t\t\t const std::array<unsigned int, 3> &strides) const;\n \n+\tunsigned int numPlanes() const;\n+\n \t/* \\todo Add support for non-contiguous memory planes */\n \tconst char *name;\n \tPixelFormat format;\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex a51e96810aed..ebaae9be3d75 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -821,4 +821,22 @@ PixelFormatInfo::frameSize(const Size &size,\n \treturn sum;\n }\n \n+/**\n+ * \\brief Retrieve the number of planes represented by the format\n+ * \\return The number of planes used by the format\n+ */\n+unsigned int PixelFormatInfo::numPlanes() const\n+{\n+\tunsigned int count = 0;\n+\n+\tfor (const PixelFormatPlaneInfo &p : planes) {\n+\t\tif (p.bytesPerGroup == 0)\n+\t\t\tbreak;\n+\n+\t\tcount++;\n+\t}\n+\n+\treturn count;\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v3", "02/13" ] }