Patch Detail
Show a patch.
GET /api/1.1/patches/9186/?format=api
{ "id": 9186, "url": "https://patchwork.libcamera.org/api/1.1/patches/9186/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9186/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200804161358.1628962-4-niklas.soderlund@ragnatech.se>", "date": "2020-08-04T16:13:52", "name": "[libcamera-devel,v7,3/9] libcamera: v4l2_device: Add method to lookup device path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3345b0e9c096e09bca975c85d5fb20b818f4defa", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9186/mbox/", "series": [ { "id": 1190, "url": "https://patchwork.libcamera.org/api/1.1/series/1190/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1190", "date": "2020-08-04T16:13:49", "name": "libcamera: Generate unique and stable camera IDs", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1190/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9186/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9186/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2E1BBD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2020 16:14:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F33260564;\n\tTue, 4 Aug 2020 18:14:25 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 200B560555\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2020 18:14:22 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 8db6e245-d66d-11ea-b48b-0050569116f7;\n\tTue, 04 Aug 2020 18:14:20 +0200 (CEST)" ], "X-Halon-ID": "8db6e245-d66d-11ea-b48b-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 4 Aug 2020 18:13:52 +0200", "Message-Id": "<20200804161358.1628962-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>", "References": "<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 3/9] libcamera: v4l2_device: Add method\n\tto lookup device path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a method to lookup a V4L2 devices path in sysfs.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n* Changes since v6\n- Use sysfs:: helper.\n- Do not try to return std::string { nullptr } on error.\n\n* Changes since v5\n- Expand documentation\n- Use DeviceEnumerator interface to lookup device path\n- Include stdlib.h\n- Use realpath(..., nullptr); ...; free();\n\n* Changes since v3\n- s/the device path/the device path in sysfs/\n---\n include/libcamera/internal/v4l2_device.h | 1 +\n src/libcamera/v4l2_device.cpp | 28 ++++++++++++++++++++++++\n 2 files changed, 29 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex bf643f2ec966bb33..3b605aab343b3b94 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -30,6 +30,7 @@ public:\n \tint setControls(ControlList *ctrls);\n \n \tconst std::string &deviceNode() const { return deviceNode_; }\n+\tstd::string devicePath() const;\n \n protected:\n \tV4L2Device(const std::string &deviceNode);\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 56ea1ddda2c1425f..e55deabed46e30d4 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -9,12 +9,15 @@\n \n #include <fcntl.h>\n #include <iomanip>\n+#include <limits.h>\n+#include <stdlib.h>\n #include <string.h>\n #include <sys/ioctl.h>\n #include <sys/syscall.h>\n #include <unistd.h>\n \n #include \"libcamera/internal/log.h\"\n+#include \"libcamera/internal/sysfs.h\"\n #include \"libcamera/internal/utils.h\"\n #include \"libcamera/internal/v4l2_controls.h\"\n \n@@ -350,6 +353,31 @@ int V4L2Device::setControls(ControlList *ctrls)\n \treturn ret;\n }\n \n+/**\n+ * \\brief Retrieve the device path in sysfs\n+ *\n+ * This function returns the sysfs path to the physical device backing the V4L2\n+ * device. The path is guaranteed to be an absolute path, without any symbolic\n+ * link.\n+ *\n+ * \\return The device path in sysfs\n+ */\n+std::string V4L2Device::devicePath() const\n+{\n+\tstd::string devicePath = sysfs::charDevPath(deviceNode_) + \"/device\";\n+\n+\tchar *realPath = realpath(devicePath.c_str(), nullptr);\n+\tif (!realPath) {\n+\t\tLOG(V4L2, Fatal) << \"Can not resolve path for \" << devicePath;\n+\t\treturn {};\n+\t}\n+\n+\tstd::string path{ realPath };\n+\tfree(realPath);\n+\n+\treturn path;\n+}\n+\n /**\n * \\brief Perform an IOCTL system call on the device node\n * \\param[in] request The IOCTL request code\n", "prefixes": [ "libcamera-devel", "v7", "3/9" ] }