Patch Detail
Show a patch.
GET /api/1.1/patches/9180/?format=api
{ "id": 9180, "url": "https://patchwork.libcamera.org/api/1.1/patches/9180/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9180/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200804113107.127257-3-kieran.bingham@ideasonboard.com>", "date": "2020-08-04T11:31:07", "name": "[libcamera-devel,2/2] android: camera_metadata: Report storage usages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1b8dfa043ddcfc12eff7151f8429a8e5701c7ac0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/9180/mbox/", "series": [ { "id": 1188, "url": "https://patchwork.libcamera.org/api/1.1/series/1188/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1188", "date": "2020-08-04T11:31:05", "name": "android: metadata usage tracking", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1188/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9180/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9180/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44CEBBD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2020 11:31:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FA3B6042B;\n\tTue, 4 Aug 2020 13:31:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31E16603C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2020 13:31:21 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0776564;\n\tTue, 4 Aug 2020 13:31:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LO9XGvvB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596540675;\n\tbh=V3gffTspTv+bDMskl0HkcS8BKrtK4W1B6GIy+yS7nHI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LO9XGvvBJuclo2LuOaZzivPC8a2Wi8V2YppRTJDejL43smZGCnZ6j4zAsNUIn+KMW\n\tsQfH8fKta6YQG3NEBMpKeVjEXsfyelDa1P32sRXSu/0eiITMW37/2aKNC0CBptivz4\n\tg82rKr7GHsIT41oK+Su+6Il1YgOmUHSc7bqk10VY=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 4 Aug 2020 12:31:07 +0100", "Message-Id": "<20200804113107.127257-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200804113107.127257-1-kieran.bingham@ideasonboard.com>", "References": "<20200804113107.127257-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] android: camera_metadata: Report\n\tstorage usages", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report the actual usage of the containers used for camera_metadata.\nThis is particularly useful whilst we require manual pre-allocation of\nthe correctly determined size requirements.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/camera_device.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 42b08cfc5fed..1a6ad81c6282 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -844,6 +844,8 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t availableResultKeys.data(),\n \t\t\t\t availableResultKeys.size());\n \n+\tLOG(HAL, Debug) << \"StaticMetadata usage: \" << staticMetadata_->usage();\n+\n \tif (!staticMetadata_->isValid()) {\n \t\tLOG(HAL, Error) << \"Failed to construct static metadata\";\n \t\tdelete staticMetadata_;\n@@ -947,6 +949,8 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \trequestTemplate->addEntry(ANDROID_CONTROL_CAPTURE_INTENT,\n \t\t\t\t &captureIntent, 1);\n \n+\tLOG(HAL, Debug) << \"requestTemplate usage: \" << requestTemplate->usage();\n+\n \tif (!requestTemplate->isValid()) {\n \t\tLOG(HAL, Error) << \"Failed to construct request template\";\n \t\tdelete requestTemplate;\n@@ -1483,6 +1487,8 @@ std::unique_ptr<CameraMetadata> CameraDevice::getResultMetadata(int frame_number\n \tresultMetadata->addEntry(ANDROID_STATISTICS_SCENE_FLICKER,\n \t\t\t\t &scene_flicker, 1);\n \n+\tLOG(HAL, Debug) << \"resultMetadata usage: \" << resultMetadata->usage();\n+\n \t/*\n \t * Return the result metadata pack even is not valid: get() will return\n \t * nullptr.\n", "prefixes": [ "libcamera-devel", "2/2" ] }