Patch Detail
Show a patch.
GET /api/1.1/patches/9172/?format=api
{ "id": 9172, "url": "https://patchwork.libcamera.org/api/1.1/patches/9172/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9172/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200804095850.275499-8-naush@raspberrypi.com>", "date": "2020-08-04T09:58:45", "name": "[libcamera-devel,v6,07/12] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ef49a90f1640831fa6144d3171847607fbe9e2bd", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9172/mbox/", "series": [ { "id": 1187, "url": "https://patchwork.libcamera.org/api/1.1/series/1187/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1187", "date": "2020-08-04T09:58:38", "name": "Zero-copy RAW stream work", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1187/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9172/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9172/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5DB4BD87B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2020 09:59:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B09A260547;\n\tTue, 4 Aug 2020 11:59:05 +0200 (CEST)", "from mail-wm1-x344.google.com (mail-wm1-x344.google.com\n\t[IPv6:2a00:1450:4864:20::344])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D96C6053B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2020 11:59:03 +0200 (CEST)", "by mail-wm1-x344.google.com with SMTP id g8so2104110wmk.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 04 Aug 2020 02:59:03 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm34047234wrh.18.2020.08.04.02.59.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 04 Aug 2020 02:59:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"TNAIreQY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=4Ux2KzIjE78zos/U1JdkYUuRbOMWY4gvRVijLHAsfZQ=;\n\tb=TNAIreQY5W+iz/dHNsdlvsKxaiHGEqQz7PdO4T8uy2QGKvYyhwT8hEvGRLdTY6K5AX\n\tXrJ8iO4E2p8q2WaRznt2+vdJFb2nI2X37jdUllSn7/qpZwkFu0r7DdBQjo2+ilmMfmpM\n\t6JeaB2LU+hcWb5T8fb/hTP/6i8RagbDNoffa9MkJ3YC7jV2+DSt8FQ4+++h01p3pNqqp\n\teRDBqNHa6FP/7VpFXQz/CXoH686DfzrB0OpYEoQqU2vs4gNHx7v+USrXKjD5TbtxQQXc\n\tKpMr5Mj7RmrwAhOQGMV8aF0XtoiADQwWGNvWzkA1lM9idYO3ekPteHUh5SwsTt2HTFEK\n\tln0Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=4Ux2KzIjE78zos/U1JdkYUuRbOMWY4gvRVijLHAsfZQ=;\n\tb=SYnFAw85zuAUpGY5lAQF2WlPojKRfDYFssQS05P2CRs+iYTyOR4iXLp5HnwVAqk/Q+\n\tqVgsSGKF5eh0wow3jNPY7lsNd5HmRC9Kp5qPnIP9+EYpZclucqmgdRLSHmByVruPl3ol\n\tHwRhAY2/maC6SIp+BGMu73fkxt3ypKB6lJ77QaQ2ouKgC1MSkEKtCfQF2gpG2YlwY+DZ\n\tRI2Bpu0rqdsWaMTmncpbD+uZKVrLMSl3Gy2aj13pLOXHeFibmWNCt/d6FTxpHyx800ZI\n\tTx/hxy+CPoTpTpkGvHDOGDRxURMCTlLzkfJr21BEzjCV0zdR12amf16kY8mgkEU11WmA\n\tLLvg==", "X-Gm-Message-State": "AOAM531VObKLBMk4PYreigz8gEepeZ2sF1mPWNG2n2EBP2CvwLpAwphU\n\tEn0Xm8MG7j+Ga6sI7BWOKMmYaN0smvqUSQ==", "X-Google-Smtp-Source": "ABdhPJzlXQTPU/GjtpJWK/HzRPt/zZNOAApAI9yFAbsYFssbF0nFC4Z6JFZxLTkcyTcmhYeIPkNR2Q==", "X-Received": "by 2002:a1c:9952:: with SMTP id b79mr3360022wme.68.1596535143102;\n\tTue, 04 Aug 2020 02:59:03 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 4 Aug 2020 10:58:45 +0100", "Message-Id": "<20200804095850.275499-8-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200804095850.275499-1-naush@raspberrypi.com>", "References": "<20200804095850.275499-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 07/12] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex d4791a16..0c8e352d 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -983,12 +983,13 @@ int RPiCameraData::configureIPA()\n \tunsigned int i = 0;\n \tfor (auto const &stream : isp_) {\n \t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n \t\t}\n \t}\n+\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n", "prefixes": [ "libcamera-devel", "v6", "07/12" ] }