Patch Detail
Show a patch.
GET /api/1.1/patches/9147/?format=api
{ "id": 9147, "url": "https://patchwork.libcamera.org/api/1.1/patches/9147/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9147/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200803161816.107113-8-kieran.bingham@ideasonboard.com>", "date": "2020-08-03T16:18:11", "name": "[libcamera-devel,v2,07/12] android: camera_device: Only construct required planes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d24035f9d9f5164a254385d85047ab787a4b76e0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9147/mbox/", "series": [ { "id": 1183, "url": "https://patchwork.libcamera.org/api/1.1/series/1183/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1183", "date": "2020-08-03T16:18:04", "name": "android: jpeg", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1183/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9147/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9147/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15C68BD87B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2020 16:18:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D588661ACD;\n\tMon, 3 Aug 2020 18:18:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9154D619CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2020 18:18:25 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18842DA0;\n\tMon, 3 Aug 2020 18:18:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EDRfkF/K\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596471505;\n\tbh=AbPYBkydbCRoiGrcWQRan60YLgJZyyMShJ6atIn/YHs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EDRfkF/KFV0u3lqo1/LtQ8Qwqc+bSFNm8Bnzma3yBU0w904Bsy2qUoYoBa+2HaHm7\n\t5IytFakeSgWuPu8bpFUEWp+gZ6NPrpbljXG19AGfFvNywNMAxlv3nB/yvlDs7BMmAE\n\ttq3X31sxWFEA2pGWLqQf15WYxzTCR6LqRicsvNco=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 3 Aug 2020 17:18:11 +0100", "Message-Id": "<20200803161816.107113-8-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200803161816.107113-1-kieran.bingham@ideasonboard.com>", "References": "<20200803161816.107113-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 07/12] android: camera_device: Only\n\tconstruct required planes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The camera3buffer describes the number of filedescriptors given.\nDon't try to construct more planes than that.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 388945b1075c..78b0246e40f0 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1022,9 +1022,20 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer)\n {\n \tstd::vector<FrameBuffer::Plane> planes;\n-\tfor (unsigned int i = 0; i < 3; i++) {\n+\tfor (int i = 0; i < camera3buffer->numFds; i++) {\n+\t\t/* Skip unused planes. */\n+\t\tif (camera3buffer->data[i] == -1)\n+\t\t\tbreak;\n+\n \t\tFrameBuffer::Plane plane;\n \t\tplane.fd = FileDescriptor(camera3buffer->data[i]);\n+\t\tif (!plane.fd.isValid()) {\n+\t\t\tLOG(HAL, Error) << \"Failed to obtain FileDescriptor (\"\n+\t\t\t\t\t<< camera3buffer->data[i] << \") \"\n+\t\t\t\t\t<< \" on plane \" << i;\n+\t\t\tbreak;\n+\t\t}\n+\n \t\t/*\n \t\t * Setting length to zero here is OK as the length is only used\n \t\t * to map the memory of the plane. Libcamera do not need to poke\n", "prefixes": [ "libcamera-devel", "v2", "07/12" ] }