Patch Detail
Show a patch.
GET /api/1.1/patches/9135/?format=api
{ "id": 9135, "url": "https://patchwork.libcamera.org/api/1.1/patches/9135/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9135/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200802231652.360645-1-niklas.soderlund@ragnatech.se>", "date": "2020-08-02T23:16:52", "name": "[libcamera-devel] libcamera: device_enumerator_udev: Initialize monitor_ and notifier_ to nullptr", "commit_ref": "108b6a8a15487b982612f34bd7b00e7b05be864a", "pull_url": null, "state": "superseded", "archived": false, "hash": "a35cf1efb37e79b25a492f948c21cfddcff9786b", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9135/mbox/", "series": [ { "id": 1178, "url": "https://patchwork.libcamera.org/api/1.1/series/1178/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1178", "date": "2020-08-02T23:16:52", "name": "[libcamera-devel] libcamera: device_enumerator_udev: Initialize monitor_ and notifier_ to nullptr", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1178/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9135/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9135/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7740BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 2 Aug 2020 23:17:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE76E609B2;\n\tMon, 3 Aug 2020 01:17:03 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D98D760398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2020 01:17:02 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 3ff37259-d516-11ea-933e-005056917a89;\n\tMon, 03 Aug 2020 01:17:00 +0200 (CEST)" ], "X-Halon-ID": "3ff37259-d516-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 Aug 2020 01:16:52 +0200", "Message-Id": "<20200802231652.360645-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tInitialize monitor_ and notifier_ to nullptr", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The monitor_ and notifier_ pointers are acted on in the destructor if\nnot set to nullptr, the pointers are however first initialized in\nenumerate(). If the object is deleted without enumerate() being called\nthe destructor acts on uninitialized pointers, fix this by initializing\nthem to nullptr.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/device_enumerator_udev.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex 56ca4dc2804b46b9..96689daa5dd113dc 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -27,7 +27,7 @@ namespace libcamera {\n LOG_DECLARE_CATEGORY(DeviceEnumerator)\n \n DeviceEnumeratorUdev::DeviceEnumeratorUdev()\n-\t: udev_(nullptr)\n+\t: udev_(nullptr), monitor_(nullptr), notifier_(nullptr)\n {\n }\n \n", "prefixes": [ "libcamera-devel" ] }